Skip to contentSkip to conversation

drivers: bus: check cci device tree node status

PATCH New Abhilash Kesavan 2 participants 3 messages Jan 10, 2015 – Jan 13, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drivers: bus: check cci device tree node status

The arm-cci driver completes the probe sequence even if the cci node is marked as disabled. Add a check in the driver to honour the cci status in the device tree.

---
Changes:
- Re-sending without the RFT tags

 drivers/bus/arm-cci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/bus/arm-cci.c +3 -0
index 860da40..0ce5e2d 100644
@@ -1312,6 +1312,9 @@ static int cci_probe(void)
 	if (!np)
 		return -ENODEV;
 
+	if (!of_device_is_available(np))
+		return -ENODEV;
+
 	cci_config = of_match_node(arm_cci_matches, np)->data;
 	if (!cci_config)
 		return -ENODEV;
Signature · 1 line
2.2.0
#1 lore raw

PATCH 2/2 arm: dts: disable CCI on exynos420 based arndale-octa

The arndale-octa board was giving "imprecise external aborts" during boot-up with MCPM enabled. CCI enablement of the boot cluster was found to be the cause of these aborts (possibly because the secure f/w was not allowing it). Hence, disable CCI for the arndale-octa board.

---
 arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
 arch/arm/boot/dts/exynos5420.dtsi             | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420-arndale-octa.dts +4 -0
index aa7a7d7..db2c1c4 100644
@@ -372,3 +372,7 @@
 &usbdrd_dwc3_1 {
 	dr_mode = "host";
 };
+
+&cci {
+	status = "disabled";
+};
arch/arm/boot/dts/exynos5420.dtsi +1 -1
index 517e50f..0a82ae7 100644
@@ -120,7 +120,7 @@
 		};
 	};
 
-	cci at 10d20000 {
+	cci: cci at 10d20000 {
 		compatible = "arm,cci-400";
 		#address-cells = <1>;
 		#size-cells = <1>;
Signature · 1 line
2.2.0
#2 lore raw

PATCH 2/2 arm: dts: disable CCI on exynos420 based arndale-octa

Quoted 9 lines · Abhilash Kesavan

The arndale-octa board was giving "imprecise external aborts" during boot-up with MCPM enabled. CCI enablement of the boot cluster was found to be the cause of these aborts (possibly because the secure f/w was not allowing it). Hence, disable CCI for the arndale-octa board.

Applied 1-2 to fixes for 3.19.

Fixed two typos (arm->ARM in subject, and 420->5420).

Thanks,

-Olof