Skip to contentSkip to conversation

watchdog: hpwdt: Fix initialization message in hpwdt.c

PATCH In review Masanari Iida 3 participants 3 messages Oct 22, 2014 – Feb 2, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: hpwdt: Fix initialization message in hpwdt.c

allow_kdump was enabled as default since following commit.

commit a089361cf5f1d6a5295aa5385238bd044998e1e9,
watchdog: hpwdt: Unregister NMI events on exit.

But the initialization message was not modified.
So it still shows

HP Watchdog Timer Driver: NMI decoding initialized,
allow kernel dump: ON (default = 0/OFF) <=

This "default = 0/OFF" message may confuse users.
Fix it as "default = 1/ON".

---
 drivers/watchdog/hpwdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/hpwdt.c +1 -1
index 75d2243..ada3e44 100644
@@ -745,7 +745,7 @@ static int hpwdt_init_nmi_decoding(struct pci_dev *dev)
 
 	dev_info(&dev->dev,
 			"HP Watchdog Timer Driver: NMI decoding initialized"
-			", allow kernel dump: %s (default = 0/OFF)\n",
+			", allow kernel dump: %s (default = 1/ON)\n",
 			(allow_kdump == 0) ? "OFF" : "ON");
 	return 0;
 
Signature · 1 line
2.1.2.451.g98349e5
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Masanari Iida

allow_kdump was enabled as default since following commit.

commit a089361cf5f1d6a5295aa5385238bd044998e1e9,
watchdog: hpwdt: Unregister NMI events on exit.

But the initialization message was not modified.
So it still shows

Quoted 7 lines

HP Watchdog Timer Driver: NMI decoding initialized,
allow kernel dump: ON (default = 0/OFF) <=

This "default = 0/OFF" message may confuse users.
Fix it as "default = 1/ON".

#2 lore raw
In reply to Masanari Iida

Hi Masanari,

Quoted 8 lines

allow_kdump was enabled as default since following commit.

commit a089361cf5f1d6a5295aa5385238bd044998e1e9,
watchdog: hpwdt: Unregister NMI events on exit.

But the initialization message was not modified.
So it still shows

Quoted 7 lines

HP Watchdog Timer Driver: NMI decoding initialized,
allow kernel dump: ON (default = 0/OFF) <=

This "default = 0/OFF" message may confuse users.
Fix it as "default = 1/ON".

Patch has been added to linux-watchdog-next.

Kind regards,
Wim.