Skip to contentSkip to conversation

MIPS: Fix MIPS32_COMPAT recursive dependency

PATCH In review Tony Wu 2 participants 2 messages Jan 13, 2015 – Jan 14, 2015 MIPS

lore
Share & tools
lore

Tony Wu

author
#0 lore raw

PATCH 1/1 MIPS: Fix MIPS32_COMPAT recursive dependency

Commit f92b81f16 (MIPS: Compat: Fix build error if CONFIG_MIPS32_COMPAT but no compat ABI.) introduced a recursive dependency on MIPS32_COMPAT, shown as follows:

arch/mips/Kconfig:2681:error: recursive dependency detected!
arch/mips/Kconfig:2681: symbol MIPS32_N32 depends on MIPS32_COMPAT
arch/mips/Kconfig:2658: symbol MIPS32_COMPAT is selected by MIPS32_N32

Cc Ralf Baechle <[email protected]>
arch/mips/Kconfig +0 -1
index 73983e1..33c0b88 100644
@@ -2680,7 +2680,6 @@ config MIPS32_O32
 
 config MIPS32_N32
 	bool "Kernel support for n32 binaries"
-	depends on MIPS32_COMPAT
 	select COMPAT
 	select MIPS32_COMPAT
 	select SYSVIPC_COMPAT if SYSVIPC
#1 lore raw

On Tue, Jan 13, 2015 at 11:05:02PM +0800, Tony Wu wrote:

I've already applied an identical fix on 3/1.

Ralf