ARM: shmobile: sh73a0/kzm9g: Complete multiplatform support
cover ARM: shmobile: sh73a0/kzm9g: Complete multiplatform support
Hi Simon, Magnus,
This patch series completes the migration from kzm9g-reference (legacy DT based) to kzm9g-multiplatform (ARM multiplatform DT based with common clock framework).
- The first two patches fix Ethernet on kzm9g, by adding a Bus State Controller node, as introduced in "[PATCH v3 0/4] drivers: bus:
Add Simple Power-Managed Bus", and moving the Ethernet node to it,
- The third path enables kzm9g support in shmobile_defconfig,
- The fourth patch removes all kzm9g-reference support, now the sh73a0 generic multiplatform case has the same feature set (better, it provides 16 MiB more RAM!).
Thanks for applying!
Geert Uytterhoeven (4):
ARM: shmobile: sh73a0 dtsi: Add Bus State Controller node
ARM: shmobile: kzm9g dts: Move Ethernet node to BSC
ARM: shmobile: Enable kzm9g board in multiplatform defconfig
ARM: shmobile: kzm9g-reference: Remove board C code and DT file
Documentation/devicetree/bindings/arm/shmobile.txt | 2 - arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 398 --------------------- arch/arm/boot/dts/sh73a0-kzm9g.dts | 28 +- arch/arm/boot/dts/sh73a0.dtsi | 10 + arch/arm/configs/shmobile_defconfig | 19 +- arch/arm/mach-shmobile/Kconfig | 14 - arch/arm/mach-shmobile/Makefile | 1 - arch/arm/mach-shmobile/Makefile.boot | 1 - arch/arm/mach-shmobile/board-kzm9g-reference.c | 62 ---- arch/arm/mach-shmobile/include/mach/zboot.h | 2 +- 11 files changed, 43 insertions(+), 497 deletions(-) delete mode 100644 arch/arm/boot/dts/sh73a0-kzm9g-reference.dts delete mode 100644 arch/arm/mach-shmobile/board-kzm9g-reference.c
Signature · 12 lines
1.9.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvaldscover ARM: shmobile: sh73a0/kzm9g: Complete multiplatform support
Quoted 14 lines · Geert Uytterhoeven
Hi Simon, Magnus,
This patch series completes the migration from kzm9g-reference (legacy DT based) to kzm9g-multiplatform (ARM multiplatform DT based with common clock framework).
- The first two patches fix Ethernet on kzm9g, by adding a Bus State Controller node, as introduced in "[PATCH v3 0/4] drivers: bus:
Add Simple Power-Managed Bus", and moving the Ethernet node to it,
- The third path enables kzm9g support inshmobile_defconfig,
- The fourth patch removes all kzm9g-reference support, now the sh73a0 generic multiplatform case has the same feature set (better, it provides 16 MiB more RAM!).
Quoted 1 line
Thanks for applying!
It seems to me that at the first two patches require the patchset referenced above in order to work. For that reason I am holding off on applying this series. I am quite happy to negotiate merging some or all of this series earlier than later :)
cover ARM: shmobile: sh73a0/kzm9g: Complete multiplatform support
Hi Simon,
Quoted 15 lines · Simon Horman
Quoted 14 lines · Geert Uytterhoeven
Hi Simon, Magnus,
This patch series completes the migration from kzm9g-reference (legacy DT based) to kzm9g-multiplatform (ARM multiplatform DT based with common clock framework).
- The first two patches fix Ethernet on kzm9g, by adding a Bus State Controller node, as introduced in "[PATCH v3 0/4] drivers: bus:
Add Simple Power-Managed Bus", and moving the Ethernet node to it,
- The third path enables kzm9g support inshmobile_defconfig,
- The fourth patch removes all kzm9g-reference support, now the sh73a0 generic multiplatform case has the same feature set (better, it provides 16 MiB more RAM!).
Quoted 4 lines
Quoted 1 line
Thanks for applying!
It seems to me that at the first two patches require the patchset referenced above in order to work. For that reason I am holding off
Yes it does.
Quoted 2 lines
on applying this series. I am quite happy to negotiate merging some or all of this series earlier than later :)
Hence please merge both the dependency and this series.
1. Both sh73a0/kzm9g-multiplatform and r8a73a4/ape6evm-multiplatform depend on "[PATCH v3 0/4] drivers: bus: Add Simple Power-Managed Bus",
2. DT PM domain for sh73a0 and r8a73a4 depends on sh73a0/kzm9g-multiplatform and r8a73a4/ape6evm-multiplatform,
3. CONFIG_CPU_IDLE=y hangs on sh73a0 without an early timer.
- On kzm9g-multiplatform this can be fixed by adding an arm,cortex-a9-twd-timer node, but that breaks kzm9g-reference as the TWD driver requires CCF when instantiated from DT,
- Fixing this on kzm9g-reference requires setting ".init_time = sh73a0_earlytimer_init", and also instantiating the GIC from C board code, as the TWD platform device uses an hardcoded interrupt number.
It seems simpler to let kzm9g-reference die, so this problem goes away.
Thanks for your consideration!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
cover ARM: shmobile: sh73a0/kzm9g: Complete multiplatform support
Quoted 25 lines · Geert Uytterhoeven
Hi Simon,
Quoted 15 lines · Simon Horman
Quoted 14 lines · Geert Uytterhoeven
Hi Simon, Magnus,
This patch series completes the migration from kzm9g-reference (legacy DT based) to kzm9g-multiplatform (ARM multiplatform DT based with common clock framework).
- The first two patches fix Ethernet on kzm9g, by adding a Bus State Controller node, as introduced in "[PATCH v3 0/4] drivers: bus:
Add Simple Power-Managed Bus", and moving the Ethernet node to it,
- The third path enables kzm9g support inshmobile_defconfig,
- The fourth patch removes all kzm9g-reference support, now the sh73a0 generic multiplatform case has the same feature set (better, it provides 16 MiB more RAM!).Quoted 4 lines
Quoted 1 line
Thanks for applying!
It seems to me that at the first two patches require the patchset referenced above in order to work. For that reason I am holding off
Yes it does.
Quoted 7 lines
Quoted 2 lines
on applying this series. I am quite happy to negotiate merging some or all of this series earlier than later :)
Hence please merge both the dependency and this series.
1. Both sh73a0/kzm9g-multiplatform and r8a73a4/ape6evm-multiplatform depend on "[PATCH v3 0/4] drivers: bus: Add Simple Power-Managed Bus",
For some reason I assumed this would go through a different subsystem tree. I'm fine with taking it through my tree, if you think that is best.
I am a bit worried about handling conflicts that may arise, especially from the first two patches in that series which re-arrange things alphabetically. But I see that the files in question are not updated very often, so I suppose we should be safe enough.
For now I have tentatively queued up both this patchset and the dependency listed immediately above. Please take a look
at the sh73a0-multiplatform-for-v3.20 and drivers-for-v3.20 branches and the renesas-next-20150114-v3.19-rc1 tag to see if I missed something.
Quoted 26 lines
2. DT PM domain for sh73a0 and r8a73a4 depends on sh73a0/kzm9g-multiplatform and r8a73a4/ape6evm-multiplatform,
3.CONFIG_CPU_IDLE=yhangs on sh73a0 without an early timer.
- On kzm9g-multiplatform this can be fixed by adding an arm,cortex-a9-twd-timer node, but that breaks kzm9g-reference as the TWD driver requires CCF when instantiated from DT,
- Fixing this on kzm9g-reference requires setting ".init_time =sh73a0_earlytimer_init", and also instantiating the GIC from C board code, as the TWD platform device uses an hardcoded interrupt number.
It seems simpler to let kzm9g-reference die, so this problem goes away.Thanks for your consideration!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.orgIn personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
cover ARM: shmobile: sh73a0/kzm9g: Complete multiplatform support
Hi Simon,
Quoted 25 lines · Simon Horman
Quoted 24 lines · Geert Uytterhoeven
Quoted 13 lines · Simon Horman
Quoted 12 lines · Geert Uytterhoeven
This patch series completes the migration from kzm9g-reference (legacy DT based) to kzm9g-multiplatform (ARM multiplatform DT based with common clock framework).
- The first two patches fix Ethernet on kzm9g, by adding a Bus State Controller node, as introduced in "[PATCH v3 0/4] drivers: bus:
Add Simple Power-Managed Bus", and moving the Ethernet node to it,
- The third path enables kzm9g support inshmobile_defconfig,
- The fourth patch removes all kzm9g-reference support, now the sh73a0 generic multiplatform case has the same feature set (better, it provides 16 MiB more RAM!).Quoted 4 lines
Quoted 1 line
Thanks for applying!
It seems to me that at the first two patches require the patchset referenced above in order to work. For that reason I am holding off
Yes it does.
Quoted 2 lines
on applying this series. I am quite happy to negotiate merging some or all of this series earlier than later :)
Quoted 7 lines
Quoted 4 lines
Hence please merge both the dependency and this series.
1. Both sh73a0/kzm9g-multiplatform and r8a73a4/ape6evm-multiplatform depend on "[PATCH v3 0/4] drivers: bus: Add Simple Power-Managed Bus",
For some reason I assumed this would go through a different subsystem tree. I'm fine with taking it through my tree, if you think that is best.
There's no maintainer for drivers/bus/, and as kzm9g-multiplatform depends on it, your tree looks fine to me.
Quoted 4 lines
I am a bit worried about handling conflicts that may arise, especially from the first two patches in that series which re-arrange things alphabetically. But I see that the files in question are not updated very often, so I suppose we should be safe enough.
Indeed.
Quoted 4 lines
For now I have tentatively queued up both this patchset and the dependency listed immediately above. Please take a look
at the sh73a0-multiplatform-for-v3.20 and drivers-for-v3.20 branches and the renesas-next-20150114-v3.19-rc1 tag to see if I missed something.
Thanks, looks fine!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
cover ARM: shmobile: sh73a0/kzm9g: Complete multiplatform support
Quoted 30 lines · Geert Uytterhoeven
Hi Simon,
Quoted 27 lines · Simon Horman
Quoted 26 lines · Geert Uytterhoeven
Quoted 13 lines · Simon Horman
Quoted 12 lines · Geert Uytterhoeven
This patch series completes the migration from kzm9g-reference (legacy DT based) to kzm9g-multiplatform (ARM multiplatform DT based with common clock framework).
- The first two patches fix Ethernet on kzm9g, by adding a Bus State Controller node, as introduced in "[PATCH v3 0/4] drivers: bus:
Add Simple Power-Managed Bus", and moving the Ethernet node to it,
- The third path enables kzm9g support inshmobile_defconfig,
- The fourth patch removes all kzm9g-reference support, now the sh73a0 generic multiplatform case has the same feature set (better, it provides 16 MiB more RAM!).Quoted 4 lines
Quoted 1 line
Thanks for applying!
It seems to me that at the first two patches require the patchset referenced above in order to work. For that reason I am holding off
Yes it does.
Quoted 2 lines
on applying this series. I am quite happy to negotiate merging some or all of this series earlier than later :)
Hence please merge both the dependency and this series.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
1. Both sh73a0/kzm9g-multiplatform and r8a73a4/ape6evm-multiplatform depend on "[PATCH v3 0/4] drivers: bus: Add Simple Power-Managed Bus",
For some reason I assumed this would go through a different subsystem tree. I'm fine with taking it through my tree, if you think that is best.
There's no maintainer for
drivers/bus/, and as kzm9g-multiplatform depends on it, your tree looks fine to me.
On closer examination I also see that there is no drivers/bus/ maintainer. So yes, I agree we should be fine.
Quoted 5 lines
Quoted 4 lines
I am a bit worried about handling conflicts that may arise, especially from the first two patches in that series which re-arrange things alphabetically. But I see that the files in question are not updated very often, so I suppose we should be safe enough.
Quoted 8 lines
Indeed.
Quoted 4 lines
For now I have tentatively queued up both this patchset and the dependency listed immediately above. Please take a look
at the sh73a0-multiplatform-for-v3.20 and drivers-for-v3.20 branches and the renesas-next-20150114-v3.19-rc1 tag to see if I missed something.Thanks, looks fine!
Great, thanks for checking.
My plan is to send pull-requests for those branches once they have sat in next for a little bit. By my calculations that should be early next week.