Skip to contentSkip to conversation

rt-tests: fix build of NTPL dependent tests

PATCH New Baruch Siach 3 participants 4 messages Jan 15, 2015

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 rt-tests: fix build of NTPL dependent tests

Commit 143fe5b443da4 (rt-tests: allow building subset of tests with non-NPTL toolchains) disabled build of NPTL dependent tests unconditionally. Fix this.

Cc Alexey Brodkin <[email protected]>
Reported-by "Williams Jr., Ernest L." <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/rt-tests/rt-tests.mk | 2 ++
 1 file changed, 2 insertions(+)
package/rt-tests/rt-tests.mk +2 -0
index e0c7748c9c3b..009e9a6818ce 100644
@@ -15,6 +15,8 @@ endif
 
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),)
 RT_TESTS_HAVE_NPTL=no
+else
+RT_TESTS_HAVE_NPTL=yes
 endif
 
 define RT_TESTS_BUILD_CMDS
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 rt-tests: fix build of NTPL dependent tests

Hi Baruch,

Quoted 15 lines · Baruch Siach

Commit 143fe5b443da4 (rt-tests: allow building subset of tests with non-NPTL toolchains) disabled build of NPTL dependent tests unconditionally. Fix this.

Cc Alexey Brodkin <[email protected]>
Reported-by "Williams Jr., Ernest L." <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/rt-tests/rt-tests.mk | 2 ++
 1 file changed, 2 insertions(+)
package/rt-tests/rt-tests.mk +0 -0
index e0c7748c9c3b..009e9a6818ce 100644

package/rt-tests/rt-tests.mk endif · line 20

Quoted 6 lines
package/rt-tests/rt-tests.mk +2 -0
@@ -15,6 +15,8 @@ endif
 
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),)
 RT_TESTS_HAVE_NPTL=no
+else
+RT_TESTS_HAVE_NPTL=yes
 endif

My bad - indeed if build system passes "HAVE_NPTL=" to "rt-tests" then default "yes" won't be used in rt-test's Makefile (I mean "HAVE_NPTL ?= yes").

Thanks for fixing this.

Please don't hesitate to add:
--->8---

Tested-by Alexey Brodkin <[email protected]>

--->8---

Regards,
Alexey

author
#2 lore raw

PATCH 1/1 rt-tests: fix build of NTPL dependent tests

In reply to Baruch Siach

Hi buildroot list,

s/NTPL/NPTL/ in subject. Sorry.

baruch

Quoted 26 lines · Baruch Siach

Commit 143fe5b443da4 (rt-tests: allow building subset of tests with non-NPTL toolchains) disabled build of NPTL dependent tests unconditionally. Fix this.

Cc Alexey Brodkin <[email protected]>
Reported-by "Williams Jr., Ernest L." <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/rt-tests/rt-tests.mk | 2 ++
 1 file changed, 2 insertions(+)
package/rt-tests/rt-tests.mk +2 -0
index e0c7748c9c3b..009e9a6818ce 100644
@@ -15,6 +15,8 @@ endif
 
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),)
 RT_TESTS_HAVE_NPTL=no
+else
+RT_TESTS_HAVE_NPTL=yes
 endif
 
 define RT_TESTS_BUILD_CMDS
Signature · 1 line
2.1.4
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Applied
#3 lore raw

PATCH 1/1 rt-tests: fix build of NTPL dependent tests

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 9 lines · Baruch Siach

Commit 143fe5b443da4 (rt-tests: allow building subset of tests with non-NPTL toolchains) disabled build of NPTL dependent tests unconditionally. Fix this.

Cc Alexey Brodkin <[email protected]>
Reported-by "Williams Jr., Ernest L." <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/rt-tests/rt-tests.mk | 2 ++
 1 file changed, 2 insertions(+)

Thanks, applied, after fixing the commit title, and reversing the condition to use positive logic.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com