Skip to contentSkip to conversation

start-stop-daemon: fix build on non listed architectures

PATCH New Baruch Siach 3 participants 3 messages Jan 16, 2015

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 start-stop-daemon: fix build on non listed architectures

Not all Buildroot supported architectures are known to dpkg. Convert the configure error to a warning.

Fixes:
http://autobuild.buildroot.net/results/24e/24e37550749dc15ed7223fd515fa4628803f341e/
http://autobuild.buildroot.net/results/445/445bf4742d78a0bf93b4c75dc733c4315530031e/
http://autobuild.buildroot.net/results/952/952051485f23b67ffc449360886d6757c385331f/

Signed-off-by Baruch Siach <[email protected]>
---
 .../0002-just-warn-on-missing-arch.patch              | 19 +++++++++++++++++++
 package/start-stop-daemon/start-stop-daemon.mk        |  2 ++
 2 files changed, 21 insertions(+)
 create mode 100644 package/start-stop-daemon/0002-just-warn-on-missing-arch.patch
package/start-stop-daemon/0002-just-warn-on-missing-arch.patch new file +19 -0
new file mode 100644
index 000000000000..2b9cd3db1766
@@ -0,0 +1,19 @@
+Just warn on missing arch
+
+Some architectures are not listed in dpkg list (e.g. mips64el, xtensa, sh4a).
+Don't break the build for that.
+
+Signed-off-by: Baruch Siach <[email protected]>
+---
+diff -Nuar dpkg-1.16.15-orig/m4/dpkg-arch.m4 dpkg-1.16.15/m4/dpkg-arch.m4
+--- dpkg-1.16.15-orig/m4/dpkg-arch.m4	2014-05-30 02:47:25.000000000 +0300
++++ dpkg-1.16.15/m4/dpkg-arch.m4	2015-01-16 06:55:19.701596362 +0200
+@@ -57,7 +57,7 @@
+ AC_MSG_CHECKING([dpkg architecture name])
+ _DPKG_ARCHITECTURE([DEB_HOST_ARCH], [dpkg_arch])
+ if test "x$dpkg_arch" = "x"; then
+-	AC_MSG_ERROR([cannot determine host dpkg architecture])
++	AC_MSG_WARN([cannot determine host dpkg architecture])
+ else
+ 	AC_MSG_RESULT([$dpkg_arch])
+ fi
package/start-stop-daemon/start-stop-daemon.mk +2 -0
index 021edd19c8cf..5df44d4cfbe1 100644
@@ -20,6 +20,8 @@ START_STOP_DAEMON_CONF_ENV = \
 	dpkg_cv_c99_snprintf=yes
 START_STOP_DAEMON_DEPENDENCIES = host-pkgconf \
 	$(if $(BR2_PACKAGE_BUSYBOX),busybox)
+# Patching m4/dpkg-arch.m4
+START_STOP_DAEMON_AUTORECONF = YES
 START_STOP_DAEMON_LICENSE = GPLv2+
 START_STOP_DAEMON_LICENSE_FILES = COPYING
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 start-stop-daemon: fix build on non listed architectures

Dear Baruch Siach,

Reviewed-by Vicente Olivert Riera <[email protected]>
Tested-by Vicente Olivert Riera <[email protected]>

Best regards,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com

Quoted 54 lines · Baruch Siach

Not all Buildroot supported architectures are known to dpkg. Convert the configure error to a warning.

Fixes:
http://autobuild.buildroot.net/results/24e/24e37550749dc15ed7223fd515fa4628803f341e/
http://autobuild.buildroot.net/results/445/445bf4742d78a0bf93b4c75dc733c4315530031e/
http://autobuild.buildroot.net/results/952/952051485f23b67ffc449360886d6757c385331f/

Signed-off-by Baruch Siach <[email protected]>
---
  .../0002-just-warn-on-missing-arch.patch              | 19 +++++++++++++++++++
  package/start-stop-daemon/start-stop-daemon.mk        |  2 ++
  2 files changed, 21 insertions(+)

create mode 100644 package/start-stop-daemon/0002-just-warn-on-missing-arch.patch

package/start-stop-daemon/0002-just-warn-on-missing-arch.patch new file +19 -0
new file mode 100644
index 000000000000..2b9cd3db1766
@@ -0,0 +1,19 @@
+Just warn on missing arch
+
+Some architectures are not listed in dpkg list (e.g. mips64el, xtensa, sh4a).
+Don't break the build for that.
+
+Signed-off-by: Baruch Siach <[email protected]>
+---
+diff -Nuar dpkg-1.16.15-orig/m4/dpkg-arch.m4 dpkg-1.16.15/m4/dpkg-arch.m4
+--- dpkg-1.16.15-orig/m4/dpkg-arch.m4	2014-05-30 02:47:25.000000000 +0300
++++ dpkg-1.16.15/m4/dpkg-arch.m4	2015-01-16 06:55:19.701596362 +0200
+@@ -57,7 +57,7 @@
+ AC_MSG_CHECKING([dpkg architecture name])
+ _DPKG_ARCHITECTURE([DEB_HOST_ARCH], [dpkg_arch])
+ if test "x$dpkg_arch" = "x"; then
+-	AC_MSG_ERROR([cannot determine host dpkg architecture])
++	AC_MSG_WARN([cannot determine host dpkg architecture])
+ else
+ 	AC_MSG_RESULT([$dpkg_arch])
+ fi
package/start-stop-daemon/start-stop-daemon.mk +2 -0
index 021edd19c8cf..5df44d4cfbe1 100644
@@ -20,6 +20,8 @@ START_STOP_DAEMON_CONF_ENV = \
  	dpkg_cv_c99_snprintf=yes
  START_STOP_DAEMON_DEPENDENCIES = host-pkgconf \
  	$(if $(BR2_PACKAGE_BUSYBOX),busybox)
+# Patching m4/dpkg-arch.m4
+START_STOP_DAEMON_AUTORECONF = YES
  START_STOP_DAEMON_LICENSE = GPLv2+
  START_STOP_DAEMON_LICENSE_FILES = COPYING
Applied
#2 lore raw

PATCH 1/1 start-stop-daemon: fix build on non listed architectures

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 9 lines · Baruch Siach

Not all Buildroot supported architectures are known to dpkg. Convert the configure error to a warning.

Fixes:
http://autobuild.buildroot.net/results/24e/24e37550749dc15ed7223fd515fa4628803f341e/
http://autobuild.buildroot.net/results/445/445bf4742d78a0bf93b4c75dc733c4315530031e/
http://autobuild.buildroot.net/results/952/952051485f23b67ffc449360886d6757c385331f/

Signed-off-by Baruch Siach <[email protected]>

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com