Skip to contentSkip to conversation

jimtcl: change the way of define JIMTCL_INSTALL_LIB variable

PATCH New Jerzy Grzegorek 3 participants 4 messages Jan 15, 2015 – Apr 1, 2015

lore
Share & tools
lore

Jerzy Grzegorek

author
#0 lore raw

PATCH 1/1 jimtcl: change the way of define JIMTCL_INSTALL_LIB variable

Signed-off-by Jerzy Grzegorek <[email protected]>
---
 package/jimtcl/jimtcl.mk |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/jimtcl/jimtcl.mk +3 -2
index 75c0382..c2e04ff 100644
@@ -32,10 +32,11 @@ JIMTCL_INSTALL_LIB =
 else
 JIMTCL_SHARED = --shared
 JIMTCL_LIB = so.$(JIMTCL_VERSION)
-JIMTCL_INSTALL_LIB = \
+define JIMTCL_INSTALL_LIB
 	$(INSTALL) -D $(@D)/libjim.$(JIMTCL_LIB) \
-	$(TARGET_DIR)/usr/lib/libjim.$(JIMTCL_LIB); \
+		$(TARGET_DIR)/usr/lib/libjim.$(JIMTCL_LIB)
 	ln -s libjim.$(JIMTCL_LIB) $(TARGET_DIR)/usr/lib/libjim.so
+endef
 endif
 
 define JIMTCL_CONFIGURE_CMDS
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 jimtcl: change the way of define JIMTCL_INSTALL_LIB variable

Jerzy, All,

On 2015-01-15 18:18 +0100, Jerzy Grzegorek spake thusly:

Quoted 1 line
Signed-off-by Jerzy Grzegorek <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

However, there is something really fishy in _INSTALL_STAGING_CMDS:

    define JIMTCL_INSTALL_STAGING_CMDS
        for i in $(JIMTCL_HEADERS_TO_INSTALL); do \
                cp -a $(@D)/$$i $(STAGING_DIR)/usr/include/ || exit 1 ; \
        done; \
        $(INSTALL) -D $(@D)/libjim.$(JIMTCL_LIB) $(STAGING_DIR)/usr/lib/libjim.$(JIMTCL_LIB);
        ln -s libjim.$(JIMTCL_LIB) $(STAGING_DIR)/usr/lib/libjim.so
    endef

In case we're static-only, JIMTCL_LIB=a , so we're linking the static library to the shared one. Surely this is just busted. no?

While you're at touching jimctl, would you care having a look, please?

Thanks! :-)

Regards,
Yann E. MORIN.

Quoted 29 lines
---
 package/jimtcl/jimtcl.mk |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/jimtcl/jimtcl.mk +3 -2
index 75c0382..c2e04ff 100644
@@ -32,10 +32,11 @@ JIMTCL_INSTALL_LIB =
 else
 JIMTCL_SHARED = --shared
 JIMTCL_LIB = so.$(JIMTCL_VERSION)
-JIMTCL_INSTALL_LIB = \
+define JIMTCL_INSTALL_LIB
 	$(INSTALL) -D $(@D)/libjim.$(JIMTCL_LIB) \
-	$(TARGET_DIR)/usr/lib/libjim.$(JIMTCL_LIB); \
+		$(TARGET_DIR)/usr/lib/libjim.$(JIMTCL_LIB)
 	ln -s libjim.$(JIMTCL_LIB) $(TARGET_DIR)/usr/lib/libjim.so
+endef
 endif
 
 define JIMTCL_CONFIGURE_CMDS
Signature · 6 lines
1.7.9.5

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#2 lore raw

PATCH 1/1 jimtcl: change the way of define JIMTCL_INSTALL_LIB variable

Hi Yann,

Quoted 16 lines

Jerzy, All,

On 2015-01-15 18:18 +0100, Jerzy Grzegorek spake thusly:

Quoted 1 line
Signed-off-by Jerzy Grzegorek <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

However, there is something really fishy in _INSTALL_STAGING_CMDS:

     define JIMTCL_INSTALL_STAGING_CMDS
         for i in $(JIMTCL_HEADERS_TO_INSTALL); do \
                 cp -a $(@D)/$$i $(STAGING_DIR)/usr/include/ || exit 1 ; \
         done; \
         $(INSTALL) -D $(@D)/libjim.$(JIMTCL_LIB) $(STAGING_DIR)/usr/lib/libjim.$(JIMTCL_LIB);
         ln -s libjim.$(JIMTCL_LIB) $(STAGING_DIR)/usr/lib/libjim.so
     endef
Quoted 2 lines

In case we're static-only, JIMTCL_LIB=a , so we're linking the static library to the shared one. Surely this is just busted. no?

Yes, indeed.

Quoted 2 lines

While you're at touching jimctl, would you care having a look, please?

OK, will fix.
Thanks for review.

Regards,
Jerzy

Quoted 35 lines

Thanks! :-)

Regards,
Yann E. MORIN.

Quoted 29 lines
---
  package/jimtcl/jimtcl.mk |    5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
package/jimtcl/jimtcl.mk +3 -2
index 75c0382..c2e04ff 100644
@@ -32,10 +32,11 @@ JIMTCL_INSTALL_LIB =
  else
  JIMTCL_SHARED = --shared
  JIMTCL_LIB = so.$(JIMTCL_VERSION)
-JIMTCL_INSTALL_LIB = \
+define JIMTCL_INSTALL_LIB
  	$(INSTALL) -D $(@D)/libjim.$(JIMTCL_LIB) \
-	$(TARGET_DIR)/usr/lib/libjim.$(JIMTCL_LIB); \
+		$(TARGET_DIR)/usr/lib/libjim.$(JIMTCL_LIB)
  	ln -s libjim.$(JIMTCL_LIB) $(TARGET_DIR)/usr/lib/libjim.so
+endef
  endif
 
  define JIMTCL_CONFIGURE_CMDS
Signature · 6 lines
1.7.9.5

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Applied
#3 lore raw

PATCH 1/1 jimtcl: change the way of define JIMTCL_INSTALL_LIB variable

In reply to Jerzy Grzegorek

Dear Jerzy Grzegorek,

Quoted 4 lines · Jerzy Grzegorek
Signed-off-by Jerzy Grzegorek <[email protected]>
---
 package/jimtcl/jimtcl.mk |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com