Skip to contentSkip to conversation

infozip: fix compilation with LARGE_FILE_SUPPORT

PATCH New Richard Genoud 3 participants 3 messages Jan 20, 2015 – Jan 22, 2015

lore
Share & tools
lore

Richard Genoud

author
#0 lore raw

PATCH 1/1 infozip: fix compilation with LARGE_FILE_SUPPORT

Signed-off-by Richard Genoud <[email protected]>
---
 package/infozip/infozip.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
package/infozip/infozip.mk +7 -1
index 229299c52f11..d857df6dd3e9 100644
@@ -14,9 +14,15 @@ ifeq ($(BR2_PACKAGE_BZIP2),y)
 INFOZIP_DEPENDENCIES += bzip2
 endif
 
+INFOZIP_CFLAGS = -I. -DUNIX
+
+ifeq ($(BR2_LARGEFILE),y)
+INFOZIP_CFLAGS += -DLARGE_FILE_SUPPORT
+endif
+
 define INFOZIP_BUILD_CMDS
 	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
-		CFLAGS="$(TARGET_CFLAGS) -I. -DUNIX" \
+		CFLAGS="$(TARGET_CFLAGS) $(INFOZIP_CFLAGS)" \
 		AS="$(TARGET_CC) -c" \
 		-f unix/Makefile generic
 endef
Signature · 1 line
2.0.0
#1 lore raw

PATCH 1/1 infozip: fix compilation with LARGE_FILE_SUPPORT

Dear Richard Genoud,

package/infozip/infozip.mk ifeq ($(BR2_PACKAGE_BZIP2),y) · line 21

Quoted 5 lines · Richard Genoud
package/infozip/infozip.mk +5 -0
+INFOZIP_CFLAGS = -I. -DUNIX
+
+ifeq ($(BR2_LARGEFILE),y)
+INFOZIP_CFLAGS += -DLARGE_FILE_SUPPORT
+endif

Things are not really clear: the INSTALL file from infozip says:

This flag should be set automatically on Unix, Win32, and some other ports. Setting NO_LARGE_FILE_SUPPORT turns this flag off.

So according to this, it should not be necessary to set this flag explicitly. However, after a quick look at the unix/configure script, I haven't seen any logic doing this. Can you confirm?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 infozip: fix compilation with LARGE_FILE_SUPPORT

Richard, Thomas,

Le 20/01/2015 17:41, Thomas Petazzoni a ?crit :

Quoted 15 lines

Dear Richard Genoud,

package/infozip/infozip.mk ifeq ($(BR2_PACKAGE_BZIP2),y) · line 21

Quoted 5 lines · Richard Genoud
package/infozip/infozip.mk +5 -0
+INFOZIP_CFLAGS = -I. -DUNIX
+
+ifeq ($(BR2_LARGEFILE),y)
+INFOZIP_CFLAGS += -DLARGE_FILE_SUPPORT
+endif

Things are not really clear: the INSTALL file from infozip says:

This flag should be set automatically on Unix, Win32, and some other ports. Setting NO_LARGE_FILE_SUPPORT turns this flag off.

Quoted 8 lines

So according to this, it should not be necessary to set this flag explicitly. However, after a quick look at the unix/configure script, I haven't seen any logic doing this. Can you confirm?

Thanks,

Thomas

Sorry, I made a mistake in commit cc4dedd9...

This week I updated from 2013.08 to 2014.11 and I had a runtime error with zip:
"zip warning : Not supported (uzoff_t not same size as zoff_t)"

I'm sending a series to fit this.

Best regards,
Romain Naour