pppd: add config option to install scripts shipped with pppd's source
PATCH 1/1 pppd: add config option to install scripts shipped with pppd's source
--- package/pppd/Config.in | 8 ++++++++ package/pppd/pppd.mk | 5 +++++ 2 files changed, 13 insertions(+)
package/pppd/Config.in +8 -0
@@ -22,6 +22,14 @@ config BR2_PACKAGE_PPPD_RADIUS help Install RADIUS support for pppd +config BR2_PACKAGE_PPPD_INSTALL_SCRIPTS + string "Install these PPP scripts" + default "" + help + Space delimited list to specify which scripts + need to be installed from pppd source tree's + scripts directory + endif comment "pppd needs a toolchain w/ dynamic library"
package/pppd/pppd.mk +5 -0
@@ -14,6 +14,7 @@ PPPD_LICENSE_FILES = \ PPPD_INSTALL_STAGING = YES PPPD_TARGET_BINS = chat pppd pppdump pppstats +PPPD_TARGET_SCRIPTS = $(call qstrip,$(BR2_PACKAGE_PPPD_INSTALL_SCRIPTS)) PPPD_RADIUS_CONF = \ dictionary dictionary.ascend dictionary.compat \ dictionary.merit dictionary.microsoft \
@@ -83,6 +84,10 @@ define PPPD_INSTALL_TARGET_CMDS $(INSTALL) -D $(PPPD_DIR)/$$sbin/$$sbin \ $(TARGET_DIR)/usr/sbin/$$sbin; \ done + for scriptfile in $(PPPD_TARGET_SCRIPTS); do \ + $(INSTALL) -D $(PPPD_DIR)/scripts/$$scriptfile \ + $(TARGET_DIR)/usr/sbin/; \ + done $(INSTALL) -D $(PPPD_DIR)/pppd/plugins/minconn.so \ $(TARGET_DIR)/usr/lib/pppd/$(PPPD_VERSION)/minconn.so $(INSTALL) -D $(PPPD_DIR)/pppd/plugins/passprompt.so \
Signature · 1 line
2.1.0
PATCH 1/1 pppd: add config option to install scripts shipped with pppd's source
Quoted 12 lines · Zoltan Gyarmati
Signed-off-by Zoltan Gyarmati <[email protected]>--- package/pppd/Config.in | 8 ++++++++ package/pppd/pppd.mk | 5 +++++ 2 files changed, 13 insertions(+)package/pppd/Config.in +0
-0@@ -22,6 +22,14 @@ config BR2_PACKAGE_PPPD_RADIUS help
package/pppd/Config.in config BR2_PACKAGE_PPPD_RADIUS · line 32
Quoted 10 lines
package/pppd/Config.in +8
-0Install RADIUS support for pppd +config BR2_PACKAGE_PPPD_INSTALL_SCRIPTS + string "Install these PPP scripts" + default "" + help + Space delimited list to specify which scripts + need to be installed from pppd source tree's + scripts directory +
Hi.
Isn't just simpler to copy those scripts that are useful/have no extra dependencies (like bash, expect, perl)?
Otherwise it's just like a post-build script.
Regards.
PATCH 1/1 pppd: add config option to install scripts shipped with pppd's source
Zoltan, All,
On 2015-01-15 15:10 -0300, Gustavo Zacarias spake thusly:
Quoted 16 lines · Zoltan Gyarmati
Quoted 15 lines
Signed-off-by Zoltan Gyarmati <[email protected]>--- package/pppd/Config.in | 8 ++++++++ package/pppd/pppd.mk | 5 +++++ 2 files changed, 13 insertions(+)package/pppd/Config.in +0
-0@@ -22,6 +22,14 @@ config BR2_PACKAGE_PPPD_RADIUS help Install RADIUS support for pppd
Quoted 14 lines
package/pppd/Config.in config BR2_PACKAGE_PPPD_RADIUS · line 32
Quoted 8 lines
package/pppd/Config.in +8
-0+config BR2_PACKAGE_PPPD_INSTALL_SCRIPTS + string "Install these PPP scripts" + default "" + help + Space delimited list to specify which scripts + need to be installed from pppd source tree's + scripts directory +Hi.
Isn't just simpler to copy those scripts that are useful/have no extra dependencies (like bash, expect, perl)?
Otherwise it's just like a post-build script.
Regards.
I concur with Gustavo: just install them, conditionally to the required package being enabled, like:
- needs nothing? Install it.
- needs bash? Install if bash is 'y'.
- And so on...
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 pppd: add config option to install scripts shipped with pppd's source
Dear Morin, Gustavo,
Quoted 34 lines · Yann E. MORIN
Zoltan, All,
On 2015-01-15 15:10 -0300, Gustavo Zacarias spake thusly:
Quoted 16 lines · Zoltan Gyarmati
Quoted 15 lines
Signed-off-by Zoltan Gyarmati <[email protected]>--- package/pppd/Config.in | 8 ++++++++ package/pppd/pppd.mk | 5 +++++ 2 files changed, 13 insertions(+)package/pppd/Config.in +0
-0@@ -22,6 +22,14 @@ config BR2_PACKAGE_PPPD_RADIUS help Install RADIUS support for pppdQuoted 14 lines
package/pppd/Config.in config BR2_PACKAGE_PPPD_RADIUS · line 32
Quoted 8 lines
package/pppd/Config.in +8
-0+config BR2_PACKAGE_PPPD_INSTALL_SCRIPTS + string "Install these PPP scripts" + default "" + help + Space delimited list to specify which scripts + need to be installed from pppd source tree's + scripts directory +Hi.
Isn't just simpler to copy those scripts that are useful/have no extra dependencies (like bash, expect, perl)?
Otherwise it's just like a post-build script.
Regards.
Quoted 6 lines
I concur with Gustavo: just install them, conditionally to the required package being enabled, like:
- needs nothing? Install it.
- needs bash? Install if bash is 'y'.
- And so on...
OK, looking beck now it sounds better than my first approach, will resend an updated patch, thanks for the review!
Quoted 4 lines
Regards,
Yann E. MORIN.
Signature · 11 lines
Bests, Zoltan Gyarmati IRC freenode: zgyarmati -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: OpenPGP digital signature URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150121/6e79d5b3/attachment.asc>