Skip to contentSkip to conversation

staging: fbtft: fix allyesconfig build

PATCH In review Dan Carpenter 2 participants 2 messages Jan 23, 2015

Subsystems (3)
Staging Kernel janitors Fbtft Framebuffer drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 staging: fbtft: fix allyesconfig build

There are two functions call reset() so the allyesconfig breaks. Let's make this one static.

Reported-by Jim Davis <[email protected]>
Signed-off-by Dan Carpenter <[email protected]>

---
Hi Jim, can you test this patch and see if it fixes the build issue?

drivers/staging/fbtft/fb_agm1264k-fl.c +1 -1
index 7fe4fa0..9cc7d25 100644
@@ -89,7 +89,7 @@ static int init_display(struct fbtft_par *par)
 	return 0;
 }
 
-void reset(struct fbtft_par *par)
+static void reset(struct fbtft_par *par)
 {
 	if (par->gpio.reset = -1)
 		return;
Tested-by on v1 1/1
#1 lore raw
Quoted 13 lines · Dan Carpenter

There are two functions call reset() so the allyesconfig breaks. Let's make this one static.

Reported-by Jim Davis <[email protected]>
Signed-off-by Dan Carpenter <[email protected]>

---
Hi Jim, can you test this patch and see if it fixes the build issue?

drivers/staging/fbtft/fb_agm1264k-fl.c +0 -0
index 7fe4fa0..9cc7d25 100644

drivers/staging/fbtft/fb_agm1264k-fl.c static int init_display(struct fbtft_par *par)

Quoted 9 lines
drivers/staging/fbtft/fb_agm1264k-fl.c +1 -2
@@ -89,7 +89,7 @@ static int init_display(struct fbtft_par *par)
        return 0;
 }
 
-void reset(struct fbtft_par *par)
+static void reset(struct fbtft_par *par)
 {
        if (par->gpio.reset = -1)
                return;
--

Looks good -- make allyesconfig with next-20150123 builds cleanly with that patch. Thanks!

Tested-by Jim Davis <[email protected]>