Skip to contentSkip to conversation

ARM: shmobile: Select CONFIG_REGULATOR in defconfig once again

PATCH New Simon Horman 3 participants 5 messages Jan 26, 2015

Subsystems (3)
Arm (32-bit) SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Simon Horman

author
#0 lore raw

PATCH 1/1 ARM: shmobile: Select CONFIG_REGULATOR in defconfig once again

From: Kuninori Morimoto <[email protected]>

eb4513482d1c4882e3633528ccc48d77581b7bb1
(ARM: shmobile: Enable kzm9g board in multiplatform defconfig) dropped CONFIG_REGULATOR from shmobile_defconfig as it was generated using a tree where CONFIG_REGULATOR is indirectly selected by ARCH_SH73A0.

ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig in that release. This causes at least SDHI to stop working on R-Car Gen2 SoCs.

Reported-by Magnus Damm <[email protected]>
Signed-off-by Kuninori Morimoto <[email protected]>
[horms: minimal patch targeted as a fix]
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/shmobile_defconfig +1 -0
index 4f9868d..b553e2c 100644
@@ -118,6 +118,7 @@ CONFIG_WATCHDOG=y
 CONFIG_DA9063_WATCHDOG=y
 CONFIG_MFD_AS3711=y
 CONFIG_MFD_DA9063=y
+CONFIG_REGULATOR=y
 CONFIG_REGULATOR_AS3711=y
 CONFIG_REGULATOR_DA9210=y
 CONFIG_REGULATOR_GPIO=y
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 ARM: shmobile: Select CONFIG_REGULATOR in defconfig once again

Hi Simon

Quoted 26 lines

From: Kuninori Morimoto <[email protected]>

eb4513482d1c4882e3633528ccc48d77581b7bb1
(ARM: shmobile: Enable kzm9g board in multiplatform defconfig) dropped CONFIG_REGULATOR from shmobile_defconfig as it was generated using a tree where CONFIG_REGULATOR is indirectly selected by ARCH_SH73A0.

ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig in that release. This causes at least SDHI to stop working on R-Car Gen2 SoCs.

Reported-by Magnus Damm <[email protected]>
Signed-off-by Kuninori Morimoto <[email protected]>
[horms: minimal patch targeted as a fix]
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/shmobile_defconfig +0 -0
index 4f9868d..b553e2c 100644

arch/arm/configs/shmobile_defconfig CONFIG_WATCHDOG=y · line 124

Quoted 7 lines
arch/arm/configs/shmobile_defconfig +1 -0
@@ -118,6 +118,7 @@ CONFIG_WATCHDOG=y
 CONFIG_DA9063_WATCHDOG=y
 CONFIG_MFD_AS3711=y
 CONFIG_MFD_DA9063=y
+CONFIG_REGULATOR=y
 CONFIG_REGULATOR_AS3711=y
 CONFIG_REGULATOR_DA9210=y
 CONFIG_REGULATOR_GPIO=y

Oh.. Thank you for your help
(I have sent other question mail)
It looks good :)

#2 lore raw

PATCH 1/1 ARM: shmobile: Select CONFIG_REGULATOR in defconfig once again

Quoted 23 lines · Kuninori Morimoto

Hi Simon

Quoted 20 lines

From: Kuninori Morimoto <[email protected]>

eb4513482d1c4882e3633528ccc48d77581b7bb1
(ARM: shmobile: Enable kzm9g board in multiplatform defconfig) dropped CONFIG_REGULATOR from shmobile_defconfig as it was generated using a tree where CONFIG_REGULATOR is indirectly selected by ARCH_SH73A0.

ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig in that release. This causes at least SDHI to stop working on R-Car Gen2 SoCs.

Reported-by Magnus Damm <[email protected]>
Signed-off-by Kuninori Morimoto <[email protected]>
[horms: minimal patch targeted as a fix]
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)

For the record, this patch is based on
renesas-next-20150122-v3.19-rc1.

Quoted 8 lines
Quoted 8 lines
arch/arm/configs/shmobile_defconfig +0 -0
index 4f9868d..b553e2c 100644
@@ -118,6 +118,7 @@ CONFIG_WATCHDOG=y
 CONFIG_DA9063_WATCHDOG=y
 CONFIG_MFD_AS3711=y
 CONFIG_MFD_DA9063=y
Quoted 8 lines

arch/arm/configs/shmobile_defconfig CONFIG_WATCHDOG=y · line 124

Quoted 4 lines
arch/arm/configs/shmobile_defconfig +1 -0
+CONFIG_REGULATOR=y
 CONFIG_REGULATOR_AS3711=y
 CONFIG_REGULATOR_DA9210=y
 CONFIG_REGULATOR_GPIO=y

Oh.. Thank you for your help
(I have sent other question mail)
It looks good :)

Thanks. I have tried to address your questions in an answer to your other email. Can you confirm me know if the above patch is ok for you or not. I'd like to get this one right :)

#3 lore raw

PATCH 1/1 ARM: shmobile: Select CONFIG_REGULATOR in defconfig once again

Hi Simon

Quoted 19 lines
Quoted 11 lines
Quoted 11 lines

eb4513482d1c4882e3633528ccc48d77581b7bb1
(ARM: shmobile: Enable kzm9g board in multiplatform defconfig) dropped CONFIG_REGULATOR from shmobile_defconfig as it was generated using a tree where CONFIG_REGULATOR is indirectly selected by ARCH_SH73A0.

ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig in that release. This causes at least SDHI to stop working on R-Car Gen2 SoCs.

Quoted 7 lines
Quoted 7 lines
Reported-by Magnus Damm <[email protected]>
Signed-off-by Kuninori Morimoto <[email protected]>
[horms: minimal patch targeted as a fix]
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 2 lines

For the record, this patch is based on
renesas-next-20150122-v3.19-rc1.

Thank you

Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
arch/arm/configs/shmobile_defconfig +0 -0
index 4f9868d..b553e2c 100644
@@ -118,6 +118,7 @@ CONFIG_WATCHDOG=y
 CONFIG_DA9063_WATCHDOG=y
 CONFIG_MFD_AS3711=y
 CONFIG_MFD_DA9063=y
Quoted 8 lines

arch/arm/configs/shmobile_defconfig CONFIG_WATCHDOG=y · line 124

Quoted 4 lines
arch/arm/configs/shmobile_defconfig +1 -0
+CONFIG_REGULATOR=y
 CONFIG_REGULATOR_AS3711=y
 CONFIG_REGULATOR_DA9210=y
 CONFIG_REGULATOR_GPIO=y

Oh.. Thank you for your help
(I have sent other question mail)
It looks good :)

Quoted 3 lines

Thanks. I have tried to address your questions in an answer to your other email. Can you confirm me know if the above patch is ok for you or not. I'd like to get this one right :)

It OK in my quick check
Thank you

Best regards
---
Kuninori Morimoto

#4 lore raw

PATCH 1/1 ARM: shmobile: Select CONFIG_REGULATOR in defconfig once again

Quoted 44 lines · Kuninori Morimoto

Hi Simon

Quoted 19 lines
Quoted 11 lines
Quoted 11 lines

eb4513482d1c4882e3633528ccc48d77581b7bb1
(ARM: shmobile: Enable kzm9g board in multiplatform defconfig) dropped CONFIG_REGULATOR from shmobile_defconfig as it was generated using a tree where CONFIG_REGULATOR is indirectly selected by ARCH_SH73A0.

ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig in that release. This causes at least SDHI to stop working on R-Car Gen2 SoCs.

Quoted 7 lines
Quoted 7 lines
Reported-by Magnus Damm <[email protected]>
Signed-off-by Kuninori Morimoto <[email protected]>
[horms: minimal patch targeted as a fix]
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 2 lines

For the record, this patch is based on
renesas-next-20150122-v3.19-rc1.

Thank you

Quoted 17 lines
Quoted 16 lines

arch/arm/configs/shmobile_defconfig CONFIG_WATCHDOG=y · line 124

Quoted 12 lines
arch/arm/configs/shmobile_defconfig +1 -0
index 4f9868d..b553e2c 100644
@@ -118,6 +118,7 @@ CONFIG_WATCHDOG=y
 CONFIG_DA9063_WATCHDOG=y
 CONFIG_MFD_AS3711=y
 CONFIG_MFD_DA9063=y
+CONFIG_REGULATOR=y
 CONFIG_REGULATOR_AS3711=y
 CONFIG_REGULATOR_DA9210=y
 CONFIG_REGULATOR_GPIO=y

Oh.. Thank you for your help
(I have sent other question mail)
It looks good :)

Quoted 6 lines
Quoted 3 lines

Thanks. I have tried to address your questions in an answer to your other email. Can you confirm me know if the above patch is ok for you or not. I'd like to get this one right :)

It OK in my quick check
Thank you

Thanks, I have queued this up as a fix for v3.20 and pushed it as part of renesas-next-20150126-v3.19-rc1.