Skip to contentSkip to conversation

ath10k:Prevent setting wrong key idx for station

PATCH New Senthil Balasubramanian 1 participant 1 message Jan 27, 2015 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k:Prevent setting wrong key idx for station

Ath10k driver sets wrong default key idx that results in sending unicast frames with multicast key.

The reason for this behavior is that cached broadcast key is installed for station MAC address on association. After dot1x completes, unicast key is installed for station MAC address. Default key idx is set to broadcast key id when driver tries to send broadcast frame. This causes firmware to use broadcast key id to transmit unicast frames to stations.

Used TX_USAGE flag to set default key for stations.

Added callback for setting unicast default idx which will be invoked on every default key idx configuration.

---
 drivers/net/wireless/ath/ath10k/core.h |   4 +-
 drivers/net/wireless/ath/ath10k/mac.c  | 161 +++++++++++++++------------------
 2 files changed, 72 insertions(+), 93 deletions(-)
drivers/net/wireless/ath/ath10k/core.h +1 -3
index c568612..f6b8d35 100644
@@ -271,10 +271,8 @@ struct ath10k_vif {
 	u32 aid;
 	u8 bssid[ETH_ALEN];
 
-	struct work_struct wep_key_work;
 	struct ieee80211_key_conf *wep_keys[WMI_MAX_KEY_INDEX + 1];
-	u8 def_wep_key_idx;
-	u8 def_wep_key_newidx;
+	s8 def_wep_key_idx;
 
 	u16 tx_seq_no;
 
drivers/net/wireless/ath/ath10k/mac.c +71 -90

284 lines not on this page · raw message

--
1.9.1