Skip to contentSkip to conversation

mem/hugeshmat: new case for hugepage leak inspection

PATCH In review Cyril Hrubis 3 participants 3 messages Jan 27, 2015 – Feb 10, 2015 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi!

Review

Quoted 10 lines
(quoted diff) +10 -0
+void setup(void)
+{
+	long mem_total, hpage_size;
+
+	tst_require_root(NULL);
+
+	mem_total = read_meminfo("MemTotal:");
+	if (mem_total < 2L*1024*1024) {
+		tst_resm(TINFO, "Test requires more than 2GB of RAM");
+		tst_exit();

This should be:

                tst_brmk(TCONF, "Test requires more than 2GB of RAM");

As I said in the last mail.

Otherwise it looks fine.

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

PATCH 1/1 hugeshmat04: fix typo

From ecec5dda24d573f48862e1d05e15d14bfef5a463 Mon Sep 17 00:00:00 2001
From: Zeng Linggang <[email protected]>
Date: Tue, 10 Feb 2015 11:20:32 +0800
Subject: [PATCH] hugeshmat04: fix typo

hugeshamt04 --> hugeshmat04
^^ ^^

---
 runtest/hugetlb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
runtest/hugetlb +1 -1
index 805141d..7fcaa01 100644
@@ -10,7 +10,7 @@ hugemmap05_3 hugemmap05 -s -m
 hugeshmat01 hugeshmat01 -i 5
 hugeshmat02 hugeshmat02 -i 5
 hugeshmat03 hugeshmat03 -i 5
-hugeshmat04 hugeshamt04 -i 5
+hugeshmat04 hugeshmat04 -i 5
 
 hugeshmctl01 hugeshmctl01 -i 5
 hugeshmctl02 hugeshmctl02 -i 5
Signature · 15 lines
1.9.3




------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#5 lore raw

Re: [LTP] [PATCH] hugeshmat04: fix typo

Oops, applied, thank you.

Quoted 19 lines · Zeng Linggang
Quoted 1 line

From ecec5dda24d573f48862e1d05e15d14bfef5a463 Mon Sep 17 00:00:00 2001

From: Zeng Linggang <[email protected]>
Date: Tue, 10 Feb 2015 11:20:32 +0800
Subject: [PATCH] hugeshmat04: fix typo

hugeshamt04 --> hugeshmat04
^^ ^^

---
 runtest/hugetlb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
runtest/hugetlb +0 -0
index 805141d..7fcaa01 100644

runtest/hugetlb hugemmap05_3 hugemmap05 -s -m · line 16

Quoted 8 lines
runtest/hugetlb +1 -1
@@ -10,7 +10,7 @@ hugemmap05_3 hugemmap05 -s -m
 hugeshmat01 hugeshmat01 -i 5
 hugeshmat02 hugeshmat02 -i 5
 hugeshmat03 hugeshmat03 -i 5
-hugeshmat04 hugeshamt04 -i 5
+hugeshmat04 hugeshmat04 -i 5
 
 hugeshmctl01 hugeshmctl01 -i 5
 hugeshmctl02 hugeshmctl02 -i 5

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list