spl: Change printf to puts for "Unsupported boot-device"
PATCH 1/1 spl: Change printf to puts for "Unsupported boot-device"
Microblaze currently doesn't use printf in SPL. So this one line was the only reference to it and resulted in the printf functionality to be pulled in. Exceeding the 4k size limit. Lets change the printf back to puts so that Microblaze is fixed again. The only drawback is that the detected boot-device number will not be printed. But this message alone should be helpful enough to get an idea where the boot process is broken.
--- common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl.c +1 -1
@@ -231,7 +231,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)#endif default :#if defined(CONFIG_SPL_SERIAL_SUPPORT ) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT ) -printf ("SPL: Unsupported Boot Device %d\n" , boot_device); +puts ("SPL: Unsupported Boot Device!\n" );#endif hang (); }
Signature · 1 line
2.2.2
PATCH 1/1 spl: Change printf to puts for "Unsupported boot-device"
Quoted 10 lines · Stefan Roese
Microblaze currently doesn't use printf in SPL. So this one line was the only reference to it and resulted in the printf functionality to be pulled in. Exceeding the 4k size limit. Lets change the printf back to puts so that Microblaze is fixed again. The only drawback is that the detected boot-device number will not be printed. But this message alone should be helpful enough to get an idea where the boot process is broken.
Signed-off-by Stefan Roese <[email protected]>Cc Tom Rini <[email protected]>Cc Michal Simek <[email protected]>
Since we have a debug() higher up that will print out what the value is, I'm OK with this and I'll apply shortly, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150127/d09b40aa/attachment.pgp>
PATCH 1/1 spl: Change printf to puts for "Unsupported boot-device"
Quoted 9 lines · Tom Rini
Quoted 7 lines · Stefan Roese
Microblaze currently doesn't use printf in SPL. So this one line was the only reference to it and resulted in the printf functionality to be pulled in. Exceeding the 4k size limit. Lets change the printf back to puts so that Microblaze is fixed again. The only drawback is that the detected boot-device number will not be printed. But this message alone should be helpful enough to get an idea where the boot process is broken.
Quoted 7 lines
Quoted 3 lines
Signed-off-by Stefan Roese <[email protected]>Cc Tom Rini <[email protected]>Cc Michal Simek <[email protected]>Since we have a
debug()higher up that will print out what the value is, I'm OK with this and I'll apply shortly, thanks!
Works for me.
Thanks,
Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150127/f8399cfc/attachment.pgp>
Quoted 11 lines · Stefan Roese
Microblaze currently doesn't use printf in SPL. So this one line was the only reference to it and resulted in the printf functionality to be pulled in. Exceeding the 4k size limit. Lets change the printf back to puts so that Microblaze is fixed again. The only drawback is that the detected boot-device number will not be printed. But this message alone should be helpful enough to get an idea where the boot process is broken.
Signed-off-by Stefan Roese <[email protected]>Cc Tom Rini <[email protected]>Cc Michal Simek <[email protected]>Acked-by Michal Simek <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150129/34cfbf35/attachment.sig>