Skip to contentSkip to conversation

ARM: cns3xxx: fix typo in PCI config accessor

PATCH New Arnd Bergmann 4 participants 5 messages Jan 28, 2015 – Jan 29, 2015

Subsystems (3)
Arm (32-bit) Arm sub-architectures PCI
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 ARM: cns3xxx: fix typo in PCI config accessor

The recent patch to convert the cns3xxx PCI code added an extraneous opening bracket, which makes the build fail, so remove this.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")

---

Hi Bjorn,

The broken patch just showed up in linux-next. Please apply this one on top, or fold it into the original patch if you don't mind rebasing.

arch/arm/mach-cns3xxx/pcie.c +1 -1
index e41fc339d100..c622c306c390 100644
@@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
 		 * for a PCIe bridge. So we must fixup the class code
 		 * to 0x604 here.
 		 */
-		*val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
+		*val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
 
 	return ret;
 }
maintainer
#1 lore raw

PATCH 1/1 ARM: cns3xxx: fix typo in PCI config accessor

Quoted 4 lines · Arnd Bergmann

The recent patch to convert the cns3xxx PCI code added an extraneous opening bracket, which makes the build fail, so remove this.

Quoted 8 lines
Signed-off-by Arnd Bergmann <[email protected]>
Fixes 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")

---

Hi Bjorn,

The broken patch just showed up in linux-next. Please apply this one on top, or fold it into the original patch if you don't mind rebasing.

I folded it in, thanks! I guess Fengguang's autobuilder must not build this config, because I got a success report from it.

Quoted 14 lines
arch/arm/mach-cns3xxx/pcie.c +1 -1
index e41fc339d100..c622c306c390 100644
@@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
 		 * for a PCIe bridge. So we must fixup the class code
 		 * to 0x604 here.
 		 */
-		*val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
+		*val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
 
 	return ret;
 }
#2 lore raw

PATCH 1/1 ARM: cns3xxx: fix typo in PCI config accessor

Quoted 9 lines · Bjorn Helgaas
Quoted 8 lines · Arnd Bergmann

The recent patch to convert the cns3xxx PCI code added an extraneous opening bracket, which makes the build fail, so remove this.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")

---

Quoted 7 lines
Quoted 4 lines

Hi Bjorn,

The broken patch just showed up in linux-next. Please apply this one on top, or fold it into the original patch if you don't mind rebasing.

I folded it in, thanks! I guess Fengguang's autobuilder must not build this config, because I got a success report from it.

Sorry about this. I had fixed this in my tree, but forgot to send out the update. I've double checked and this was the only fix I had.

How do you get success reports? I only ever get failures.

Rob

Quoted 15 lines
Quoted 15 lines
arch/arm/mach-cns3xxx/pcie.c +1 -1
index e41fc339d100..c622c306c390 100644
@@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
               * for a PCIe bridge. So we must fixup the class code
               * to 0x604 here.
               */
-             *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
+             *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
 
      return ret;
 }
maintainer
#3 lore raw

PATCH 1/1 ARM: cns3xxx: fix typo in PCI config accessor

[+cc Fengguang]

Quoted 15 lines · Rob Herring
Quoted 14 lines · Bjorn Helgaas
Quoted 12 lines · Arnd Bergmann

The recent patch to convert the cns3xxx PCI code added an extraneous opening bracket, which makes the build fail, so remove this.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")

---

Hi Bjorn,

The broken patch just showed up in linux-next. Please apply this one on top, or fold it into the original patch if you don't mind rebasing.

Quoted 7 lines
Quoted 2 lines

I folded it in, thanks! I guess Fengguang's autobuilder must not build this config, because I got a success report from it.

Sorry about this. I had fixed this in my tree, but forgot to send out the update. I've double checked and this was the only fix I had.

How do you get success reports? I only ever get failures.

I think Fengguang has it set up so success reports only go to the owner of the tree, while failure reports go to the owner + people related to the patch, e.g., maybe people in the signed-off-by list? I don't know whether that's configurable, or whether you'd even want to see all the success reports from my tree :)

Bjorn

Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
arch/arm/mach-cns3xxx/pcie.c +1 -1
index e41fc339d100..c622c306c390 100644
@@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
               * for a PCIe bridge. So we must fixup the class code
               * to 0x604 here.
               */
-             *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
+             *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
 
      return ret;
 }
#4 lore raw

PATCH 1/1 ARM: cns3xxx: fix typo in PCI config accessor

In reply to Arnd Bergmann
Quoted 6 lines · Arnd Bergmann

The recent patch to convert the cns3xxx PCI code added an extraneous opening bracket, which makes the build fail, so remove this.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
Acked-by Krzysztof Ha?asa <[email protected]>
Signature · 4 lines
Krzysztof Halasa

Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland