regulator: qcom-rpm: signedness bug in probe()

PATCH Applied Dan Carpenter 2 participants 2 messages Jan 28, 2015

Subsystems (3)

Arm Qualcomm mailing list Kernel janitors Voltage and current regulator framework

lore

Share & tools

lore

Dan Carpenter

author

2015-01-28 19:15 UTC #0 lore raw

PATCH 1/1 regulator: qcom-rpm: signedness bug in probe()

"force_mode" is a u32 so it is never "< 0", but because of type promotion then comparing "= -1" will do what we want.

Signed-off-by Dan Carpenter <[email protected]>

drivers/regulator/qcom_rpm-regulator.c +1 -1

index edd0a17..ec540aa 100644
@@ -769,7 +769,7 @@ static int rpm_reg_probe(struct platform_device *pdev)
 			break;
 		}
 
-		if (force_mode < 0) {
+		if (force_mode = -1) {
 			dev_err(&pdev->dev, "invalid force mode\n");
 			return -EINVAL;
 		}

Mark Brown

maintainer Applied

2015-01-28 19:43 UTC #1 lore raw

Quoted 2 lines · Dan Carpenter

"force_mode" is a u32 so it is never "< 0", but because of type promotion then comparing "== -1" will do what we want.

Applied, thanks.