staging: fbtft: fix coding style errors

PATCH In review Mariam Mohamed Fawzy 2 participants 5 messages Jan 26, 2015 – Jan 28, 2015

Subsystems (2)

Staging Fbtft Framebuffer drivers

lore

Share & tools

lore

Mariam Mohamed Fawzy

author

2015-01-26 10:18 UTC #0 lore raw

cover staging: fbtft: fix coding style errors

This patchset fixes three coding style errors in the file fb_bd663474.c located in the driver fbtft

Mariam Mohamed Fawzy (3):
fix space prohibited before that close parenthesis ')' fix space prohibited after that open parenthesis '(' fix space required after that ','

 drivers/staging/fbtft/fb_bd663474.c | 100 ++++++++++++++++++------------------
 1 file changed, 50 insertions(+), 50 deletions(-)

Signature · 1 line

1.9.1

Mariam Mohamed Fawzy

author

2015-01-26 10:21 UTC #1 lore raw

PATCH 1/3 fix space prohibited before that close parenthesis ')'

This patch fixes the following checkpatch.pl error:
space prohibited before that close parenthesis ')'

Signed-off-by Mariam Mohamed Fawzy <[email protected]>

---
 drivers/staging/fbtft/fb_bd663474.c | 98 ++++++++++++++++++-------------------
 1 file changed, 49 insertions(+), 49 deletions(-)

drivers/staging/fbtft/fb_bd663474.c +49 ~~-49~~

index 7e00c60..1e5ee2b 100644
@@ -51,45 +51,45 @@ static int init_display(struct fbtft_par *par)
 	mdelay(10);
 
 	/* Power settings */
-	write_reg(par, 0x100, 0x0000 ); /* power supply setup */
-	write_reg(par, 0x101, 0x0000 );
-	write_reg(par, 0x102, 0x3110 );
-	write_reg(par, 0x103, 0xe200 );
-	write_reg(par, 0x110, 0x009d );
-	write_reg(par, 0x111, 0x0022 );
-	write_reg(par, 0x100, 0x0120 );
-	mdelay( 20 );
-
-	write_reg(par, 0x100, 0x3120 );
-	mdelay( 80 );
+	write_reg(par, 0x100, 0x0000); /* power supply setup */
+	write_reg(par, 0x101, 0x0000);
+	write_reg(par, 0x102, 0x3110);
+	write_reg(par, 0x103, 0xe200);
+	write_reg(par, 0x110, 0x009d);
+	write_reg(par, 0x111, 0x0022);
+	write_reg(par, 0x100, 0x0120);
+	mdelay( 20);
+
+	write_reg(par, 0x100, 0x3120);
+	mdelay( 80);
 	/* Display control */
-	write_reg(par, 0x001, 0x0100 );
-	write_reg(par, 0x002, 0x0000 );
-	write_reg(par, 0x003, 0x1230 );
-	write_reg(par, 0x006, 0x0000 );
-	write_reg(par, 0x007, 0x0101 );
-	write_reg(par, 0x008, 0x0808 );
-	write_reg(par, 0x009, 0x0000 );
-	write_reg(par, 0x00b, 0x0000 );
-	write_reg(par, 0x00c, 0x0000 );
-	write_reg(par, 0x00d, 0x0018 );
+	write_reg(par, 0x001, 0x0100);
+	write_reg(par, 0x002, 0x0000);
+	write_reg(par, 0x003, 0x1230);
+	write_reg(par, 0x006, 0x0000);
+	write_reg(par, 0x007, 0x0101);
+	write_reg(par, 0x008, 0x0808);
+	write_reg(par, 0x009, 0x0000);
+	write_reg(par, 0x00b, 0x0000);
+	write_reg(par, 0x00c, 0x0000);
+	write_reg(par, 0x00d, 0x0018);
 	/* LTPS control settings */
-	write_reg(par, 0x012, 0x0000 );
-	write_reg(par, 0x013, 0x0000 );
-	write_reg(par, 0x018, 0x0000 );
-	write_reg(par, 0x019, 0x0000 );
-
-	write_reg(par, 0x203, 0x0000 );
-	write_reg(par, 0x204, 0x0000 );
-
-	write_reg(par, 0x210, 0x0000 );
-	write_reg(par, 0x211, 0x00ef );
-	write_reg(par, 0x212, 0x0000 );
-	write_reg(par, 0x213, 0x013f );
-	write_reg(par, 0x214, 0x0000 );
-	write_reg(par, 0x215, 0x0000 );
-	write_reg(par, 0x216, 0x0000 );
-	write_reg(par, 0x217, 0x0000 );
+	write_reg(par, 0x012, 0x0000);
+	write_reg(par, 0x013, 0x0000);
+	write_reg(par, 0x018, 0x0000);
+	write_reg(par, 0x019, 0x0000);
+
+	write_reg(par, 0x203, 0x0000);
+	write_reg(par, 0x204, 0x0000);
+
+	write_reg(par, 0x210, 0x0000);
+	write_reg(par, 0x211, 0x00ef);
+	write_reg(par, 0x212, 0x0000);
+	write_reg(par, 0x213, 0x013f);
+	write_reg(par, 0x214, 0x0000);
+	write_reg(par, 0x215, 0x0000);
+	write_reg(par, 0x216, 0x0000);
+	write_reg(par, 0x217, 0x0000);
 
 	/* Gray scale settings */
 	write_reg(par, 0x300, 0x5343);

@@ -104,18 +104,18 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x309, 0x050a);
 
 	/* RAM access settings */
-	write_reg(par, 0x400, 0x4027 );
-	write_reg(par, 0x401, 0x0000 );
-	write_reg(par, 0x402, 0x0000 );  /* First screen drive position (1) */
-	write_reg(par, 0x403, 0x013f );  /* First screen drive position (2) */
-	write_reg(par, 0x404, 0x0000 );
-
-	write_reg(par, 0x200, 0x0000 );
-	write_reg(par, 0x201, 0x0000 );
-	write_reg(par, 0x100, 0x7120 );
-	write_reg(par, 0x007, 0x0103 );
-	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x400, 0x4027);
+	write_reg(par, 0x401, 0x0000);
+	write_reg(par, 0x402, 0x0000);  /* First screen drive position (1) */
+	write_reg(par, 0x403, 0x013f);  /* First screen drive position (2) */
+	write_reg(par, 0x404, 0x0000);
+
+	write_reg(par, 0x200, 0x0000);
+	write_reg(par, 0x201, 0x0000);
+	write_reg(par, 0x100, 0x7120);
+	write_reg(par, 0x007, 0x0103);
+	mdelay( 10);
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }

Signature · 1 line

1.9.1

Mariam Mohamed Fawzy

author

2015-01-26 10:23 UTC #2 lore raw

PATCH 2/3 fix space prohibited after that open parenthesis '('

In reply to Mariam Mohamed Fawzy

This patch fixes the following checkpatch.pl error:
space prohibited after that open parenthesis '('

Signed-off-by Mariam Mohamed Fawzy <[email protected]>

---
 drivers/staging/fbtft/fb_bd663474.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/staging/fbtft/fb_bd663474.c +3 -3

index 1e5ee2b..1df19d7 100644
@@ -58,10 +58,10 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x110, 0x009d);
 	write_reg(par, 0x111, 0x0022);
 	write_reg(par, 0x100, 0x0120);
-	mdelay( 20);
+	mdelay(20);
 
 	write_reg(par, 0x100, 0x3120);
-	mdelay( 80);
+	mdelay(80);
 	/* Display control */
 	write_reg(par, 0x001, 0x0100);
 	write_reg(par, 0x002, 0x0000);

@@ -114,7 +114,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x201, 0x0000);
 	write_reg(par, 0x100, 0x7120);
 	write_reg(par, 0x007, 0x0103);
-	mdelay( 10);
+	mdelay(10);
 	write_reg(par, 0x007, 0x0113);
 
 	return 0;

Signature · 1 line

1.9.1

Mariam Mohamed Fawzy

author

2015-01-26 10:24 UTC #3 lore raw

PATCH 3/3 fix space required after that ','

In reply to Mariam Mohamed Fawzy

This patch fixes the following in checkpatch.pl error:
space required after that ','

Signed-off-by Mariam Mohamed Fawzy <[email protected]>

---
 drivers/staging/fbtft/fb_bd663474.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/fbtft/fb_bd663474.c +1 -1

index 1df19d7..17a2162 100644
@@ -47,7 +47,7 @@ static int init_display(struct fbtft_par *par)
 	/* Initialization sequence from Lib_UTFT */
 
 	/* oscillator start */
-	write_reg(par, 0x000,0x0001);	/*oscillator 0: stop, 1: operation */
+	write_reg(par, 0x000, 0x0001);	/*oscillator 0: stop, 1: operation */
 	mdelay(10);
 
 	/* Power settings */

Signature · 1 line

1.9.1

Greg KH

maintainer

2015-01-28 20:42 UTC #4 lore raw

Re: [PATCH 3/3] fix space required after that ','

Quoted 7 lines · Mariam Mohamed Fawzy

This patch fixes the following in checkpatch.pl error:
space required after that ','
Signed-off-by Mariam Mohamed Fawzy <[email protected]>
---
 drivers/staging/fbtft/fb_bd663474.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Please put in the subject what portion of the kernel you are changing, like you did in the 0/3 email.

Can you redo these and resend?

thanks,

greg k-h