csiostor:T5 Firmware fix and cleanup.

DISCUSSION Dan Carpenter 1 participant 1 message Jan 29, 2015 Kernel janitors

Share & tools

Dan Carpenter

author

2015-01-29 17:14 UTC #0 lore raw

Hello Praveen Madhavan,

The patch 216ce69c7ff5: "csiostor:T5 Firmware fix and cleanup." from Jan 27, 2015, leads to the following static checker warning:

	drivers/scsi/csiostor/csio_hw.c:1780 csio_hw_use_fwconfig()
	warn: missing error code here? 'csio_hw_validate_caps()' failed.

drivers/scsi/csiostor/csio_hw.c
1776 }
1777
1778 /* Validate device capabilities */
1779 if (csio_hw_validate_caps(hw, mbp))

We should probably preserve the error code here instead of returning success.

1780 goto bye;
1781 /*

regards,
dan carpenter