Skip to contentSkip to conversation

Clock Regression in next-20150130 caused by cb75a8fcd14e

DISCUSSION Tony Lindgren 3 participants 4 messages Jan 31, 2015 – Feb 2, 2015

lore
Share & tools
lore
#0 lore raw

Hi all,

Looks like commit cb75a8fcd14e ("clk: Add rate constraints to clocks") causes a regression on at least omaps where the serial console either does not show anything, or just prints garbage.

Reverting cb75a8fcd14e makes things work again on next-20150130.

Any ideas?

Regards,

Tony

#1 lore raw
Quoted 10 lines · Tony Lindgren

Hi all,

Looks like commit cb75a8fcd14e ("clk: Add rate constraints to clocks") causes a regression on at least omaps where the serial console either does not show anything, or just prints garbage.

Reverting cb75a8fcd14e makes things work again on next-20150130.

Any ideas?

The patch seems to have some problems.
Also see http://www.spinics.net/lists/kernel/msg1916843.html.

Guenter

#2 lore raw
In reply to Tony Lindgren

Quoting Tony Lindgren (2015-01-30 17:04:44)

Quoted 9 lines

Hi all,

Looks like commit cb75a8fcd14e ("clk: Add rate constraints to clocks") causes a regression on at least omaps where the serial console either does not show anything, or just prints garbage.

Reverting cb75a8fcd14e makes things work again on next-20150130.

Any ideas?

Stephen posted a patch[0] to fix this. I've squashed that into Tomeu's commit that you reference above and my Panda board is booting fine once again.

[0] http://lkml.kernel.org/r/<[email protected]>

Please let me know if any other issues pop up. There are new WARNs for OMAP3+ boards introduced by a different patch from Tomeu, but this is really because the OMAP DPLL and FAPLL code are dereferencing struct clk pointers when they should not be and is a separate issue from the constraints patch (with a separate email thread).

Regards,
Mike

Quoted 4 lines

Regards,

Tony

#3 lore raw
Quoted 15 lines · Mike Turquette

Quoting Tony Lindgren (2015-01-30 17:04:44)

Quoted 9 lines

Hi all,

Looks like commit cb75a8fcd14e ("clk: Add rate constraints to clocks") causes a regression on at least omaps where the serial console either does not show anything, or just prints garbage.

Reverting cb75a8fcd14e makes things work again on next-20150130.

Any ideas?

Stephen posted a patch[0] to fix this. I've squashed that into Tomeu's commit that you reference above and my Panda board is booting fine once again.

Quoted 7 lines

[0] http://lkml.kernel.org/r/<[email protected]>

Please let me know if any other issues pop up. There are new WARNs for OMAP3+ boards introduced by a different patch from Tomeu, but this is really because the OMAP DPLL and FAPLL code are dereferencing struct clk pointers when they should not be and is a separate issue from the constraints patch (with a separate email thread).

Seems Linux next is broken again. Now we omaps get tons of:

clock: dpll_abe_ck failed transition to 'locked'

WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:925 clk_disable+0x28/0x34()

and

WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/dpll3xxx.c:436
omap3_noncore_dpll_enable+0xdc/0x10c()

Regards,

Tony