Skip to contentSkip to conversation

Input: cap11xx - Remove wrong and unneeded cap11xx modalias

PATCH Applied Axel Lin 4 participants 4 messages Jan 31, 2015 – Feb 1, 2015

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 Input: cap11xx - Remove wrong and unneeded cap11xx modalias

This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so remove the wrong and unneeded cap11xx modalias.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/input/keyboard/cap11xx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/keyboard/cap11xx.c +0 -1
index 4f59f0b..f07461a 100644
@@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = {
 
 module_i2c_driver(cap11xx_i2c_driver);
 
-MODULE_ALIAS("platform:cap11xx");
 MODULE_DESCRIPTION("Microchip CAP11XX driver");
 MODULE_AUTHOR("Daniel Mack <[email protected]>");
 MODULE_LICENSE("GPL v2");
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Axel Lin

This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so remove the wrong and unneeded cap11xx modalias.

Signed-off-by Axel Lin <[email protected]>
Acked-by Daniel Mack <[email protected]>

Thanks!
Daniel

Quoted 17 lines
---
 drivers/input/keyboard/cap11xx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/keyboard/cap11xx.c +0 -1
index 4f59f0b..f07461a 100644
@@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = {
 
 module_i2c_driver(cap11xx_i2c_driver);
 
-MODULE_ALIAS("platform:cap11xx");
 MODULE_DESCRIPTION("Microchip CAP11XX driver");
 MODULE_AUTHOR("Daniel Mack <[email protected]>");
 MODULE_LICENSE("GPL v2");
Reviewed-by on v1 1/1
#2 lore raw
In reply to Axel Lin
Reviewed-by Matt Ranostay <[email protected]>

Thanks,

Matt Ranostay

Quoted 26 lines · Axel Lin

This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so remove the wrong and unneeded cap11xx modalias.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/input/keyboard/cap11xx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/keyboard/cap11xx.c +0 -2
index 4f59f0b..f07461a 100644
@@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = {
 
 module_i2c_driver(cap11xx_i2c_driver);
 
-MODULE_ALIAS("platform:cap11xx");
 MODULE_DESCRIPTION("Microchip CAP11XX driver");
 MODULE_AUTHOR("Daniel Mack <[email protected]>");
 MODULE_LICENSE("GPL v2");
--

1.9.1

maintainer Applied
#3 lore raw
In reply to Axel Lin
Quoted 5 lines · Axel Lin

This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so remove the wrong and unneeded cap11xx modalias.

Signed-off-by Axel Lin <[email protected]>

Applied, thank you.

Quoted 21 lines
---
 drivers/input/keyboard/cap11xx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/keyboard/cap11xx.c +0 -1
index 4f59f0b..f07461a 100644
@@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = {
 
 module_i2c_driver(cap11xx_i2c_driver);
 
-MODULE_ALIAS("platform:cap11xx");
 MODULE_DESCRIPTION("Microchip CAP11XX driver");
 MODULE_AUTHOR("Daniel Mack <[email protected]>");
 MODULE_LICENSE("GPL v2");
Signature · 1 line
1.9.1
Signature · 1 line
Dmitry