Skip to contentSkip to conversation

isdn: off by one in connect_res()

PATCH New Dan Carpenter 1 participant 1 message Feb 1, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 isdn: off by one in connect_res()

The bug here is that we use "Reject" as the index into the cau_t[] array in the else path. Since the cau_t[] has 9 elements if Reject = 9 then we are reading beyond the end of the array.

My understanding of the code is that it's saying that if Reject is 1 or too high then that's invalid and we should hang up.

---
Please review this one a bit carefully. I think it's correct, but I'm not terribly familiar with this code.

drivers/isdn/hardware/eicon/message.c +1 -1
index 0b38060..d7c2866 100644
@@ -1474,7 +1474,7 @@ static byte connect_res(dword Id, word Number, DIVA_CAPI_ADAPTER *a,
 					add_ai(plci, &parms[5]);
 					sig_req(plci, REJECT, 0);
 				}
-				else if (Reject = 1 || Reject > 9)
+				else if (Reject = 1 || Reject >= 9)
 				{
 					add_ai(plci, &parms[5]);
 					sig_req(plci, HANGUP, 0);