pps-tools: also pass TARGET_CONFIGURE_OPTS to make install
PATCH 1/1 pps-tools: also pass TARGET_CONFIGURE_OPTS to make install
Without these environment variables, pps-tools rebuilds for the host machine architecture and does not run on the target machine.
Signed-off-by Ryan Coe <[email protected]>
--- package/pps-tools/pps-tools.mk | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
package/pps-tools/pps-tools.mk +4 -2
@@ -16,12 +16,14 @@ endef define PPS_TOOLS_INSTALL_STAGING_CMDS mkdir -p $(STAGING_DIR)/usr/include/sys $(STAGING_DIR)/usr/bin - $(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(STAGING_DIR) -C $(@D) install + $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \ + DESTDIR=$(STAGING_DIR) -C $(@D) install endef define PPS_TOOLS_INSTALL_TARGET_CMDS mkdir -p $(TARGET_DIR)/usr/include/sys $(TARGET_DIR)/usr/bin - $(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install + $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \ + DESTDIR=$(TARGET_DIR) -C $(@D) install endef $(eval $(generic-package))
Signature · 1 line
2.2.2
Thomas Petazzoni
AppliedPATCH 1/1 pps-tools: also pass TARGET_CONFIGURE_OPTS to make install
Dear Ryan Coe,
Quoted 7 lines · Ryan Coe
Without these environment variables, pps-tools rebuilds for the host machine architecture and does not run on the target machine.
Signed-off-by Ryan Coe <[email protected]>--- package/pps-tools/pps-tools.mk | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Applied, thanks.
We just discussed here at the Buildroot meeting that we should probably add a post-build check that verifies that all binaries that have been installed to the root filesystem are actually built for the correct architecture.
Thanks for the report and patch!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com