Skip to contentSkip to conversation

nfsd: default NFSv4.2 to on

PATCH In review J. Bruce Fields 4 participants 9 messages Feb 2, 2015 – Feb 11, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd: default NFSv4.2 to on

From: "J. Bruce Fields" <[email protected]>

The code seems to work. The protocol looks stable. The kernel's version defaults can be overridden by rpc.nfsd arguments.

---
 fs/nfsd/nfssvc.c | 1 +
 1 file changed, 1 insertion(+)
fs/nfsd/nfssvc.c +1 -0
index 314f5c8f8f1a..9277cc91c21b 100644
@@ -119,6 +119,7 @@ struct svc_program		nfsd_program = {
 static bool nfsd_supported_minorversions[NFSD_SUPPORTED_MINOR_VERSION + 1] = {
 	[0] = 1,
 	[1] = 1,
+	[2] = 1,
 };
 
 int nfsd_vers(int vers, enum vers_op change)
Signature · 1 line
1.9.3
#1 lore raw
Quoted 4 lines · J. Bruce Fields

From: "J. Bruce Fields" <[email protected]>

The code seems to work. The protocol looks stable. The kernel's version defaults can be overridden by rpc.nfsd arguments.

Does it really make sense to enabled this without READ_PLUS support or implementing the various new attributes?

Also should we add a wiki page with the 4.2 status?

#2 lore raw
Quoted 8 lines · Christoph Hellwig
Quoted 4 lines · J. Bruce Fields

From: "J. Bruce Fields" <[email protected]>

The code seems to work. The protocol looks stable. The kernel's version defaults can be overridden by rpc.nfsd arguments.

Does it really make sense to enabled this without READ_PLUS support or implementing the various new attributes?

I think so. That's all optional--e.g. for READ_PLUS clients can determine server support using ERR_OP_NOTSUPP (or whatever it's called), and for attributes they can query the supported_attributes attribute. It's possible we'll never support everything in 4.2.

Quoted 1 line

Also should we add a wiki page with the 4.2 status?

Sounds like a good idea.

--b.

#3 lore raw
Quoted 4 lines · J. Bruce Fields

I think so. That's all optional--e.g. for READ_PLUS clients can determine server support using ERR_OP_NOTSUPP (or whatever it's called), and for attributes they can query the supported_attributes attribute. It's possible we'll never support everything in 4.2.

The questions is if we need a useful subset of 4.2 to bother. I doubt we'll ever bother with ADBs for example, and the copy offload might take a while to get everyting sorted. But exposting most attributes and supporting READ_PLUS sounds like important enought to implement before considering 4.2 ready.

#4 lore raw
Quoted 7 lines · Christoph Hellwig
Quoted 4 lines · J. Bruce Fields

I think so. That's all optional--e.g. for READ_PLUS clients can determine server support using ERR_OP_NOTSUPP (or whatever it's called), and for attributes they can query the supported_attributes attribute. It's possible we'll never support everything in 4.2.

The questions is if we need a useful subset of 4.2 to bother.

Internally the virtualization people have been interested in ALLOCATE, SEEK, and security labels, so I'm assuming we've passed that sort of minimum "is there any benefit at all to turning this on" threshhold.

Quoted 4 lines

I doubt we'll ever bother with ADBs for example, and the copy offload might take a while to get everyting sorted. But exposting most attributes and supporting READ_PLUS sounds like important enought to implement before considering 4.2 ready.

I agree there's a documentation and marketing problem: it would simplify communication with users if "this server supports 4.2" reliably meant support for some minimum list of features. Is that what you're thinking about?

Individual distros and other server vendors may make their own decisions here, so I don't know if we do much about that on our own.

We could also add a little more data e.g. to /proc/self/mountstats to help figure out stuff like "why does copying a big file go so much faster on server X than server Y?".

--b.

#5 lore raw
Quoted 7 lines · J. Bruce Fields
Quoted 6 lines · Christoph Hellwig
Quoted 4 lines · J. Bruce Fields

I think so. That's all optional--e.g. for READ_PLUS clients can determine server support using ERR_OP_NOTSUPP (or whatever it's called), and for attributes they can query the supported_attributes attribute. It's possible we'll never support everything in 4.2.

Quoted 5 lines
Quoted 1 line

The questions is if we need a useful subset of 4.2 to bother.

Internally the virtualization people have been interested in ALLOCATE, SEEK, and security labels, so I'm assuming we've passed that sort of minimum "is there any benefit at all to turning this on" threshhold.

ACK. There is client support for that functionality that hooks into well established system calls, which means that applications can use it now without much in the way of changes (if at all).

Quoted 9 lines
Quoted 4 lines

I doubt we'll ever bother with ADBs for example, and the copy offload might take a while to get everyting sorted. But exposting most attributes and supporting READ_PLUS sounds like important enought to implement before considering 4.2 ready.

I agree there's a documentation and marketing problem: it would simplify communication with users if "this server supports 4.2" reliably meant support for some minimum list of features. Is that what you're thinking about?

None of our NFSv4 versions are 100% feature complete. Our approach on both the client and server has been to take the functionality that is useful to us and implement that first.
For instance, NFSv4.1 is still missing RPCSEC_GSS on the callback channel. I do want to implement that feature some day, but that doesn't stop me from considering NFSv4.1 to be useful in the state it is today.

Quoted 6 lines

Individual distros and other server vendors may make their own decisions here, so I don't know if we do much about that on our own.

We could also add a little more data e.g. to /proc/self/mountstats to help figure out stuff like "why does copying a big file go so much faster on server X than server Y?".

We already have that information. As we add new RPC calls on the client, we add corresponding entries in /proc/self/mountstats. When copy offload goes in, it will have its own entry there, and you will see the usage counts being bumped whenever an application calls it.

Signature · 3 lines
Trond Myklebust
Linux NFS client maintainer, PrimaryData
[email protected]
#6 lore raw
Quoted 39 lines · Trond Myklebust
Quoted 7 lines · J. Bruce Fields
Quoted 6 lines · Christoph Hellwig
Quoted 4 lines · J. Bruce Fields

I think so. That's all optional--e.g. for READ_PLUS clients can determine server support using ERR_OP_NOTSUPP (or whatever it's called), and for attributes they can query the supported_attributes attribute. It's possible we'll never support everything in 4.2.

Quoted 5 lines
Quoted 1 line

The questions is if we need a useful subset of 4.2 to bother.

Internally the virtualization people have been interested in ALLOCATE, SEEK, and security labels, so I'm assuming we've passed that sort of minimum "is there any benefit at all to turning this on" threshhold.

ACK. There is client support for that functionality that hooks into well established system calls, which means that applications can use it now without much in the way of changes (if at all).

Quoted 9 lines
Quoted 4 lines

I doubt we'll ever bother with ADBs for example, and the copy offload might take a while to get everyting sorted. But exposting most attributes and supporting READ_PLUS sounds like important enought to implement before considering 4.2 ready.

I agree there's a documentation and marketing problem: it would simplify communication with users if "this server supports 4.2" reliably meant support for some minimum list of features. Is that what you're thinking about?

None of our NFSv4 versions are 100% feature complete. Our approach on both the client and server has been to take the functionality that is useful to us and implement that first.
For instance, NFSv4.1 is still missing RPCSEC_GSS on the callback channel. I do want to implement that feature some day, but that doesn't stop me from considering NFSv4.1 to be useful in the state it is today.

Quoted 3 lines

Individual distros and other server vendors may make their own decisions here, so I don't know if we do much about that on our own.

Quoted 8 lines
Quoted 3 lines

We could also add a little more data e.g. to /proc/self/mountstats to help figure out stuff like "why does copying a big file go so much faster on server X than server Y?".

We already have that information. As we add new RPC calls on the client, we add corresponding entries in /proc/self/mountstats. When copy offload goes in, it will have its own entry there, and you will see the usage counts being bumped whenever an application calls it.

Oh, and looking now--I'd forgotten that we also support the supported-attributes bitmaps.

Maybe that covers everything.

Someone could also add a server-side interface for querying features like this if it seemed useful.

--b.

#7 lore raw
In reply to J. Bruce Fields
Quoted 5 lines · J. Bruce Fields

I agree there's a documentation and marketing problem: it would simplify communication with users if "this server supports 4.2" reliably meant support for some minimum list of features.

The "marketing" message over NFSv4.2 has been pretty consistent - everything is optional and a fully compliant server can return not supported for every new feature. I.e., a NFSv4.2 server is pretty simple if you have an existing NFSv4.1 server.

#8 lore raw
Quoted 11 lines · Tom Haynes
Quoted 5 lines · J. Bruce Fields

I agree there's a documentation and marketing problem: it would simplify communication with users if "this server supports 4.2" reliably meant support for some minimum list of features.

The "marketing" message over NFSv4.2 has been pretty consistent - everything is optional and a fully compliant server can return not supported for every new feature. I.e., a NFSv4.2 server is pretty simple if you have an existing NFSv4.1 server.

Yes, and I like that, but it's not without tradeoffs.

--b.