Skip to contentSkip to conversation

libxfs: report VERSION in libxfs_fs_repair_cmn_err()

PATCH In review Eric Sandeen 2 participants 2 messages Jan 30, 2015 – Feb 2, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxfs: report VERSION in libxfs_fs_repair_cmn_err()

Because this is usually the first question asked...

---

libxfs/util.c +1 -0
index 9504e33..6464a1b 100644
@@ -718,6 +718,7 @@ libxfs_fs_repair_cmn_err(int level, xfs_mount_t *mp, char *fmt, ...)
 	va_start(ap, fmt);
 	vfprintf(stderr, fmt, ap);
 	fprintf(stderr, "  This is a bug.\n");
+	fprintf(stderr, "%s version %s\n", progname, VERSION);
 	fprintf(stderr, "Please capture the filesystem metadata with "
 			"xfs_metadump and\nreport it to [email protected].\n");
 	va_end(ap);

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Eric Sandeen

Because this is usually the first question asked...

---

Good idea.

Quoted 14 lines
libxfs/util.c +1 -0
index 9504e33..6464a1b 100644
@@ -718,6 +718,7 @@ libxfs_fs_repair_cmn_err(int level, xfs_mount_t *mp, char *fmt, ...)
 	va_start(ap, fmt);
 	vfprintf(stderr, fmt, ap);
 	fprintf(stderr, "  This is a bug.\n");
+	fprintf(stderr, "%s version %s\n", progname, VERSION);
 	fprintf(stderr, "Please capture the filesystem metadata with "
 			"xfs_metadump and\nreport it to [email protected].\n");
 	va_end(ap);
Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs