Skip to contentSkip to conversation

common: bootm: Document fake bootm sub-command

PATCH In review Michal Simek 4 participants 6 messages Jan 15, 2015 – Feb 2, 2015

lore
Share & tools
lore

Michal Simek

author
#0 lore raw

PATCH 1/1 common: bootm: Document fake bootm sub-command

Fake option is enabled only when CONFIG_TRACE is
enabled in common/bootm.c:do_boot_states().

Signed-off-by Michal Simek <[email protected]>

---

 common/cmd_bootm.c | 3 +++
 1 file changed, 3 insertions(+)
common/cmd_bootm.c +3 -0
index 67233600b157..48199bfff3ed 100644
@@ -185,6 +185,9 @@ static char bootm_help_text[] =
 	"\tcmdline - OS specific command line processing/setup\n"
 	"\tbdt     - OS specific bd_t processing\n"
 	"\tprep    - OS specific prep before relocation or go\n"
+#if defined(CONFIG_TRACE)
+	"\tfake    - OS specific fake start without go\n"
+#endif
 	"\tgo      - start OS";
 #endif

--
1.8.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150115/02548599/attachment.pgp>

#1 lore raw

PATCH 1/1 common: bootm: Document fake bootm sub-command

Hi Michal,

Quoted 14 lines · Michal Simek

Fake option is enabled only when CONFIG_TRACE is
enabled in common/bootm.c:do_boot_states().

Signed-off-by Michal Simek <[email protected]>

---

 common/cmd_bootm.c | 3 +++
 1 file changed, 3 insertions(+)
common/cmd_bootm.c +0 -0
index 67233600b157..48199bfff3ed 100644

common/cmd_bootm.c static char bootm_help_text[] = · line 190

Quoted 6 lines
common/cmd_bootm.c +3 -0
@@ -185,6 +185,9 @@ static char bootm_help_text[] =
        "\tcmdline - OS specific command line processing/setup\n"
        "\tbdt     - OS specific bd_t processing\n"
        "\tprep    - OS specific prep before relocation or go\n"
+#if defined(CONFIG_TRACE)
+       "\tfake    - OS specific fake start without go\n"
+#endif

nit: I think it should be 'OS-specific'

common/cmd_bootm.c static char bootm_help_text[] = · line 192

Quoted 2 lines
common/cmd_bootm.c +0 -0
        "\tgo      - start OS";
 #endif

Regards,
Simon

#2 lore raw

PATCH 1/1 common: bootm: Document fake bootm sub-command

Quoted 12 lines · Simon Glass

Hi Michal,

Quoted 9 lines · Michal Simek

Fake option is enabled only when CONFIG_TRACE is
enabled in common/bootm.c:do_boot_states().

Signed-off-by Michal Simek <[email protected]>

---

 common/cmd_bootm.c | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

common/cmd_bootm.c static char bootm_help_text[] = · line 190

Quoted 11 lines
common/cmd_bootm.c +3 -0
index 67233600b157..48199bfff3ed 100644
@@ -185,6 +185,9 @@ static char bootm_help_text[] =
        "\tcmdline - OS specific command line processing/setup\n"
        "\tbdt     - OS specific bd_t processing\n"
        "\tprep    - OS specific prep before relocation or go\n"
+#if defined(CONFIG_TRACE)
+       "\tfake    - OS specific fake start without go\n"
+#endif

nit: I think it should be 'OS-specific'

Just following what it is written above but follow-up cleanup patch can be submitted.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150115/14b3c46b/attachment.pgp>
#3 lore raw

PATCH 1/1 common: bootm: Document fake bootm sub-command

Quoted 27 lines · Michal Simek
Quoted 12 lines · Simon Glass

Hi Michal,

Quoted 9 lines · Michal Simek

Fake option is enabled only when CONFIG_TRACE is
enabled in common/bootm.c:do_boot_states().

Signed-off-by Michal Simek <[email protected]>

---

 common/cmd_bootm.c | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

common/cmd_bootm.c static char bootm_help_text[] = · line 190

Quoted 11 lines
common/cmd_bootm.c +3 -0
index 67233600b157..48199bfff3ed 100644
@@ -185,6 +185,9 @@ static char bootm_help_text[] =
        "\tcmdline - OS specific command line processing/setup\n"
        "\tbdt     - OS specific bd_t processing\n"
        "\tprep    - OS specific prep before relocation or go\n"
+#if defined(CONFIG_TRACE)
+       "\tfake    - OS specific fake start without go\n"
+#endif

nit: I think it should be 'OS-specific'

Quoted 2 lines

Just following what it is written above but follow-up cleanup patch can be submitted.

OK.

Reviewed-by Simon Glass <[email protected]>
#4 lore raw

PATCH 1/1 common: bootm: Document fake bootm sub-command

Hi Tom,

Quoted 28 lines · Simon Glass
Quoted 27 lines · Michal Simek
Quoted 25 lines · Simon Glass

Hi Michal,

Quoted 14 lines · Michal Simek

Fake option is enabled only when CONFIG_TRACE is
enabled in common/bootm.c:do_boot_states().

Signed-off-by Michal Simek <[email protected]>

---

 common/cmd_bootm.c | 3 +++
 1 file changed, 3 insertions(+)
common/cmd_bootm.c +0 -0
index 67233600b157..48199bfff3ed 100644

common/cmd_bootm.c static char bootm_help_text[] = · line 190

Quoted 6 lines
common/cmd_bootm.c +3 -0
@@ -185,6 +185,9 @@ static char bootm_help_text[] =
        "\tcmdline - OS specific command line processing/setup\n"
        "\tbdt     - OS specific bd_t processing\n"
        "\tprep    - OS specific prep before relocation or go\n"
+#if defined(CONFIG_TRACE)
+       "\tfake    - OS specific fake start without go\n"
+#endif

nit: I think it should be 'OS-specific'

Quoted 7 lines
Quoted 2 lines

Just following what it is written above but follow-up cleanup patch can be submitted.

OK.

Reviewed-by Simon Glass <[email protected]>

Can you please apply this patch?

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150121/8b58b69d/attachment.pgp>
#5 lore raw
In reply to Michal Simek
Quoted 5 lines · Michal Simek

Fake option is enabled only when CONFIG_TRACE is
enabled in common/bootm.c:do_boot_states().

Signed-off-by Michal Simek <[email protected]>
Reviewed-by Simon Glass <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150202/83a54cc1/attachment.sig>