Skip to contentSkip to conversation

fcntl.h: Fix a typo

PATCH In review Bart Van Assche 2 participants 2 messages Feb 2, 2015

Subsystems (2)
Generic include/asm header files ABI/API
lore
Share & tools
lore

Bart Van Assche

author
#0 lore raw

PATCH 1/1 fcntl.h: Fix a typo

In the source file fs/fcntl.c and also in the fcntl() man page one can see that the FD_CLOEXEC flag can be manipulated via F_GETFD and F_SETFD. Update the comment in <fcntl.h> accordingly.

Signed-off-by Bart Van Assche <[email protected]>
Cc David Miller <davem-fT/PcQaiUtIeIZ0/[email protected]>
Cc Stephen Rothwell <[email protected]>
---
 include/uapi/asm-generic/fcntl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/asm-generic/fcntl.h +1 -1
index e063eff..584fa2b 100644
@@ -157,7 +157,7 @@ struct f_owner_ex {
 	__kernel_pid_t	pid;
 };
 
-/* for F_[GET|SET]FL */
+/* for F_[GET|SET]FD */
 #define FD_CLOEXEC	1	/* actually anything with low bit set goes */
 
 /* for posix fcntl() and lockf() */
Signature · 1 line
2.1.4
Acked-by on v1 1/1
#1 lore raw

Hi Bart,

Quoted 27 lines · On Mon, 02 Feb 2015 08:43:16 +0100 Bart Van Assche…

In the source file fs/fcntl.c and also in the fcntl() man page one can see that the FD_CLOEXEC flag can be manipulated via F_GETFD and F_SETFD. Update the comment in <fcntl.h> accordingly.

Signed-off-by Bart Van Assche <[email protected]>
Cc David Miller <davem-fT/PcQaiUtIeIZ0/[email protected]>
Cc Stephen Rothwell <[email protected]>
---
 include/uapi/asm-generic/fcntl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/asm-generic/fcntl.h +1 -1
index e063eff..584fa2b 100644
@@ -157,7 +157,7 @@ struct f_owner_ex {
 	__kernel_pid_t	pid;
 };
 
-/* for F_[GET|SET]FL */
+/* for F_[GET|SET]FD */
 #define FD_CLOEXEC	1	/* actually anything with low bit set goes */
 
 /* for posix fcntl() and lockf() */
Signature · 1 line
2.1.4

Looks good to me

Acked-by Stephen Rothwell <[email protected]>
Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]