Skip to contentSkip to conversation

bootlader/grub2: disable x86-64-efi choice on !BR2_ARCH_IS_64

PATCH New Samuel Martin 3 participants 3 messages Jan 16, 2015 – Feb 3, 2015

lore
Share & tools
lore

Samuel Martin

author
#0 lore raw

PATCH 1/1 bootlader/grub2: disable x86-64-efi choice on !BR2_ARCH_IS_64

When x86-64-efi platform is selected, grub2 automatically adds -m64 to the CFLAGS. This makes the configure script failed when the toolchain does not have multilib support (like the Buildroot ones).

Reported-by Noe Rubinstein <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
---
 boot/grub2/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/grub2/Config.in +1 -0
index 626344a..c465a4d 100644
@@ -132,6 +132,7 @@ config BR2_TARGET_GRUB2_I386_EFI
 
 config BR2_TARGET_GRUB2_X86_64_EFI
 	bool "x86-64-efi"
+	depends on BR2_ARCH_IS_64
 	help
 	  Select this option if the platform you're targetting has a
 	  64 bits EFI BIOS.
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 bootlader/grub2: disable x86-64-efi choice on !BR2_ARCH_IS_64

Samuel, All,

On 2015-01-16 18:58 +0100, Samuel Martin spake thusly:

Quoted 6 lines

When x86-64-efi platform is selected, grub2 automatically adds -m64 to the CFLAGS. This makes the configure script failed when the toolchain does not have multilib support (like the Buildroot ones).

Reported-by Noe Rubinstein <[email protected]>
Signed-off-by Samuel Martin <[email protected]>

I fail to see a case where we would want to build a 64-bit EFI GRUB to later start a 32-bit kernel and userland.

Since we do not support multilib, the user would have to have two
builds: one for the 32-bit kernel+userland, one for the 64-bit bootloader (if that is even possible to boot a 32-bit kernel from a 64-bit EFI GRUB).

Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 boot/grub2/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/grub2/Config.in +1 -0
index 626344a..c465a4d 100644
@@ -132,6 +132,7 @@ config BR2_TARGET_GRUB2_I386_EFI
 
 config BR2_TARGET_GRUB2_X86_64_EFI
 	bool "x86-64-efi"
+	depends on BR2_ARCH_IS_64
 	help
 	  Select this option if the platform you're targetting has a
 	  64 bits EFI BIOS.
Signature · 6 lines
2.1.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH 1/1 bootlader/grub2: disable x86-64-efi choice on !BR2_ARCH_IS_64

In reply to Samuel Martin

Dear Samuel Martin,

Quoted 6 lines · Samuel Martin

When x86-64-efi platform is selected, grub2 automatically adds -m64 to the CFLAGS. This makes the configure script failed when the toolchain does not have multilib support (like the Buildroot ones).

Reported-by Noe Rubinstein <[email protected]>
Signed-off-by Samuel Martin <[email protected]>

Applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com