Skip to contentSkip to conversation

media:ic:Remove calls to msleep from the functions,ov7670_s_vflip and ov7670_s_hflip

PATCH Jonathan Corbet 1 participant 1 message Feb 3, 2015 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 3 lines · On Mon, 2 Feb 2015 23:40:17 -0500 Nicholas Krause <[email protected]> wrote:

Removes the no longer required calls to msleep for the duration of 10 miliseconds in the functions,ov7670_s_vflip and ov7670_s_hflip respectfully due to no need for a delayed sleep of this duration in either function.

So I'm assuming you have the hardware and have verified that it still works in the absence of these delays?

No, of course you haven't. You don't understand why the delays are there, or why they might have a FIXME comment on them.

Nick, surely you've understood by now that this is not the right place to be putting your energy? A FIXME comment almost never indicates an issue that can be trivially resolved; it indicates something that the developer who wrote the code didn't see a solution to at the time. Why do you think you can resolve those issues without understanding them, without understanding the hardware, and without testing your work?

But then, others have tried to convey this point to you in the past; no reason to believe I'll be any more successful.

Please do not send this patch again.

jon