Skip to contentSkip to conversation

xen/acpi-processor: fix sparse warning

PATCH In review Lad Prabhakar 2 participants 3 messages Feb 5, 2015 Xen hypervisor interface

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/acpi-processor: fix sparse warning

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

xen-acpi-processor.c:505:23: warning: symbol 'xen_acpi_processor_resume_nb' was not declared. Should it be static?

---
Found this issue on linux-next (gcc version 4.9.2, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/xen/xen-acpi-processor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/xen/xen-acpi-processor.c +1 -1
index 59fc190..6c1f921 100644
@@ -502,7 +502,7 @@ static int xen_acpi_processor_resume(struct notifier_block *nb,
 	return xen_upload_processor_pm_data();
 }
 
-struct notifier_block xen_acpi_processor_resume_nb = {
+static struct notifier_block xen_acpi_processor_resume_nb = {
 	.notifier_call = xen_acpi_processor_resume,
 };
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 5 lines · Lad Prabhakar

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

xen-acpi-processor.c:505:23: warning: symbol 'xen_acpi_processor_resume_nb' was not declared. Should it be static?

Not sure if it is worth fixing it - as that whole code is only executed under normal PV guests - where it does not make sense for it be executed.

That whole xen_resume_notifier should go away.

Quoted 25 lines

---
Found this issue on linux-next (gcc version 4.9.2, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/xen/xen-acpi-processor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/xen/xen-acpi-processor.c +1 -1
index 59fc190..6c1f921 100644
@@ -502,7 +502,7 @@ static int xen_acpi_processor_resume(struct notifier_block *nb,
 	return xen_upload_processor_pm_data();
 }
 
-struct notifier_block xen_acpi_processor_resume_nb = {
+static struct notifier_block xen_acpi_processor_resume_nb = {
 	.notifier_call = xen_acpi_processor_resume,
 };
 
Signature · 1 line
1.9.1
#2 lore raw
In reply to Lad Prabhakar
Quoted 5 lines · Lad Prabhakar

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

xen-acpi-processor.c:505:23: warning: symbol 'xen_acpi_processor_resume_nb' was not declared. Should it be static?

Not sure if it is worth fixing it - as that whole code is only executed under normal PV guests - where it does not make sense for it be executed.

That whole xen_resume_notifier should go away.

Quoted 25 lines

---
Found this issue on linux-next (gcc version 4.9.2, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/xen/xen-acpi-processor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/xen/xen-acpi-processor.c +1 -1
index 59fc190..6c1f921 100644
@@ -502,7 +502,7 @@ static int xen_acpi_processor_resume(struct notifier_block *nb,
 	return xen_upload_processor_pm_data();
 }
 
-struct notifier_block xen_acpi_processor_resume_nb = {
+static struct notifier_block xen_acpi_processor_resume_nb = {
 	.notifier_call = xen_acpi_processor_resume,
 };
 
Signature · 1 line
1.9.1