Skip to contentSkip to conversation

staging: unisys: remove unused variable

PATCH Superseded Sudip Mukherjee 2 participants 11 messages Feb 6, 2015 – Feb 11, 2015 Staging

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 staging: unisys: remove unused variable

we were getting lots of warnings about _tempresult set but not used. _tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY which was again using another macro ISSUE_IO_EXTENDED_VMCALL. but the vallue assigned to it was never used.

---
 drivers/staging/unisys/common-spar/include/vmcallinterface.h | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/staging/unisys/common-spar/include/vmcallinterface.h +3 -6
index 7833371..59a7459 100644
@@ -79,18 +79,15 @@ enum vmcall_monitor_interface_method_tuple { /* VMCALL identification tuples  */
 #define ISSUE_IO_VMCALL(method, param, result) \
 	(result = unisys_vmcall(method, (param) & 0xFFFFFFFF,	\
 				(param) >> 32))
-#define ISSUE_IO_EXTENDED_VMCALL(method, param1, param2,	\
-				 param3, result)			\
-	(result = unisys_extended_vmcall(method, param1,	\
-					 param2, param3))
+#define ISSUE_IO_EXTENDED_VMCALL(method, param1, param2, param3) \
+	unisys_extended_vmcall(method, param1, param2, param3)
 
     /* The following uses VMCALL_POST_CODE_LOGEVENT interface but is currently
      * not used much */
 #define ISSUE_IO_VMCALL_POSTCODE_SEVERITY(postcode, severity)		\
 do {									\
-	u32 _tempresult = VMCALL_SUCCESS;				\
 	ISSUE_IO_EXTENDED_VMCALL(VMCALL_POST_CODE_LOGEVENT, severity,	\
-				 MDS_APPOS, postcode, _tempresult);	\
+				 MDS_APPOS, postcode);			\
 } while (0)
 #endif
 
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 2/2 staging: unisys: fix directory warning

we were getting three warnings about timskmod and sparstopdriver and channels. These warnings were about no such file or directory. These directory names were included in the Makefile, but the directories were not existing.

---
 drivers/staging/unisys/uislib/Makefile  | 2 --
 drivers/staging/unisys/virthba/Makefile | 1 -
 2 files changed, 3 deletions(-)
drivers/staging/unisys/uislib/Makefile +0 -2
index 08e620d..860f494 100644
@@ -7,8 +7,6 @@ obj-$(CONFIG_UNISYS_UISLIB)	+= visoruislib.o
 visoruislib-y := uislib.o uisqueue.o  uisthread.o  uisutils.o
 
 ccflags-y += -Idrivers/staging/unisys/include
-ccflags-y += -Idrivers/staging/unisys/channels
 ccflags-y += -Idrivers/staging/unisys/visorchipset
-ccflags-y += -Idrivers/staging/unisys/sparstopdriver
 ccflags-y += -Idrivers/staging/unisys/common-spar/include
 ccflags-y += -Idrivers/staging/unisys/common-spar/include/channels
drivers/staging/unisys/virthba/Makefile +0 -1
index ba55ae1..a4e4037 100644
@@ -6,7 +6,6 @@ obj-$(CONFIG_UNISYS_VIRTHBA)	+= virthba.o
 
 ccflags-y += -Idrivers/staging/unisys/include
 ccflags-y += -Idrivers/staging/unisys/uislib
-ccflags-y += -Idrivers/staging/unisys/timskmod
 ccflags-y += -Idrivers/staging/unisys/visorchipset
 ccflags-y += -Idrivers/staging/unisys/virtpci
 ccflags-y += -Idrivers/staging/unisys/common-spar/include
Signature · 1 line
1.8.1.2
#2 lore raw

Re: [PATCH 2/2] staging: unisys: fix directory warning

Quoted 4 lines · Sudip Mukherjee

we were getting three warnings about timskmod and sparstopdriver and channels. These warnings were about no such file or directory. These directory names were included in the Makefile, but the directories were not existing.

What tool generated these warnings, I don't see them here?

thanks,

greg k-h

#3 lore raw

Re: [PATCH 2/2] staging: unisys: fix directory warning

In reply to Sudip Mukherjee
Quoted 6 lines · Sudip Mukherjee

we were getting three warnings about timskmod and sparstopdriver and channels. These warnings were about no such file or directory. These directory names were included in the Makefile, but the directories were not existing.

Same email address problem as patch 1/2.

#4 lore raw
In reply to Sudip Mukherjee
Quoted 6 lines · Sudip Mukherjee

we were getting lots of warnings about _tempresult set but not used. _tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY which was again using another macro ISSUE_IO_EXTENDED_VMCALL. but the vallue assigned to it was never used.

Your From: address, and this address don't match, so I can't take this :(

Fix that up please and resend.

Also, what tool generated those warnings?

thanks,

greg k-h

#5 lore raw
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Sudip Mukherjee

we were getting lots of warnings about _tempresult set but not used. _tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY which was again using another macro ISSUE_IO_EXTENDED_VMCALL. but the vallue assigned to it was never used.

Your From: address, and this address don't match, so I can't take this :(

all my patches have been like this way, and you have taken them before :)
the reason its like this way - (already discussed with Dan Carpenter, reference https://lkml.org/lkml/2014/9/3/473)

we have strict DMARC check for the corporate mail server. DMARC = domain based message authentication. So the mail i sent reached all the list subscriber from a different server than our designated server, and as a result it is marked as spam in many places and I have already received a few complaints regarding that.

so at https://lkml.org/lkml/2014/9/3/535 Dan said its ok for him, but depends on you if you want to accept. And since you have accepted all my patches before so i thought it is ok with you.

if you want I can add an extra From: line, but Dan has already given his commments for that at https://lkml.org/lkml/2014/9/3/135
quoting him :

"If everyone starts using From headers like this then it becomes a pain to deal with."

please let me know how you want me to send the patches if different email address is a problem. I thought different name is a problem, but different email address???

Quoted 4 lines

Fix that up please and resend.

Also, what tool generated those warnings?

just make W=1 will give these warnings.

regards
sudip

Quoted 4 lines

thanks,

greg k-h

#6 lore raw
Quoted 15 lines · Sudip Mukherjee
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Sudip Mukherjee

we were getting lots of warnings about _tempresult set but not used. _tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY which was again using another macro ISSUE_IO_EXTENDED_VMCALL. but the vallue assigned to it was never used.

Your From: address, and this address don't match, so I can't take this :(

all my patches have been like this way, and you have taken them before :)
the reason its like this way - (already discussed with Dan Carpenter, reference https://lkml.org/lkml/2014/9/3/473)

Quoted 6 lines

we have strict DMARC check for the corporate mail server. DMARC = domain based message authentication. So the mail i sent reached all the list subscriber from a different server than our designated server, and as a result it is marked as spam in many places and I have already received a few complaints regarding that.

so at https://lkml.org/lkml/2014/9/3/535 Dan said its ok for him, but depends on you if you want to accept. And since you have accepted all my patches before so i thought it is ok with you.

I didn't notice it before, sorry.

Quoted 4 lines

if you want I can add an extra From: line, but Dan has already given his commments for that at https://lkml.org/lkml/2014/9/3/135
quoting him :

"If everyone starts using From headers like this then it becomes a pain to deal with."

It's not a pain to deal with on my end at all.

But as I've missed this in the past, nevermind, I'll take it as is. Can you resend your outstanding patches and I'll queue them up after 3.20-rc1 is out.

thanks,

greg k-h

#7 lore raw
Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · Sudip Mukherjee
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Sudip Mukherjee

we were getting lots of warnings about _tempresult set but not used. _tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY which was again using another macro ISSUE_IO_EXTENDED_VMCALL. but the vallue assigned to it was never used.

Your From: address, and this address don't match, so I can't take this :(

all my patches have been like this way, and you have taken them before :)
the reason its like this way - (already discussed with Dan Carpenter, reference https://lkml.org/lkml/2014/9/3/473)

Quoted 8 lines
Quoted 6 lines

we have strict DMARC check for the corporate mail server. DMARC = domain based message authentication. So the mail i sent reached all the list subscriber from a different server than our designated server, and as a result it is marked as spam in many places and I have already received a few complaints regarding that.

so at https://lkml.org/lkml/2014/9/3/535 Dan said its ok for him, but depends on you if you want to accept. And since you have accepted all my patches before so i thought it is ok with you.

I didn't notice it before, sorry.

no problem. we all know how much busy you are .. :)

Quoted 11 lines
Quoted 5 lines

if you want I can add an extra From: line, but Dan has already given his commments for that at https://lkml.org/lkml/2014/9/3/135
quoting him :

"If everyone starts using From headers like this then it becomes a pain to deal with."

It's not a pain to deal with on my end at all.

But as I've missed this in the past, nevermind, I'll take it as is. Can you resend your outstanding patches and I'll queue them up after 3.20-rc1 is out.

i will resend them now or should i send after the merge window closes?
and on 07th feb you have added my two patches to staging-testing, but it still is not in linux-next, do i need to resend them also or they are in process so nothing to do from my side?

regards
sudip

Quoted 4 lines

thanks,

greg k-h

#8 lore raw
Quoted 11 lines · Sudip Mukherjee
Quoted 10 lines
Quoted 4 lines

if you want I can add an extra From: line, but Dan has already given his commments for that at https://lkml.org/lkml/2014/9/3/135
quoting him :

"If everyone starts using From headers like this then it becomes a pain to deal with."

It's not a pain to deal with on my end at all.

But as I've missed this in the past, nevermind, I'll take it as is. Can you resend your outstanding patches and I'll queue them up after 3.20-rc1 is out.

i will resend them now or should i send after the merge window closes?

You can send patches any time, I'll batch them up and apply them to my trees at the proper time.

Quoted 3 lines

and on 07th feb you have added my two patches to staging-testing, but it still is not in linux-next, do i need to resend them also or they are in process so nothing to do from my side?

Nothing to do on your side, I am on the road this week and will move those to my -next branch right now, thanks for reminding me.

greg k-h

#9 lore raw
Quoted 4 lines · Greg Kroah-Hartman

On Tue, Feb 10, 2015 at 10:50:06AM +0530, Sudip Mukherjee wrote:

Nothing to do on your side, I am on the road this week and will move those to my -next branch right now, thanks for reminding me.

welcome sir. If you ever need an assisstant (for reminding or for coding) you can count me in :)

I can see that you are in HongKong now, please do let us know if you ever plan to be on the roads in India. I am sure all of us here will like to meet you. we can have a beer or two while learning few things from you.

sudip

Quoted 2 lines

greg k-h

#10 lore raw
In reply to Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman
Quoted 5 lines · Sudip Mukherjee
Quoted 4 lines

But as I've missed this in the past, nevermind, I'll take it as is. Can you resend your outstanding patches and I'll queue them up after 3.20-rc1 is out.

i will resend them now or should i send after the merge window closes?

You can send patches any time, I'll batch them up and apply them to my trees at the proper time.

i have sent them as v2, i think i should have sent as [PATCH resend] :(

sudip

Quoted 1 line