Skip to contentSkip to conversation

divide error: 0000 in the gspca_topro

DISCUSSION Linus Torvalds 4 participants 5 messages Feb 9, 2015 – Feb 10, 2015 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

I got this, and it certainly seems relevant,.

It would seem that that whole 'quality' thing needs some range checking, it should presumably be in the range [1..100] in order to avoid negative 'sc' values or the divide-by-zero.

Hans, Mauro?

Linus

---------- Forwarded message ----------
From: Peter Kovář <[email protected]>
Date: Sun, Feb 8, 2015 at 2:18 PM
Subject: divide error: 0000 in the gspca_topro
To: Linus Torvalds <[email protected]>

Hi++ Linus!

There is a trivial bug in the gspca_topro webcam driver.

/* set the JPEG quality for sensor soi763a */
static void jpeg_set_qual(u8 *jpeg_hdr,
int quality)

{
        int i, sc;

        if (quality < 50)
                sc = 5000 / quality;
        else
                sc = 200 - quality * 2;

Crash can be reproduced by setting JPEG quality to zero in the guvcview application.

Cheers,

Peter Kovář
50 65 74 65 72 20 4B 6F 76 C3 A1 C5 99

#2 lore raw
Quoted 9 lines · Linus Torvalds

I got this, and it certainly seems relevant,.

It would seem that that whole 'quality' thing needs some range checking, it should presumably be in the range [1..100] in order to avoid negative 'sc' values or the divide-by-zero.

Hans, Mauro?

Linus

Hello Linus,

The case of quality being set to 0 is correctly handled in drivers/media/usb/gspca/jpeg.h [0], so I have sent a patch to do the same in topro.c.

Thanks,
Luis

[0] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/media/usb/gspca/jpeg.h#n157

Quoted 36 lines

---------- Forwarded message ----------
From: Peter Kovář <[email protected]>
Date: Sun, Feb 8, 2015 at 2:18 PM
Subject: divide error: 0000 in the gspca_topro
To: Linus Torvalds <[email protected]>

Hi++ Linus!

There is a trivial bug in the gspca_topro webcam driver.

/* set the JPEG quality for sensor soi763a */
static void jpeg_set_qual(u8 *jpeg_hdr,
int quality)

{
        int i, sc;

        if (quality < 50)
                sc = 5000 / quality;
        else
                sc = 200 - quality * 2;

Crash can be reproduced by setting JPEG quality to zero in the guvcview application.

Cheers,

Peter Kovář
50 65 74 65 72 20 4B 6F 76 C3 A1 C5 99
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

Em Mon, 09 Feb 2015 10:23:48 +0000
Luis de Bethencourt <[email protected]> escreveu:

Quoted 9 lines · Linus Torvalds
Quoted 8 lines

I got this, and it certainly seems relevant,.

It would seem that that whole 'quality' thing needs some range checking, it should presumably be in the range [1..100] in order to avoid negative 'sc' values or the divide-by-zero.

Hans, Mauro?

Quoted 7 lines
Quoted 1 line

Linus

Hello Linus,

The case of quality being set to 0 is correctly handled in drivers/media/usb/gspca/jpeg.h [0], so I have sent a patch to do the same in topro.c.

Patch looks good to me.

I'll double check if some other driver has the same bad handling for quality set and give a couple days for Hans to take a look.

If he's fine with this approach, I'll add it on a separate pull request.

Regards,
Mauro

Quoted 42 lines

Thanks,
Luis

[0] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/media/usb/gspca/jpeg.h#n157

Quoted 36 lines

---------- Forwarded message ----------
From: Peter Kovář <[email protected]>
Date: Sun, Feb 8, 2015 at 2:18 PM
Subject: divide error: 0000 in the gspca_topro
To: Linus Torvalds <[email protected]>

Hi++ Linus!

There is a trivial bug in the gspca_topro webcam driver.

/* set the JPEG quality for sensor soi763a */
static void jpeg_set_qual(u8 *jpeg_hdr,
int quality)

{
        int i, sc;

        if (quality < 50)
                sc = 5000 / quality;
        else
                sc = 200 - quality * 2;

Crash can be reproduced by setting JPEG quality to zero in the guvcview application.

Cheers,

Peter Kovář
50 65 74 65 72 20 4B 6F 76 C3 A1 C5 99
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 22 lines · Mauro Carvalho Chehab

Em Mon, 09 Feb 2015 10:23:48 +0000
Luis de Bethencourt <[email protected]> escreveu:

Quoted 9 lines · Linus Torvalds
Quoted 8 lines

I got this, and it certainly seems relevant,.

It would seem that that whole 'quality' thing needs some range checking, it should presumably be in the range [1..100] in order to avoid negative 'sc' values or the divide-by-zero.

Hans, Mauro?

Quoted 7 lines
Quoted 1 line

Linus

Hello Linus,

The case of quality being set to 0 is correctly handled in drivers/media/usb/gspca/jpeg.h [0], so I have sent a patch to do the same in topro.c.

Patch looks good to me.

Quoted 8 lines

I'll double check if some other driver has the same bad handling for quality set and give a couple days for Hans to take a look.

If he's fine with this approach, I'll add it on a separate pull request.

Regards,
Mauro

Hi Mauro,

Thanks for taking the time to look at this.

After sending the patch I searched around for any similar cases, only finding coda/coda-jpeg.c [0], but in this case the quality is clipped to 5 if it is < 5.

I might have missed some other case though. Just letting you know to help you save some time.

Cheers,
Luis

[0] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/media/platform/coda/coda-jpeg.c#n216

Quoted 42 lines
Quoted 42 lines

Thanks,
Luis

[0] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/media/usb/gspca/jpeg.h#n157

Quoted 36 lines

---------- Forwarded message ----------
From: Peter Kovář <[email protected]>
Date: Sun, Feb 8, 2015 at 2:18 PM
Subject: divide error: 0000 in the gspca_topro
To: Linus Torvalds <[email protected]>

Hi++ Linus!

There is a trivial bug in the gspca_topro webcam driver.

/* set the JPEG quality for sensor soi763a */
static void jpeg_set_qual(u8 *jpeg_hdr,
int quality)

{
        int i, sc;

        if (quality < 50)
                sc = 5000 / quality;
        else
                sc = 200 - quality * 2;

Crash can be reproduced by setting JPEG quality to zero in the guvcview application.

Cheers,

Peter Kovář
50 65 74 65 72 20 4B 6F 76 C3 A1 C5 99
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Acked-by
#5 lore raw
In reply to Mauro Carvalho Chehab

Hi,

Quoted 20 lines · Mauro Carvalho Chehab

Em Mon, 09 Feb 2015 10:23:48 +0000
Luis de Bethencourt <[email protected]> escreveu:

Quoted 9 lines · Linus Torvalds
Quoted 8 lines

I got this, and it certainly seems relevant,.

It would seem that that whole 'quality' thing needs some range checking, it should presumably be in the range [1..100] in order to avoid negative 'sc' values or the divide-by-zero.

Hans, Mauro?

Quoted 7 lines
Quoted 1 line

Linus

Hello Linus,

The case of quality being set to 0 is correctly handled in drivers/media/usb/gspca/jpeg.h [0], so I have sent a patch to do the same in topro.c.

Quoted 6 lines

Patch looks good to me.

I'll double check if some other driver has the same bad handling for quality set and give a couple days for Hans to take a look.

If he's fine with this approach, I'll add it on a separate pull request.

Luis' patch for this looks good to me and is:

Mauro, thanks for picking this one up.

Regards,

Hans