PM / devfreq: event: testing the wrong variable
Subsystems (4)
PATCH 1/1 PM / devfreq: event: testing the wrong variable
There is a typo here so we test "edev" but we intended to test "edev[i]".
drivers/devfreq/event/exynos-ppmu.c +2 -2
@@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)for (i =0 ; i < info->num_events; i++) { edev[i] =devm_devfreq_event_add_edev (&pdev->dev, &desc[i]); -if (IS_ERR (edev)) { - ret =PTR_ERR (edev); +if (IS_ERR (edev[i])) { + ret =PTR_ERR (edev[i]);dev_err (&pdev->dev,"failed to add devfreq-event device\n" ); goto err;
Quoted 12 lines · Dan Carpenter
There is a typo here so we test "edev" but we intended to test "edev[i]".
Fixes f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')Signed-off-by Dan Carpenter <[email protected]>drivers/devfreq/event/exynos-ppmu.c +0
-0
drivers/devfreq/event/exynos-ppmu.c static int exynos_ppmu_probe(struct platform_device *pdev) · line 334
Quoted 10 lines
drivers/devfreq/event/exynos-ppmu.c +2
-2@@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)for (i =0 ; i < info->num_events; i++) { edev[i] =devm_devfreq_event_add_edev (&pdev->dev, &desc[i]); -if (IS_ERR (edev)) { - ret =PTR_ERR (edev); +if (IS_ERR (edev[i])) { + ret =PTR_ERR (edev[i]);dev_err (&pdev->dev,"failed to add devfreq-event device\n" ); goto err;
But,
This patch has not yet merged to linux.git (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git).
After releasing Linux 3.20-rc1, this patch will be handled.
Thanks,
Chanwoo Choi
MyungJoo Ham
maintainerQuoted 20 lines · Dan Carpenter
Quoted 11 lines
There is a typo here so we test "edev" but we intended to test "edev[i]".
Fixes f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')Signed-off-by Dan Carpenter <[email protected]>drivers/devfreq/event/exynos-ppmu.c +0
-0drivers/devfreq/event/exynos-ppmu.c static int exynos_ppmu_probe(struct platform_device *pdev) · line 328
Quoted 4 lines
drivers/devfreq/event/exynos-ppmu.c +2
-2@@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev) -if (IS_ERR (edev)) { - ret =PTR_ERR (edev); +if (IS_ERR (edev[i])) { + ret =PTR_ERR (edev[i]);Reviewed-by Chanwoo Choi <[email protected]>
Quoted 6 lines
But,
This patch has not yet merged to linux.git (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git).
After releasing Linux 3.20-rc1, this patch will be handled.Thanks,
Chanwoo Choi