tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.
PATCH 1/1 tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.
It is already used in the runlevel script and the service file. It is supposed to replace XENSTORED_TRACE= boolean, which cant be easily supported in the xenstored.service file.
---
This was ignored for 4.5.0, it should be backported to 4.5.1.
tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 8 ++++++++ 1 file changed, 8 insertions(+)
tools/hotplug/Linux/init.d/sysconfig.xencommons.in +8 -0
@@ -21,6 +21,14 @@ #XENSTORED=@XENSTORED@ ## Type: string +## Default: "" +# +# Additional commandline arguments to start xenstored, +# like "--trace-file /var/log/xen/xenstored-trace.log" +# See "@sbindir@/xenstored --help" for possible options. +XENSTORED_ARGS= + +## Type: string ## Default: Not defined, tracing off # # Log xenstored messages
Ping?
Quoted 36 lines · Olaf Hering
It is already used in the runlevel script and the service file. It is supposed to replace XENSTORED_TRACE= boolean, which cant be easily supported in the xenstored.service file.
Signed-off-by Olaf Hering <[email protected]>Cc Ian Jackson <[email protected]>Cc Stefano Stabellini <[email protected]>Cc Ian Campbell <[email protected]>Cc Wei Liu <[email protected]>---
This was ignored for 4.5.0, it should be backported to 4.5.1.
tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 8 ++++++++ 1 file changed, 8 insertions(+)tools/hotplug/Linux/init.d/sysconfig.xencommons.in +8
-0@@ -21,6 +21,14 @@ #XENSTORED=@XENSTORED@ ## Type: string +## Default: "" +# +# Additional commandline arguments to start xenstored, +# like "--trace-file /var/log/xen/xenstored-trace.log" +# See "@sbindir@/xenstored --help" for possible options. +XENSTORED_ARGS= + +## Type: string ## Default: Not defined, tracing off # # Log xenstored messages
Olaf Hering writes ("[PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file."):
Quoted 3 lines
It is already used in the runlevel script and the service file. It is supposed to replace XENSTORED_TRACE= boolean, which cant be easily supported in the xenstored.service file.
I haven't gone through all the history again, but I think the last time this came up I objected to the idea that XENSTORED_TRACE was being deprecated.
I don't object to XENSTORED_ARGS as an additional variable. So I think this could be addressed by (a) not saying in the commit message that XENSTORED_TRACE is being replaced and (b) using a different example (or no) example in the comment.
Thanks,
Ian.
Quoted 5 lines · Ian Jackson
Olaf Hering writes ("[PATCH]
tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file."):Quoted 3 lines
It is already used in the runlevel script and the service file. It is supposed to replace XENSTORED_TRACE= boolean, which cant be easily supported in the xenstored.service file.
Quoted 8 lines
I haven't gone through all the history again, but I think the last time this came up I objected to the idea that
XENSTORED_TRACEwas being deprecated.I don't object to
XENSTORED_ARGSas an additional variable. So I think this could be addressed by (a) not saying in the commit message thatXENSTORED_TRACEis being replaced and (b) using a different example (or no) example in the comment.
Ok, I will adjust the commit message and resend along with other pending tools changes.
Olaf