Skip to contentSkip to conversation

watchdog: mtk_wdt: signedness bug in mtk_wdt_start()

PATCH In review Dan Carpenter 4 participants 4 messages Feb 11, 2015 – Mar 24, 2015

Subsystems (3)
Kernel janitors Arm MediaTek Watchdog device drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 watchdog: mtk_wdt: signedness bug in mtk_wdt_start()

"ret" should be signed for the error handling to work correctly. This doesn't matter much in real life since mtk_wdt_set_timeout() always succeeds.

Signed-off-by Dan Carpenter <[email protected]>
drivers/watchdog/mtk_wdt.c +1 -1
index a87f6df..938b987 100644
@@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
 	u32 reg;
 	struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);
 	void __iomem *wdt_base = mtk_wdt->wdt_base;
-	u32 ret;
+	int ret;
 
 	ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);
 	if (ret < 0)
maintainer Reviewed-by on v1 1/1
#1 lore raw

2015-02-11 11:26 GMT+01:00 Dan Carpenter <[email protected]>:

Quoted 5 lines

"ret" should be signed for the error handling to work correctly. This doesn't matter much in real life since mtk_wdt_set_timeout() always succeeds.

Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Matthias Brugger <[email protected]>
Quoted 14 lines
drivers/watchdog/mtk_wdt.c +1 -1
index a87f6df..938b987 100644
@@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
        u32 reg;
        struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);
        void __iomem *wdt_base = mtk_wdt->wdt_base;
-       u32 ret;
+       int ret;
 
        ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);
        if (ret < 0)
Signature · 1 line
motzblog.wordpress.com
#3 lore raw
In reply to Dan Carpenter

Hi Dan,

Quoted 11 lines

"ret" should be signed for the error handling to work correctly. This doesn't matter much in real life since mtk_wdt_set_timeout() always succeeds.

Signed-off-by Dan Carpenter <[email protected]>
drivers/watchdog/mtk_wdt.c +0 -0
index a87f6df..938b987 100644

drivers/watchdog/mtk_wdt.c static int mtk_wdt_start(struct watchdog_device *wdt_dev) · line 139

Quoted 8 lines
drivers/watchdog/mtk_wdt.c +1 -1
@@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
 	u32 reg;
 	struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);
 	void __iomem *wdt_base = mtk_wdt->wdt_base;
-	u32 ret;
+	int ret;
 
 	ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);
 	if (ret < 0)

Added to linux-watchdog-next. Will go upstream in 2 days.

Kind regards,
Wim.