Skip to contentSkip to conversation

perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check

PATCH Applied Josh Boyer 3 participants 4 messages Feb 11, 2015 – Mar 1, 2015 perf events

lore
Share & tools
lore

Josh Boyer

author
#0 lore raw

PATCH 1/1 perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check

The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE must be defined before pthread.h is included in order to get the proper function declaration. Define this in the Makefile.

Without this defined, the feature check fails on a Fedora system with gcc5 and then the perf build later fails with conflicting prototypes for the function.

---
 tools/perf/config/feature-checks/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Full logs at:
http://koji.fedoraproject.org/koji/getfile?taskID=8895543&name=build.log

tools/perf/config/feature-checks/Makefile +1 -1
index 42ac05aaf8ac..b32ff3372514 100644
@@ -49,7 +49,7 @@ test-hello.bin:
 	$(BUILD)
 
 test-pthread-attr-setaffinity-np.bin:
-	$(BUILD) -Werror -lpthread
+	$(BUILD) -D_GNU_SOURCE -Werror -lpthread
 
 test-stackprotector-all.bin:
 	$(BUILD) -Werror -fstack-protector-all
Signature · 1 line
2.1.0
maintainer Applied
#1 lore raw

Em Wed, Feb 11, 2015 at 11:24:05AM -0500, Josh Boyer escreveu:

Quoted 4 lines

The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE must be defined before pthread.h is included in order to get the proper function declaration. Define this in the Makefile.

Quoted 8 lines

Without this defined, the feature check fails on a Fedora system with gcc5 and then the perf build later fails with conflicting prototypes for the function.

---
 tools/perf/config/feature-checks/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied

#2 lore raw
In reply to Josh Boyer
perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
Commit-ID:  39f5704399042fff5f0d5f6af32bbbc3e787a897
Gitweb:     http://git.kernel.org/tip/39f5704399042fff5f0d5f6af32bbbc3e787a897
Author:     Josh Boyer <[email protected]>
AuthorDate: Wed, 11 Feb 2015 11:24:05 -0500
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 11 Feb 2015 17:38:55 -0300

perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check

The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE must be defined before pthread.h is included in order to get the proper function declaration. Define this in the Makefile.

Without this defined, the feature check fails on a Fedora system with gcc5 and then the perf build later fails with conflicting prototypes for the function.

---
 tools/perf/config/feature-checks/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/config/feature-checks/Makefile +1 -1
index 42ac05a..b32ff33 100644
@@ -49,7 +49,7 @@ test-hello.bin:
 	$(BUILD)
 
 test-pthread-attr-setaffinity-np.bin:
-	$(BUILD) -Werror -lpthread
+	$(BUILD) -D_GNU_SOURCE -Werror -lpthread
 
 test-stackprotector-all.bin:
 	$(BUILD) -Werror -fstack-protector-all
#3 lore raw
In reply to Josh Boyer
perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
Commit-ID:  8eb733829cd17b9b66971f08110df7224d391d65
Gitweb:     http://git.kernel.org/tip/8eb733829cd17b9b66971f08110df7224d391d65
Author:     Josh Boyer <[email protected]>
AuthorDate: Wed, 11 Feb 2015 11:24:05 -0500
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 25 Feb 2015 12:17:38 -0300

perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check

The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE must be defined before pthread.h is included in order to get the proper function declaration. Define this in the Makefile.

Without this defined, the feature check fails on a Fedora system with gcc5 and then the perf build later fails with conflicting prototypes for the function.

---
 tools/perf/config/feature-checks/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/config/feature-checks/Makefile +1 -1
index 42ac05a..b32ff33 100644
@@ -49,7 +49,7 @@ test-hello.bin:
 	$(BUILD)
 
 test-pthread-attr-setaffinity-np.bin:
-	$(BUILD) -Werror -lpthread
+	$(BUILD) -D_GNU_SOURCE -Werror -lpthread
 
 test-stackprotector-all.bin:
 	$(BUILD) -Werror -fstack-protector-all