NVidia GPU binary blobs for x86 and ARM (branch yem/gfx2)

Some OpenGL/EGL/GLES/VG providers do not provide the corresponding headers, and rely on using "the headers provided by the distribution".

In our case, we can not rely on such headers, because we are not a distribution, and we have no way to provide those headers (not even speaking about relying on the headers provided by hte host distribution, because they might well not be installed at all).

Also, we can not rely on another package to provide those headers, because we can only have one provider enabled in any configuration.

The Khronos group provides such headers, and they are the reference headers, but we can not realy use them:

- most of them are not packaged: they are not versioned and not

    provided in a tarball, but as separately downloadable files;

- those headers are anyway incomplete: there are headers not
provided by Khronos, like GL.h

Instead, we rely on mesa3d to provide those headers: mesa3d has all the headers we need.

Modifying the existing mesa3d package would not be easy; we'd have to differentiate whther we need only the headers or the full package. The meas3d Config.in and .mk are already quite non-trivial that adding such a feature would render them even more illegible.

So, we introduce mea3d-headers as a new package, that is in fact just mesa3d with a much simplified Config.in and .mk, that other OpenXXX providers may select if they do not provide the OpenXXX headers.

Note: we're not installing GLES3 headers, because what Buildroot currently calls libgles is in fact libgles2; we have no way to specify that we have libgles3. So, we just install headers for GLES and GLES2.

Signed-off-by "Yann E. MORIN" <[email protected]>

---
Notes:

It should not be possible to select both mesa3d *and* mesa3d-headers at the same time, but it is difficult to foresee the multiple combinations we may have, due to poor understanding on how binary drivers may behave and what they may require, as well as my own poor understanding of the GL stack(s).

So I decided to just print a warning in that case, and just depend on mesa3d, which would ultimately provide the headers we are interested in anyway. This can be turned into an error if preferred.

---
 package/Config.in                          |  1 +
 package/mesa3d-headers/Config.in           |  8 ++++
 package/mesa3d-headers/mesa3d-headers.hash |  1 +
 package/mesa3d-headers/mesa3d-headers.mk   | 60
++++++++++++++++++++++++++++++
package/mesa3d/mesa3d.mk                   |  1 + 5 files changed, 71
insertions(+) create mode 100644 package/mesa3d-headers/Config.in
 create mode 120000 package/mesa3d-headers/mesa3d-headers.hash
 create mode 100644 package/mesa3d-headers/mesa3d-headers.mk

package/Config.in +1 -0

index 757237e..f25886a 100644
@@ -211,6 +211,7 @@ endif
 	source "package/linux-fusion/Config.in"
 	source "package/lite/Config.in"
 	source "package/mesa3d/Config.in"
+	source "package/mesa3d-headers/Config.in"
 	source "package/ocrad/Config.in"
 	source "package/psplash/Config.in"
 	source "package/sawman/Config.in"

(quoted diff) +0 -0

b/package/mesa3d-headers/Config.in new file mode 100644 index 0000000..a64fc0c

package/mesa3d-headers/Config.in new file +4 -0

@@ -0,0 +1,8 @@
+config BR2_PACKAGE_MESA3D_HEADERS
+	bool
+	help
+	  Mesa 3D, an open-source implementation of the OpenGL

specification. +

package/mesa3d-headers/Config.in new file +1 -0

+	  This package only installs headers needed by other

packages. +

package/mesa3d-headers/Config.in new file +1 -0

+	  http://mesa3d.org

(quoted diff) +0 -0

b/package/mesa3d-headers/mesa3d-headers.hash new file mode 120000 index 0000000..137d0be

package/mesa3d-headers/mesa3d-headers.hash new file +1 -0

@@ -0,0 +1 @@
+../mesa3d/mesa3d.hash
\ No newline at end of file

(quoted diff) +0 -0

b/package/mesa3d-headers/mesa3d-headers.mk new file mode 100644 index 0000000..acfc9a3

package/mesa3d-headers/mesa3d-headers.mk new file +21 -0

@@ -0,0 +1,60 @@
+################################################################################
+#
+# mesa3d-headers
+#
+################################################################################
+
+# mesa3d-headers is inherently incompatible with mesa3d, so if mesa3d
+# is enabled, just rely on it.
+
+ifeq ($(BR2_PACKAGE_MESA3D),y)
+
+ifeq ($(BR2_PACKAGE_MESA3D_HEADERS),y)
+$(warning mesa3d-headers enabled, but mesa3d enabled too)
+endif
+
+MESA3D_HEADERS_SOURCE =
+MESA3D_HEADERS_DEPENDENCIES = mesa3d
+
+else # mesa3d
+
+# Not possible to directly refer to mesa3d variables, because of

first/second +# expansion trickery...

package/mesa3d-headers/mesa3d-headers.mk new file +3 -0

+MESA3D_HEADERS_VERSION = 10.4.4
+MESA3D_HEADERS_SOURCE = MesaLib-$(MESA3D_HEADERS_VERSION).tar.bz2
+MESA3D_HEADERS_SITE =

ftp://ftp.freedesktop.org/pub/mesa/$(MESA3D_HEADERS_VERSION)

package/mesa3d-headers/mesa3d-headers.mk new file +28 -0

+MESA3D_HEADERS_LICENSE = MIT, SGI, Khronos
+MESA3D_HEADERS_LICENSE_FILES = docs/license.html +
+# Only installs header files
+MESA3D_HEADERS_INSTALL_STAGING = YES
+MESA3D_HEADERS_INSTALL_TARGET = NO
+
+MESA3D_HEADERS_DIRS = KHR
+
+ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
+MESA3D_HEADERS_DIRS += GL
+endif
+
+ifeq ($(BR2_PACKAGE_HAS_LIBEGL),y)
+MESA3D_HEADERS_DIRS += EGL
+endif
+
+ifeq ($(BR2_PACKAGE_HAS_LIBGLES),y)
+MESA3D_HEADERS_DIRS += GLES GLES2
+endif
+
+ifeq ($(BR2_PACKAGE_HAS_LIBOPENVG),y)
+MESA3D_HEADERS_DIRS += VG
+endif
+
+define MESA3D_HEADERS_INSTALL_STAGING_CMDS
+	$(foreach d,$(MESA3D_HEADERS_DIRS),\
+		for h in $(@D)/include/$(d)/*.h; do \
+			$(INSTALL) -D -m 0644 $${h}

$(STAGING_DIR)/usr/include/$(d)/$$(basename $${h}) || exit 1; \

package/mesa3d-headers/mesa3d-headers.mk new file +6 -0

+		done$(sep))
+endef
+
+endif # !mesa3d
+
+$(eval $(generic-package))

package/mesa3d/mesa3d.mk +1 -0

index eb38a9a..ca98524 100644
@@ -4,6 +4,7 @@
 #
 ################################################################################
 
+# When updating the version, please also update mesa3d-headers
 MESA3D_VERSION = 10.4.4
 MESA3D_SOURCE = MesaLib-$(MESA3D_VERSION).tar.bz2
 MESA3D_SITE = ftp://ftp.freedesktop.org/pub/mesa/$(MESA3D_VERSION)

I have done some build tests with the nvidia-tegra packages and opengl support.

I was able to build QT5 with opengl without problem but I get errors with QT4.

This is a known problem of QT4 with the inclusion of eglplatform.h inside which there is an inclusion of X11 headers.

The result is that we have some conflicting #define. For me this can be resolved by adding several #undef at the end of eglplatform.h.

Here is the end of my eglplatform.h header

typedef khronos_int32_t EGLint;

#undef None
#undef KeyPress
#undef KeyRelease
#undef FocusIn
#undef FocusOut
#undef FontChange
#undef CursorShape
#undef Bool
#undef Status
#undef Unsorted
#undef GrayScale
#undef Expose

#endif /* __eglplatform_h */

Nicolas, All,

On 2015-02-11 15:06 +0100, Nicolas Serafini spake thusly:

Quoted 6 lines

I have done some build tests with the nvidia-tegra packages and opengl support.

I was able to build QT5 with opengl without problem but I get errors with QT4.

Quoted 2 lines

This is a known problem of QT4 with the inclusion of eglplatform.h inside which there is an inclusion of X11 headers.

I'm not sure I understand. Is that an known issue because of Buildroot, or is that a known issue that also happens outside Buildroot?

I mean: is that problem caused by Buildroot?

Quoted 21 lines

The result is that we have some conflicting #define. For me this can be resolved by adding several #undef at the end of eglplatform.h.

Here is the end of my eglplatform.h header

typedef khronos_int32_t EGLint;

#undef None
#undef KeyPress
#undef KeyRelease
#undef FocusIn
#undef FocusOut
#undef FontChange
#undef CursorShape
#undef Bool
#undef Status
#undef Unsorted
#undef GrayScale
#undef Expose

Quoted 1 line

#endif /* __eglplatform_h */

Well, I'm not too fond of patching those headers.

I do not completely grok all the inter-relations between X, egl and all the other stuff, so I'd prefer we do not have such hack, especially if the answer to my question aboce is that the issue is not caused by Buildroot.

Regards,
Yann E. MORIN.

Nicolas, All,

On 2015-02-11 15:06 +0100, Nicolas Serafini spake thusly:

Quoted 8 lines

I have done some build tests with the nvidia-tegra packages and opengl support.

I was able to build QT5 with opengl without problem but I get errors with QT4.

This is a known problem of QT4 with the inclusion of eglplatform.h inside which there is an inclusion of X11 headers.

I'm not sure I understand. Is that an known issue because of Buildroot, or is that a known issue that also happens outside Buildroot?

I mean: is that problem caused by Buildroot?

Quoted 20 lines

The result is that we have some conflicting #define. For me this can be resolved by adding several #undef at the end of eglplatform.h.

Here is the end of my eglplatform.h header

typedef khronos_int32_t EGLint;

#undef None
#undef KeyPress
#undef KeyRelease
#undef FocusIn
#undef FocusOut
#undef FontChange
#undef CursorShape
#undef Bool
#undef Status
#undef Unsorted
#undef GrayScale
#undef Expose

Quoted 1 line

#endif /* __eglplatform_h */

Well, I'm not too fond of patching those headers.

I do not completely grok all the inter-relations between X, egl and all the other stuff, so I'd prefer we do not have such hack, especially if the answer to my question aboce is that the issue is not caused by Buildroot.

Some OpenGL/EGL/GLES/VG providers do not provide the corresponding headers, and rely on using "the headers provided by the distribution".

In our case, we can not rely on such headers, because we are not a distribution, and we have no way to provide those headers (not even speaking about relying on the headers provided by hte host distribution, because they might well not be installed at all).

Also, we can not rely on another package to provide those headers, because we can only have one provider enabled in any configuration.

The Khronos group provides such headers, and they are the reference headers, but we can not realy use them:

- most of them are not packaged: they are not versioned and not

    provided in a tarball, but as separately downloadable files;

- those headers are anyway incomplete: there are headers not provided by Khronos, like GL.h

Instead, we rely on mesa3d to provide those headers: mesa3d has all the headers we need.

Modifying the existing mesa3d package would not be easy; we'd have to differentiate whther we need only the headers or the full package. The

meas3d Config.in and .mk are already quite non-trivial that adding such a feature would render them even more illegible.

So, we introduce mea3d-headers as a new package, that is in fact just mesa3d with a much simplified Config.in and .mk, that other OpenXXX providers may select if they do not provide the OpenXXX headers.

Note: we're not installing GLES3 headers, because what Buildroot currently calls libgles is in fact libgles2; we have no way to specify that we have libgles3. So, we just install headers for GLES and GLES2.

Signed-off-by "Yann E. MORIN" <[email protected]>

---
Notes:

It should not be possible to select both mesa3d *and* mesa3d-headers at the same time, but it is difficult to foresee the multiple combinations we may have, due to poor understanding on how binary drivers may behave and what they may require, as well as my own poor understanding of the GL stack(s).

So I decided to just print a warning in that case, and just depend on mesa3d, which would ultimately provide the headers we are interested in anyway. This can be turned into an error if preferred.

package/mesa3d-headers/mesa3d-headers.mk new file +16 -0

+# Only installs header files
+MESA3D_HEADERS_INSTALL_STAGING = YES
+MESA3D_HEADERS_INSTALL_TARGET = NO
+
+MESA3D_HEADERS_DIRS = KHR
+
+ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
+MESA3D_HEADERS_DIRS += GL
+endif
+
+ifeq ($(BR2_PACKAGE_HAS_LIBEGL),y)
+MESA3D_HEADERS_DIRS += EGL
+endif
+
+ifeq ($(BR2_PACKAGE_HAS_LIBGLES),y)
+MESA3D_HEADERS_DIRS += GLES GLES2

Quoted 2 lines

The Khronos group provides such headers, and they are the reference headers, but we can not realy use them:

really

Quoted 2 lines

Modifying the existing mesa3d package would not be easy; we'd have to differentiate whther we need only the headers or the full package. The

whether

Quoted 9 lines

It should not be possible to select both mesa3d *and* mesa3d-headers at the same time, but it is difficult to foresee the multiple combinations we may have, due to poor understanding on how binary drivers may behave and what they may require, as well as my own poor understanding of the GL stack(s).

So I decided to just print a warning in that case, and just depend on mesa3d, which would ultimately provide the headers we are interested in anyway. This can be turned into an error if preferred.

Yes, I believe this should rather be an error. The expected users of mesa3d-headers are proprietary OpenGL implementations, which have normally no reason to co-exist with Mesa3D on a given system. So I'd prefer this to be considered an error, and to not have mesa3d-headers depend on mesa3d when both are enabled.

Quoted 21 lines

package/mesa3d-headers/mesa3d-headers.mk new file +21 -0

+# Only installs header files
+MESA3D_HEADERS_INSTALL_STAGING = YES
+MESA3D_HEADERS_INSTALL_TARGET = NO
+
+MESA3D_HEADERS_DIRS = KHR
+
+ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
+MESA3D_HEADERS_DIRS += GL
+endif
+
+ifeq ($(BR2_PACKAGE_HAS_LIBEGL),y)
+MESA3D_HEADERS_DIRS += EGL
+endif
+
+ifeq ($(BR2_PACKAGE_HAS_LIBGLES),y)
+MESA3D_HEADERS_DIRS += GLES GLES2
+endif
+
+ifeq ($(BR2_PACKAGE_HAS_LIBOPENVG),y)
+MESA3D_HEADERS_DIRS += VG
+endif

package/mesa3d-headers/mesa3d-headers.mk line 54

Quoted 5 lines

package/mesa3d-headers/mesa3d-headers.mk new file +5 -0

+
+define MESA3D_HEADERS_INSTALL_STAGING_CMDS
+	$(foreach d,$(MESA3D_HEADERS_DIRS),\
+		for h in $(@D)/include/$(d)/*.h; do \
+			$(INSTALL) -D -m 0644 $${h} $(STAGING_DIR)/usr/include/$(d)/$$(basename $${h}) || exit 1; \

Instead of doing a for for each header, what about using a plain cp -dpfr like we do in many other packages?

Let me know if you agree with the proposed changes, I can quickly make them while applying if you don't want to respin the entire patch series.

Some OpenGL/EGL/GLES/VG providers do not provide the corresponding headers, and rely on using "the headers provided by the distribution".

In our case, we can not rely on such headers, because we are not a distribution, and we have no way to provide those headers (not even speaking about relying on the headers provided by hte host distribution, because they might well not be installed at all).

Also, we can not rely on another package to provide those headers, because we can only have one provider enabled in any configuration.

The Khronos group provides such headers, and they are the reference headers, but we can not realy use them:

- most of them are not packaged: they are not versioned and not

    provided in a tarball, but as separately downloadable files;

- those headers are anyway incomplete: there are headers not provided by Khronos, like GL.h

Instead, we rely on mesa3d to provide those headers: mesa3d has all the headers we need.

Modifying the existing mesa3d package would not be easy; we'd have to differentiate whther we need only the headers or the full package. The meas3d Config.in and .mk are already quite non-trivial that adding such a feature would render them even more illegible.

So, we introduce mea3d-headers as a new package, that is in fact just mesa3d with a much simplified Config.in and .mk, that other OpenXXX providers may select if they do not provide the OpenXXX headers.

Note: we're not installing GLES3 headers, because what Buildroot currently calls libgles is in fact libgles2; we have no way to specify that we have libgles3. So, we just install headers for GLES and GLES2.

Signed-off-by "Yann E. MORIN" <[email protected]>

Building GL with Xorg requires the DRI interface.

Provide that header and pkg-config file for those binary blobs that do not provide them.

Signed-off-by "Yann E. MORIN" <[email protected]>

Cc J?r?me Pouiller <[email protected]>

Cc Bernd Kuhls <[email protected]>

+ $(INSTALL) -D -m 0644 package/nvidia-driver/gl.pc

Quoted 1 line

+ $(INSTALL) -D -m 0644 package/nvidia-driver/gl.pc

$(STAGING_DIR)/usr/lib/pkgconfig/gl.pc

the nvidia package should not install gl.pc when BR2_PACKAGE_NVIDIA_DRIVER_XORG is not set because in this case nvidia-driver is not a provider for libgl.

Add option to build the nvidia.ko module. If CUDA is enabled on x86_64, also build the nvidia-uvm.ko kernel module (for Unified Memory access), which is required by the CUDA user-land library.

Substancially inspired by the corresponding Gentoo ebuild:

    http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/x11-drivers/nvidia-drivers/nvidia-drivers-340.32.ebuild?revision=1.2&view=markup

Signed-off-by "Yann E. MORIN" <[email protected]>

From: Nicolas Serafini <[email protected]>

This patch adds a new package for all libraries and drivers provided by Nvidia Linux4Tegra release 16.4.0.

We have intermediate .mk and Config.in, because those values will be shared with the codecs package, to come in a follow-up patch, like we have for the Freescale stuff.

Signed-off-by Nicolas Serafini <[email protected]>

[yann.morin.1998 at free.fr:
- split jpeg into its own patch
- split codecs and gstreamer plugins out into their own packages
- do not patch for .pc files, just bundle them in $(@D)
]

Signed-off-by "Yann E. MORIN" <[email protected]>

Cc Ben Ben <[email protected]>

---
Changes v6 -> v7:
- use mesa3d-headers instead of Khronos

---
 package/Config.in                                  |  1 +
 package/nvidia-tegra23/Config.in                   | 36 ++++++++
 .../nvidia-tegra23-binaries/Config.in              | 92
++++++++++++++++++++ .../nvidia-tegra23/nvidia-tegra23-binaries/egl.pc
| 10 +++ .../nvidia-tegra23/nvidia-tegra23-binaries/gles.pc | 10 +++
 .../nvidia-tegra23-binaries/glesv2.pc              | 10 +++
 .../nvidia-tegra23-binaries.hash                   |  3 +
 .../nvidia-tegra23-binaries.mk                     | 98

++++++++++++++++++++++
package/nvidia-tegra23/nvidia-tegra23.mk | 17 ++++ 9 files
changed, 277 insertions(+) create mode 100644 package/nvidia-tegra23/Config.in create mode 100644 package/nvidia-tegra23/nvidia-tegra23-binaries/Config.in create mode 100644 package/nvidia-tegra23/nvidia-tegra23-binaries/egl.pc create mode 100644 package/nvidia-tegra23/nvidia-tegra23-binaries/gles.pc create mode 100644 package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc create mode 100644 package/nvidia-tegra23/nvidia-tegra23-binaries/nvidia-tegra23-binaries.hash create mode 100644 package/nvidia-tegra23/nvidia-tegra23-binaries/nvidia-tegra23-binaries.mk create mode 100644 package/nvidia-tegra23/nvidia-tegra23.mk

package/Config.in +1 -0

index a80cec6..ba28620 100644
@@ -350,6 +350,7 @@ endif
 	source "package/nanocom/Config.in"
 	source "package/neard/Config.in"
 	source "package/nvidia-driver/Config.in"
+	source "package/nvidia-tegra23/Config.in"
 	source "package/ofono/Config.in"
 	source "package/ola/Config.in"
 	source "package/on2-8170-modules/Config.in"

(quoted diff) +0 -0

b/package/nvidia-tegra23/Config.in new file mode 100644 index 0000000..950f2f8

package/nvidia-tegra23/Config.in new file +33 -0

@@ -0,0 +1,36 @@
+menuconfig BR2_PACKAGE_NVIDIA_TEGRA23
+	bool "nvidia-tegra23"
+	depends on BR2_cortex_a9
+	depends on BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_PACKAGE_XORG7
+	help
+	  Install NVidia proprietary blobs to drive Tegra2 or Tegra3
+	  GPUs found in some mobile-targeted ARM SoCs.
+
+if BR2_PACKAGE_NVIDIA_TEGRA23
+
+choice
+	prompt "Tegra platform"
+	help
+	  Select the SOC platform.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_TEGRA2
+	bool "Tegra 2"
+	help
+	  NVIDIA Tegra 2 is a dual-core Cortex-A9 without NEON.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_TEGRA3
+	bool "Tegra 3"
+	depends on BR2_ARM_CPU_HAS_NEON
+	help
+	  NVIDIA Tegra 3 is a quad-core Cortex-A9 with NEON.
+
+endchoice
+
+source "package/nvidia-tegra23/nvidia-tegra23-binaries/Config.in"
+endif
+
+comment "nvidia-tegra23 needs Xorg and a (e)glibc toolchain w/

EABIhf"

package/nvidia-tegra23/Config.in new file +3 -0

+	depends on BR2_cortex_a9
+	depends on !BR2_ARM_EABIHF || !BR2_TOOLCHAIN_USES_GLIBC \
+		|| !BR2_PACKAGE_XORG7

(quoted diff) +0 -0

b/package/nvidia-tegra23/nvidia-tegra23-binaries/Config.in new file mode 100644 index 0000000..1d213d0

package/nvidia-tegra23/nvidia-tegra23-binaries/Config.in new file +11 -0

@@ -0,0 +1,92 @@
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES
+	bool "nvidia-tegra23 binaries"
+	select BR2_PACKAGE_MESA3D_HEADERS
+	select BR2_PACKAGE_XLIB_LIBXT
+	select BR2_PACKAGE_XLIB_LIBXEXT
+	select BR2_PACKAGE_XLIB_LIBXV
+	select BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_HAS_LIBGLES
+	select BR2_PACKAGE_HAS_LIBOPENMAX
+	help
+	  Those packages provide libraries, drivers and firmware

that comes from

package/nvidia-tegra23/nvidia-tegra23-binaries/Config.in new file +81 -0

+	  NVIDIA Linux For Tegra.
+
+	  https://developer.nvidia.com/linux-tegra
+
+if BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES
+
+config BR2_PACKAGE_PROVIDES_LIBEGL
+	default "nvidia-tegra23-binaries"
+
+config BR2_PACKAGE_PROVIDES_LIBGLES
+	default "nvidia-tegra23-binaries"
+
+config BR2_PACKAGE_PROVIDES_LIBOPENMAX
+	default "nvidia-tegra23-binaries"
+
+choice
+	prompt "X11 ABI version"
+	default BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	help
+	  Select Tegra X11 ABI version.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V5
+	bool "X11 ABI 5"
+	help
+	  Tegra X11 ABI 5.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V6
+	bool "X11 ABI 6"
+	help
+	  Tegra X11 ABI 6.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V7
+	bool "X11 ABI 7"
+	help
+	  Tegra X11 ABI 7.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V8
+	bool "X11 ABI 8"
+	help
+	  Tegra X11 ABI 8.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V10
+	bool "X11 ABI 10"
+	help
+	  Tegra X11 ABI 10.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	bool "X11 ABI 11"
+	help
+	  Tegra X11 ABI 11.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V12
+	bool "X11 ABI 12"
+	help
+	  Tegra X11 ABI 12.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V13
+	bool "X11 ABI 13"
+	help
+	  Tegra X11 ABI 13.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V14
+	bool "X11 ABI 14"
+	help
+	  Tegra X11 ABI 14.
+
+endchoice
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI
+	int
+	default 5  if BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V5
+	default 6  if BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V6
+	default 7  if BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V7
+	default 8  if BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V8
+	default 10 if BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V10
+	default 11 if BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	default 12 if BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V12
+	default 13 if BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V13
+	default 14 if BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V14
+
+endif

(quoted diff) +0 -0

b/package/nvidia-tegra23/nvidia-tegra23-binaries/egl.pc new file mode 100644 index 0000000..3af7eec

package/nvidia-tegra23/nvidia-tegra23-binaries/egl.pc new file +10 -0

@@ -0,0 +1,10 @@
+prefix=/usr
+exec_prefix=${prefix}
+libdir=/usr/lib
+includedir=/usr/include
+
+Name: egl
+Description: EGL implementation
+Version: 1
+Cflags: -I${includedir}/EGL
+Libs: -L${libdir} -lEGL

(quoted diff) +0 -0

b/package/nvidia-tegra23/nvidia-tegra23-binaries/gles.pc new file mode 100644 index 0000000..91387c9

package/nvidia-tegra23/nvidia-tegra23-binaries/gles.pc new file +10 -0

@@ -0,0 +1,10 @@
+prefix=/usr
+exec_prefix=${prefix}
+libdir=/usr/lib
+includedir=/usr/include
+
+Name: glesv2
+Description: OpenGL ES 1.1 implementation
+Version: 1.1
+Cflags: -I${includedir}/GLES
+Libs: -L${libdir} -lGLESv1_CM

(quoted diff) +0 -0

b/package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file mode 100644 index 0000000..356a1cb

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +10 -0

@@ -0,0 +1,10 @@
+prefix=/usr
+exec_prefix=${prefix}
+libdir=/usr/lib
+includedir=/usr/include
+
+Name: glesv2
+Description: OpenGL ES 2 implementation
+Version: 2
+Cflags: -I${includedir}/GLESv2
+Libs: -L${libdir} -lGLESv2

diff --git a/package/nvidia-tegra23/nvidia-tegra23-binaries/nvidia-tegra23-binaries.hash b/package/nvidia-tegra23/nvidia-tegra23-binaries/nvidia-tegra23-binaries.hash new file mode 100644 index 0000000..8185593 --- /dev/null
+++
b/package/nvidia-tegra23/nvidia-tegra23-binaries/nvidia-tegra23-binaries.hash

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +0 -0

@@ -0,0 +1,3 @@ +# From

https://developer.nvidia.com/linux-tegra-rel-16 +sha1 6b57b43f8f9c5b76fa3763144e57c0c16047b1a8 Tegra20_Linux_R16.4.0_armhf.tbz2 +sha1 44e7f84dd6e3b80d37ecddf9cc133031b2653004 Tegra30_Linux_R16.4.0_armhf.tbz2 diff --git a/package/nvidia-tegra23/nvidia-tegra23-binaries/nvidia-tegra23-binaries.mk b/package/nvidia-tegra23/nvidia-tegra23-binaries/nvidia-tegra23-binaries.mk new file mode 100644 index 0000000..792cc7c --- /dev/null +++ b/package/nvidia-tegra23/nvidia-tegra23-binaries/nvidia-tegra23-binaries.mk

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +7 -0

@@ -0,0 +1,98 @@
+################################################################################
+# +# nvidia-tegra3-binaries +#
+################################################################################
+
+NVIDIA_TEGRA23_BINARIES_VERSION	= $(NVIDIA_TEGRA23_VERSION)
+NVIDIA_TEGRA23_BINARIES_SITE = $(NVIDIA_TEGRA23_SITE)
+NVIDIA_TEGRA23_BINARIES_SOURCE =

$(NVIDIA_TEGRA23_BASE)_R$(NVIDIA_TEGRA23_BINARIES_VERSION)_armhf.tbz2
+ +NVIDIA_TEGRA23_BINARIES_LICENSE = License For Customer Use of NVIDIA Software +NVIDIA_TEGRA23_BINARIES_LICENSE_FILES = nv_tegra/LICENSE +

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +2 -0

+NVIDIA_TEGRA23_BINARIES_FIRMWARE = \
+	nvrm_avp_0ff00000.bin nvrm_avp_8e000000.bin

nvrm_avp_9e000000.bin \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +1 -0

+	nvrm_avp_be000000.bin nvrm_avp_eff00000.bin

nvavp_vid_ucode_alt.bin \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +5 -0

+	nvavp_os_0ff00000.bin nvavp_os_eff00000.bin
+endif
+
+NVIDIA_TEGRA23_BINARIES_LIBRARIES = \
+	libardrv_dynamic.so libcgdrv.so libEGL.so.1

libGLESv1_CM.so.1 libGLESv2.so.2 \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +2 -0

+	libKD.so libnvapputil.so libnvavp.so libnvcwm.so libnvdc.so \
+	libnvddk_2d.so libnvddk_2d_v2.so libnvddk_disp.so

libnvddk_kbc.so \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +1 -0

+	libnvddk_mipihsi.so libnvddk_nand.so libnvddk_se.so

libnvddk_snor.so \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +1 -0

+	libnvddk_spif.so libnvddk_usbphy.so libnvdispatch_helper.so

libnvglsi.so \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +1 -0

+	libnvmedia_audio.so libnvmm_audio.so libnvmm_camera.so

libnvmm_contentpipe.so \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +1 -0

+	libnvmm_image.so libnvmmlite_audio.so libnvmmlite_image.so

libnvmmlite.so \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +1 -0

+	libnvmmlite_utils.so libnvmmlite_video.so libnvmm_manager.so

libnvmm_parser.so \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +1 -0

+	libnvmm_service.so libnvmm.so libnvmm_utils.so

libnvmm_video.so libnvmm_writer.so \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +1 -0

+	libnvodm_disp.so libnvodm_dtvtuner.so libnvodm_imager.so

libnvodm_misc.so \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +1 -0

+	libnvodm_query.so libnvomxilclient.so libnvomx.so libnvos.so

libnvparser.so \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +1 -0

+	libnvrm_graphics.so libnvrm.so libnvsm.so libnvtestio.so

libnvtestresults.so \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +4 -0

+	libnvtvmr.so libnvwinsys.so libnvwsi.so
+
+NVIDIA_TEGRA23_BINARIES_DRV = \
+

nv_tegra/nvidia_drivers/usr/lib/xorg/modules/drivers/tegra_drv.abi$(BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI).so
+ +NVIDIA_TEGRA23_BINARIES_PKGCONFIG = egl.pc gles.pc glesv2.pc

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +4 -0

+
+define NVIDIA_TEGRA23_BINARIES_EXTRACT_FURTHER
+	$(INSTALL) -d $(@D)/nv_tegra/nvidia_drivers
+	$(call

suitable-extractor,$(@D)/nv_tegra/nvidia_drivers.tbz2) \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +2 -0

+		$(@D)/nv_tegra/nvidia_drivers.tbz2 | \
+	$(TAR) $(TAR_STRIP_COMPONENTS)=0 -C

$(@D)/nv_tegra/nvidia_drivers/ $(TAR_OPTIONS) -

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +2 -0

+	$(INSTALL) -d $(@D)/nv_tegra/nv_sample_apps/nvgstapps
+	$(call

suitable-extractor,$(@D)/nv_tegra/nv_sample_apps/nvgstapps.tbz2) \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +2 -0

+		$(@D)/nv_tegra/nv_sample_apps/nvgstapps.tbz2 | \
+	$(TAR) $(TAR_STRIP_COMPONENTS)=0 -C

$(@D)/nv_tegra/nv_sample_apps/nvgstapps/ $(TAR_OPTIONS) - +endef +NVIDIA_TEGRA23_BINARIES_POST_EXTRACT_HOOKS += NVIDIA_TEGRA23_BINARIES_EXTRACT_FURTHER +

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +3 -0

+define NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS
+	$(foreach lib,$(NVIDIA_TEGRA23_BINARIES_LIBRARIES),
+		$(INSTALL) -D -m 0644

$(@D)/nv_tegra/nvidia_drivers/usr/lib/$(lib) \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +13 -0

+			$(1)/usr/lib/$(lib); \
+	)
+	(cd $(1)/usr/lib; \
+		ln -sf libGLESv2.so.2 libGLESv2.so; \
+		ln -sf libGLESv1_CM.so.1 libGLESv1_CM.so; \
+		ln -sf libEGL.so.1 libEGL.so \
+	)
+endef
+
+define NVIDIA_TEGRA23_BINARIES_INSTALL_STAGING_CMDS
+	$(call NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS,$(STAGING_DIR))
+	$(foreach pkgconfig,$(NVIDIA_TEGRA23_BINARIES_PKGCONFIG),
+		$(INSTALL) -D -m 0644

package/nvidia-tegra23/nvidia-tegra23-binaries/$(pkgconfig) \
+
$(STAGING_DIR)/usr/lib/pkgconfig/$(pkgconfig); \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +7 -0

+	)
+endef
+
+define NVIDIA_TEGRA23_BINARIES_INSTALL_TARGET_CMDS
+	$(call NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS,$(TARGET_DIR))
+	$(foreach firmware,$(NVIDIA_TEGRA23_BINARIES_FIRMWARE),
+		$(INSTALL) -D -m 0644

$(@D)/nv_tegra/nvidia_drivers/lib/firmware/$(firmware) \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +3 -0

+			$(TARGET_DIR)/lib/firmware/$(firmware); \
+	)
+	$(INSTALL) -D -m 0644

$(@D)/nv_tegra/nvidia_drivers/etc/nv_tegra_release \

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +3 -0

+		$(TARGET_DIR)/etc/nv_tegra_release
+	$(INSTALL) -D -m 0644 $(@D)/$(NVIDIA_TEGRA23_BINARIES_DRV) \
+

$(TARGET_DIR)/usr/lib/xorg/modules/drivers/tegra_drv.so +endef

package/nvidia-tegra23/nvidia-tegra23-binaries/glesv2.pc new file +2 -0

+
+$(eval $(generic-package))

(quoted diff) +0 -0

b/package/nvidia-tegra23/nvidia-tegra23.mk new file mode 100644 index 0000000..46a7e04

package/nvidia-tegra23/nvidia-tegra23.mk new file +7 -0

@@ -0,0 +1,17 @@
+################################################################################
+#
+# nvidia-tegra23
+#
+################################################################################
+
+NVIDIA_TEGRA23_SITE =

https://developer.nvidia.com/sites/default/files/akamai/mobile/files/L4T

package/nvidia-tegra23/nvidia-tegra23.mk new file +9 -0

+NVIDIA_TEGRA23_VERSION = 16.4.0 +
+ifeq ($(BR2_PACKAGE_NVIDIA_TEGRA23_TEGRA2),y)
+NVIDIA_TEGRA23_BASE = Tegra20_Linux
+endif
+ifeq ($(BR2_PACKAGE_NVIDIA_TEGRA23_TEGRA3),y)
+NVIDIA_TEGRA23_BASE = Tegra30_Linux
+endif
+
+include $(sort $(wildcard package/nvidia-tegra23/*/*.mk))

Thanks for this new version of the patch. I was in holliday the two previous week, so sorry I have not responded for the previous version of the patch.

I have done some tests and there is only one small bug into the .mk file. The correction is below into the patch.

Quoted 1 line

+ifeq ($(BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_TEGRA2),y)

must be replaced by
ifeq ($(BR2_PACKAGE_NVIDIA_TEGRA23_TEGRA2),y)

package/nvidia-tegra23/nvidia-tegra23-binaries/nvidia-tegra23-binaries.mk line 27

Quoted 5 lines

package/nvidia-tegra23/nvidia-tegra23-binaries/nvidia-tegra23-binaries.mk new file +5 -0

+NVIDIA_TEGRA23_BINARIES_FIRMWARE = \
+	nvrm_avp.bin nvavp_vid_ucode_alt.bin nvavp_os_0ff00000.bin \
+	nvavp_os_eff00000.bin
+endif
+ifeq ($(BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_TEGRA3),y)

must be replaced by
ifeq ($(BR2_PACKAGE_NVIDIA_TEGRA23_TEGRA3),y)

package/nvidia-tegra23/Config.in new file +40 -0

+choice
+	prompt "X11 ABI version"
+	default BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	help
+	  Select Tegra X11 ABI version.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V5
+	bool "X11 ABI 5"
+	help
+	  Tegra X11 ABI 5.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V6
+	bool "X11 ABI 6"
+	help
+	  Tegra X11 ABI 6.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V7
+	bool "X11 ABI 7"
+	help
+	  Tegra X11 ABI 7.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V8
+	bool "X11 ABI 8"
+	help
+	  Tegra X11 ABI 8.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V10
+	bool "X11 ABI 10"
+	help
+	  Tegra X11 ABI 10.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	bool "X11 ABI 11"
+	help
+	  Tegra X11 ABI 11.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V12
+	bool "X11 ABI 12"
+	help
+	  Tegra X11 ABI 12.

+NVIDIA_TEGRA23_BINARIES_VERSION = $(NVIDIA_TEGRA23_VERSION)

package/nvidia-tegra23/Config.in new file +8 -0

+define NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS
+	$(foreach lib,$(NVIDIA_TEGRA23_BINARIES_LIBRARIES),
+		$(INSTALL) -D -m 0644 $(@D)/nv_tegra/nvidia_drivers/usr/lib/$(lib) \
+			$(1)/usr/lib/$(lib); \
+	)
+	(cd $(1)/usr/lib; \
+		ln -sf libGLESv2.so.2 libGLESv2.so; \
+		ln -sf libGLESv1_CM.so.1 libGLESv1_CM.so; \

package/nvidia-tegra23/Config.in line 5

Quoted 12 lines

package/nvidia-tegra23/Config.in new file +5 -0

new file mode 100644
index 0000000..950f2f8
@@ -0,0 +1,36 @@
+menuconfig BR2_PACKAGE_NVIDIA_TEGRA23
+	bool "nvidia-tegra23"
+	depends on BR2_cortex_a9
+	depends on BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_PACKAGE_XORG7

Why is X.org required? Those NVidia drivers provide an EGL implementation, so I would expect them to be usable without X.org, for example if you want to do Qt5 over eglfs. Isn't it the case?

Quoted 45 lines

package/nvidia-tegra23/Config.in new file +45 -0

+choice
+	prompt "X11 ABI version"
+	default BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	help
+	  Select Tegra X11 ABI version.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V5
+	bool "X11 ABI 5"
+	help
+	  Tegra X11 ABI 5.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V6
+	bool "X11 ABI 6"
+	help
+	  Tegra X11 ABI 6.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V7
+	bool "X11 ABI 7"
+	help
+	  Tegra X11 ABI 7.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V8
+	bool "X11 ABI 8"
+	help
+	  Tegra X11 ABI 8.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V10
+	bool "X11 ABI 10"
+	help
+	  Tegra X11 ABI 10.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	bool "X11 ABI 11"
+	help
+	  Tegra X11 ABI 11.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V12
+	bool "X11 ABI 12"
+	help
+	  Tegra X11 ABI 12.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V13
+	bool "X11 ABI 13"
+	help
+	  Tegra X11 ABI 13.

package/nvidia-tegra23/Config.in

Quoted 5 lines

package/nvidia-tegra23/Config.in new file +5 -0

+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V14
+	bool "X11 ABI 14"
+	help
+	  Tegra X11 ABI 14.

Is this choice really useful? In Buildroot, we only support one version of the X.org server at a time, so only one ABI version.

And currently, we have X.org server 1.17.1, which implementation the video driver ABI version 19. How can this work with the Tegra drivers if they only support up to ABI version 14 ?

Quoted 1 line

+NVIDIA_TEGRA23_BINARIES_VERSION = $(NVIDIA_TEGRA23_VERSION)

Spacing issue here.

package/nvidia-tegra23/Config.in

Quoted 8 lines

package/nvidia-tegra23/Config.in new file +8 -0

+NVIDIA_TEGRA23_BINARIES_SITE = $(NVIDIA_TEGRA23_SITE)
+NVIDIA_TEGRA23_BINARIES_SOURCE = $(NVIDIA_TEGRA23_BASE)_R$(NVIDIA_TEGRA23_BINARIES_VERSION)_armhf.tbz2
+
+NVIDIA_TEGRA23_BINARIES_LICENSE = License For Customer Use of NVIDIA Software
+NVIDIA_TEGRA23_BINARIES_LICENSE_FILES = nv_tegra/LICENSE
+
+NVIDIA_TEGRA23_BINARIES_INSTALL_STAGING = YES
+NVIDIA_TEGRA23_BINARIES_INSTALL_TARGET = YES

Last line not needed, it's the default.

package/nvidia-tegra23/Config.in

Quoted 2 lines

package/nvidia-tegra23/Config.in new file +2 -0

+NVIDIA_TEGRA23_BINARIES_DEPENDENCIES = mesa3d-headers \
+	xlib_libX11 xlib_libXext xlib_libXv

A comment above this explaining why even though those are not build dependencies of nvidia-tegra23-binaries they should still be listed in the DEPENDENCIES would be useful.

Quoted 12 lines

package/nvidia-tegra23/Config.in new file +12 -0

+define NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS
+	$(foreach lib,$(NVIDIA_TEGRA23_BINARIES_LIBRARIES),
+		$(INSTALL) -D -m 0644 $(@D)/nv_tegra/nvidia_drivers/usr/lib/$(lib) \
+			$(1)/usr/lib/$(lib); \
+	)
+	(cd $(1)/usr/lib; \
+		ln -sf libGLESv2.so.2 libGLESv2.so; \
+		ln -sf libGLESv1_CM.so.1 libGLESv1_CM.so; \
+		ln -sf libEGL.so.1 libEGL.so \
+	)
+endef
+

package/nvidia-tegra23/Config.in

Quoted 6 lines

package/nvidia-tegra23/Config.in new file +6 -0

+define NVIDIA_TEGRA23_BINARIES_INSTALL_STAGING_CMDS
+	$(call NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS,$(STAGING_DIR))
+	$(foreach pkgconfig,$(NVIDIA_TEGRA23_BINARIES_PKGCONFIG),
+		$(INSTALL) -D -m 0644 package/nvidia-tegra23/nvidia-tegra23-binaries/$(pkgconfig) \
+			$(STAGING_DIR)/usr/lib/pkgconfig/$(pkgconfig); \
+	)

Don't we need a $(sep) here in the foreach loop?

package/nvidia-tegra23/Config.in

Quoted 8 lines

package/nvidia-tegra23/Config.in new file +8 -0

+endef
+
+define NVIDIA_TEGRA23_BINARIES_INSTALL_TARGET_CMDS
+	$(call NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS,$(TARGET_DIR))
+	$(foreach firmware,$(NVIDIA_TEGRA23_BINARIES_FIRMWARE),
+		$(INSTALL) -D -m 0644 $(@D)/nv_tegra/nvidia_drivers/lib/firmware/$(firmware) \
+			$(TARGET_DIR)/lib/firmware/$(firmware); \
+	)

Ditto.

Thomas, Nicolas, All,

On 2015-02-21 23:46 +0100, Thomas Petazzoni spake thusly:

Quoted 17 lines · Yann E. MORIN

package/nvidia-tegra23/Config.in line 5

Quoted 12 lines

(quoted diff) +0 -0

b/package/nvidia-tegra23/Config.in new file mode 100644 index 0000000..950f2f8

package/nvidia-tegra23/Config.in new file +5 -0

@@ -0,0 +1,36 @@
+menuconfig BR2_PACKAGE_NVIDIA_TEGRA23
+	bool "nvidia-tegra23"
+	depends on BR2_cortex_a9
+	depends on BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_PACKAGE_XORG7

Why is X.org required? Those NVidia drivers provide an EGL implementation, so I would expect them to be usable without X.org, for example if you want to do Qt5 over eglfs. Isn't it the case?

I'll let Nicolas reply on that one...

Quoted 46 lines

Quoted 46 lines

package/nvidia-tegra23/Config.in new file +45 -0

+choice
+	prompt "X11 ABI version"
+	default BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	help
+	  Select Tegra X11 ABI version.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V5
+	bool "X11 ABI 5"
+	help
+	  Tegra X11 ABI 5.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V6
+	bool "X11 ABI 6"
+	help
+	  Tegra X11 ABI 6.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V7
+	bool "X11 ABI 7"
+	help
+	  Tegra X11 ABI 7.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V8
+	bool "X11 ABI 8"
+	help
+	  Tegra X11 ABI 8.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V10
+	bool "X11 ABI 10"
+	help
+	  Tegra X11 ABI 10.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	bool "X11 ABI 11"
+	help
+	  Tegra X11 ABI 11.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V12
+	bool "X11 ABI 12"
+	help
+	  Tegra X11 ABI 12.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V13
+	bool "X11 ABI 13"
+	help
+	  Tegra X11 ABI 13.

Quoted 8 lines

package/nvidia-tegra23/Config.in

Quoted 5 lines

package/nvidia-tegra23/Config.in new file +5 -0

+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V14
+	bool "X11 ABI 14"
+	help
+	  Tegra X11 ABI 14.

Is this choice really useful? In Buildroot, we only support one version of the X.org server at a time, so only one ABI version.

Ditto.

Quoted 3 lines

And currently, we have X.org server 1.17.1, which implementation the video driver ABI version 19. How can this work with the Tegra drivers if they only support up to ABI version 14 ?

Ditto.

Quoted 5 lines

Quoted 3 lines

+NVIDIA_TEGRA23_BINARIES_VERSION =
$(NVIDIA_TEGRA23_VERSION)

Spacing issue here.

Sure.

Quoted 10 lines

package/nvidia-tegra23/Config.in

Quoted 8 lines

package/nvidia-tegra23/Config.in new file +2 -0

+NVIDIA_TEGRA23_BINARIES_SITE = $(NVIDIA_TEGRA23_SITE)
+NVIDIA_TEGRA23_BINARIES_SOURCE =

$(NVIDIA_TEGRA23_BASE)_R$(NVIDIA_TEGRA23_BINARIES_VERSION)_armhf.tbz2
+ +NVIDIA_TEGRA23_BINARIES_LICENSE = License For Customer Use of NVIDIA Software +NVIDIA_TEGRA23_BINARIES_LICENSE_FILES = nv_tegra/LICENSE +

package/nvidia-tegra23/Config.in new file +2 -0

+NVIDIA_TEGRA23_BINARIES_INSTALL_STAGING = YES
+NVIDIA_TEGRA23_BINARIES_INSTALL_TARGET = YES

Last line not needed, it's the default.

Indeed, my bad.

Quoted 6 lines

package/nvidia-tegra23/Config.in

Quoted 2 lines

package/nvidia-tegra23/Config.in new file +2 -0

+NVIDIA_TEGRA23_BINARIES_DEPENDENCIES = mesa3d-headers \
+	xlib_libX11 xlib_libXext xlib_libXv

A comment above this explaining why even though those are not build dependencies of nvidia-tegra23-binaries they should still be listed in the DEPENDENCIES would be useful.

Yup, like the one you added in nvidia-x86.

Quoted 16 lines

Quoted 16 lines

package/nvidia-tegra23/Config.in new file +3 -0

+define NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS
+	$(foreach lib,$(NVIDIA_TEGRA23_BINARIES_LIBRARIES),
+		$(INSTALL) -D -m 0644

$(@D)/nv_tegra/nvidia_drivers/usr/lib/$(lib) \

package/nvidia-tegra23/Config.in new file +11 -0

+			$(1)/usr/lib/$(lib); \
+	)
+	(cd $(1)/usr/lib; \
+		ln -sf libGLESv2.so.2 libGLESv2.so; \
+		ln -sf libGLESv1_CM.so.1 libGLESv1_CM.so; \
+		ln -sf libEGL.so.1 libEGL.so \
+	)
+endef
+
+define NVIDIA_TEGRA23_BINARIES_INSTALL_STAGING_CMDS
+	$(call

NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS,$(STAGING_DIR))

Quoted 8 lines

package/nvidia-tegra23/Config.in

Quoted 6 lines

package/nvidia-tegra23/Config.in new file +2 -0

+	$(foreach pkgconfig,$(NVIDIA_TEGRA23_BINARIES_PKGCONFIG),
+		$(INSTALL) -D -m 0644

package/nvidia-tegra23/nvidia-tegra23-binaries/$(pkgconfig) \
+
$(STAGING_DIR)/usr/lib/pkgconfig/$(pkgconfig); \

package/nvidia-tegra23/Config.in new file +1 -0

+	)

Don't we need a $(sep) here in the foreach loop?

Eh, no, because the command ends up with a semi-colon ';', so the whole 'foreach' generates what POSIX calls a 'list' of commands, like:

    foo; bar; buz;

And it is valid to end a (list of) command(s) with a semi-colon.

But maybe, for consistency with all foreach instances, we should be using a $(sep), indeed.

Quoted 4 lines

Quoted 4 lines

package/nvidia-tegra23/Config.in new file +4 -0

+endef
+
+define NVIDIA_TEGRA23_BINARIES_INSTALL_TARGET_CMDS
+	$(call

Quoted 8 lines

package/nvidia-tegra23/Config.in

Quoted 6 lines

NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS,$(TARGET_DIR))

package/nvidia-tegra23/Config.in new file +2 -0

+	$(foreach firmware,$(NVIDIA_TEGRA23_BINARIES_FIRMWARE),
+		$(INSTALL) -D -m 0644

$(@D)/nv_tegra/nvidia_drivers/lib/firmware/$(firmware) \

package/nvidia-tegra23/Config.in new file +2 -0

+			$(TARGET_DIR)/lib/firmware/$(firmware); \
+	)

Ditto.

Ditto.

Regards,
Yann E. MORIN.

Yann, Thomas, All,

Quoted 21 lines · On Sat, 21 Feb 2015 23:58:36 +0100 "Yann E. MORIN" <[email protected]>…

Thomas, Nicolas, All,

On 2015-02-21 23:46 +0100, Thomas Petazzoni spake thusly:

Quoted 17 lines · Yann E. MORIN

package/nvidia-tegra23/Config.in line 5

Quoted 12 lines

(quoted diff) +0 -0

b/package/nvidia-tegra23/Config.in new file mode 100644 index 0000000..950f2f8

package/nvidia-tegra23/Config.in new file +5 -0

@@ -0,0 +1,36 @@
+menuconfig BR2_PACKAGE_NVIDIA_TEGRA23
+	bool "nvidia-tegra23"
+	depends on BR2_cortex_a9
+	depends on BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_PACKAGE_XORG7

Why is X.org required? Those NVidia drivers provide an EGL implementation, so I would expect them to be usable without X.org, for example if you want to do Qt5 over eglfs. Isn't it the case?

Quoted 1 line

I'll let Nicolas reply on that one...

The main problem with all theses Nvidia binaries is that if you take any libraries you have a dependency on X11 libraries.

For exemple I only need gstreamer v4l2 capture, hardware format conversion with libgstnvvidconv and hardware encoding but I have to embed all binaries and X11 due to the dependency tree.

Quoted 61 lines

Quoted 46 lines

Quoted 46 lines

package/nvidia-tegra23/Config.in new file +45 -0

+choice
+	prompt "X11 ABI version"
+	default BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	help
+	  Select Tegra X11 ABI version.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V5
+	bool "X11 ABI 5"
+	help
+	  Tegra X11 ABI 5.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V6
+	bool "X11 ABI 6"
+	help
+	  Tegra X11 ABI 6.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V7
+	bool "X11 ABI 7"
+	help
+	  Tegra X11 ABI 7.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V8
+	bool "X11 ABI 8"
+	help
+	  Tegra X11 ABI 8.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V10
+	bool "X11 ABI 10"
+	help
+	  Tegra X11 ABI 10.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V11
+	bool "X11 ABI 11"
+	help
+	  Tegra X11 ABI 11.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V12
+	bool "X11 ABI 12"
+	help
+	  Tegra X11 ABI 12.
+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V13
+	bool "X11 ABI 13"
+	help
+	  Tegra X11 ABI 13.

Quoted 8 lines

package/nvidia-tegra23/Config.in

Quoted 5 lines

package/nvidia-tegra23/Config.in new file +5 -0

+
+config BR2_PACKAGE_NVIDIA_TEGRA23_BINARIES_X11ABI_V14
+	bool "X11 ABI 14"
+	help
+	  Tegra X11 ABI 14.

Is this choice really useful? In Buildroot, we only support one version of the X.org server at a time, so only one ABI version.

Ditto.

Quoted 3 lines

And currently, we have X.org server 1.17.1, which implementation the video driver ABI version 19. How can this work with the Tegra drivers if they only support up to ABI version 14 ?

Quoted 1 line

Ditto.

You right, I have only tested with an old version (1.14.7) of X.org so this driver won't work with the 1.17.1 version. I don't know if Nvidia will provide new driver with support of latest ABI version. Currently I have no more hardware with display to test the graphics part.

Quoted 77 lines

Quoted 5 lines

Quoted 3 lines

+NVIDIA_TEGRA23_BINARIES_VERSION =
$(NVIDIA_TEGRA23_VERSION)

Spacing issue here.

Sure.

Quoted 10 lines

package/nvidia-tegra23/Config.in

Quoted 8 lines

package/nvidia-tegra23/Config.in new file +2 -0

+NVIDIA_TEGRA23_BINARIES_SITE = $(NVIDIA_TEGRA23_SITE)
+NVIDIA_TEGRA23_BINARIES_SOURCE =

$(NVIDIA_TEGRA23_BASE)_R$(NVIDIA_TEGRA23_BINARIES_VERSION)_armhf.tbz2
+ +NVIDIA_TEGRA23_BINARIES_LICENSE = License For Customer Use of NVIDIA Software +NVIDIA_TEGRA23_BINARIES_LICENSE_FILES = nv_tegra/LICENSE +

package/nvidia-tegra23/Config.in new file +2 -0

+NVIDIA_TEGRA23_BINARIES_INSTALL_STAGING = YES
+NVIDIA_TEGRA23_BINARIES_INSTALL_TARGET = YES

Last line not needed, it's the default.

Indeed, my bad.

Quoted 6 lines

package/nvidia-tegra23/Config.in

Quoted 2 lines

package/nvidia-tegra23/Config.in new file +2 -0

+NVIDIA_TEGRA23_BINARIES_DEPENDENCIES = mesa3d-headers \
+	xlib_libX11 xlib_libXext xlib_libXv

A comment above this explaining why even though those are not build dependencies of nvidia-tegra23-binaries they should still be listed in the DEPENDENCIES would be useful.

Yup, like the one you added in nvidia-x86.

Quoted 16 lines

Quoted 16 lines

package/nvidia-tegra23/Config.in new file +3 -0

+define NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS
+	$(foreach lib,$(NVIDIA_TEGRA23_BINARIES_LIBRARIES),
+		$(INSTALL) -D -m 0644

$(@D)/nv_tegra/nvidia_drivers/usr/lib/$(lib) \

package/nvidia-tegra23/Config.in new file +11 -0

+			$(1)/usr/lib/$(lib); \
+	)
+	(cd $(1)/usr/lib; \
+		ln -sf libGLESv2.so.2 libGLESv2.so; \
+		ln -sf libGLESv1_CM.so.1 libGLESv1_CM.so; \
+		ln -sf libEGL.so.1 libEGL.so \
+	)
+endef
+
+define NVIDIA_TEGRA23_BINARIES_INSTALL_STAGING_CMDS
+	$(call

NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS,$(STAGING_DIR))

Quoted 8 lines

package/nvidia-tegra23/Config.in

Quoted 6 lines

package/nvidia-tegra23/Config.in new file +2 -0

+	$(foreach pkgconfig,$(NVIDIA_TEGRA23_BINARIES_PKGCONFIG),
+		$(INSTALL) -D -m 0644

package/nvidia-tegra23/nvidia-tegra23-binaries/$(pkgconfig) \
+
$(STAGING_DIR)/usr/lib/pkgconfig/$(pkgconfig); \

package/nvidia-tegra23/Config.in new file +1 -0

+	)

Don't we need a $(sep) here in the foreach loop?

Eh, no, because the command ends up with a semi-colon ';', so the whole 'foreach' generates what POSIX calls a 'list' of commands, like:

     foo; bar; buz;

And it is valid to end a (list of) command(s) with a semi-colon.

But maybe, for consistency with all foreach instances, we should be using a $(sep), indeed.

Quoted 12 lines

package/nvidia-tegra23/Config.in

Quoted 10 lines

package/nvidia-tegra23/Config.in new file +4 -0

+endef
+
+define NVIDIA_TEGRA23_BINARIES_INSTALL_TARGET_CMDS
+	$(call

NVIDIA_TEGRA23_BINARIES_INSTALL_LIBS,$(TARGET_DIR))

package/nvidia-tegra23/Config.in new file +2 -0

+	$(foreach firmware,$(NVIDIA_TEGRA23_BINARIES_FIRMWARE),
+		$(INSTALL) -D -m 0644

$(@D)/nv_tegra/nvidia_drivers/lib/firmware/$(firmware) \

package/nvidia-tegra23/Config.in new file +2 -0

+			$(TARGET_DIR)/lib/firmware/$(firmware); \
+	)

Ditto.

Quoted 5 lines

Ditto.

Regards,
Yann E. MORIN.

Quoted 9 lines

Quoted 3 lines

Quoted 3 lines

And currently, we have X.org server 1.17.1, which implementation the video driver ABI version 19. How can this work with the Tegra drivers if they only support up to ABI version 14 ?

You right, I have only tested with an old version (1.14.7) of X.org so this driver won't work with the 1.17.1 version. I don't know if Nvidia will provide new driver with support of latest ABI version. Currently I have no more hardware with display to test the graphics part.

I confirm that video playback works on Tegra 3 using X.org v1.14.7. As far as I know, Nvidia won't release any new version of those drivers for Tegra 2 and Tegra 3 so we'll have to keep using an old version of X.org.

OK, we have the current situation:

- Buildroot uses Xorg 1.17.1, which implements ABI 19;

- nvidia-tegra23 only has support for ABI up to 14;

- NVidia won't update those drivers.

Question: is Xorg ABI backward compatible? I.e. are drivers written for a specific ABI able to work on a newer ABI?

Will an old X.org server build/work fine with recent versions of the X.org libraries around it, so that we only have to change the version of the X.org server

Now the question is: is it possible to offer a version selection for the X.org server ? Will an old X.org server build/work fine with recent versions of the X.org libraries around it, so that we only have to change the version of the X.org server, or will we enter an horrible mess of "if the X.org server is at version <foo>, then we must use version <bar> of this library, and version <foobar> of this other library" ?

Given the feedback from Bernd, I'll see at adding such a version choice.

Let's say we go this route:

- add a version choice for 1.14.7 (for tegra-binaries) and 1.17.1 (the

    current version), defaulting to 17.1;

- add hidden symbols for the driver ABI supported by each version;

- make nvidia-tegra23 depend on the appropriate ABI symbol.

OK?

Quoted 6 lines

Given the feedback from Bernd, I'll see at adding such a version choice. Let's say we go this route:
- add a version choice for 1.14.7 (for tegra-binaries) and 1.17.1 (the

    current version), defaulting to 17.1;

- add hidden symbols for the driver ABI supported by each version;
- make nvidia-tegra23 depend on the appropriate ABI symbol.

Seems OK to me. Though it would be good if someone can actually test the patches. I don't know when I'll have the time to test on the Tegra 3 platform.

Thomas, All,

On 2015-03-07 14:19 +0100, Thomas Petazzoni spake thusly:

Quoted 7 lines · Yann E. MORIN

Quoted 6 lines

Given the feedback from Bernd, I'll see at adding such a version choice. Let's say we go this route:
- add a version choice for 1.14.7 (for tegra-binaries) and 1.17.1 (the

     current version), defaulting to 17.1;

- add hidden symbols for the driver ABI supported by each version;
- make nvidia-tegra23 depend on the appropriate ABI symbol.

Quoted 3 lines

Seems OK to me. Though it would be good if someone can actually test the patches. I don't know when I'll have the time to test on the Tegra 3 platform.

Well, we can at least go up to the point where it builds. From there, you can pick it up when you are available for run-time testing.

Quoted 10 lines

Thomas, All,

On 2015-03-07 14:19 +0100, Thomas Petazzoni spake thusly:

Quoted 7 lines · Yann E. MORIN

Quoted 6 lines

Given the feedback from Bernd, I'll see at adding such a version choice. Let's say we go this route:
- add a version choice for 1.14.7 (for tegra-binaries) and 1.17.1 (the

    current version), defaulting to 17.1;

- add hidden symbols for the driver ABI supported by each version;
- make nvidia-tegra23 depend on the appropriate ABI symbol.

Quoted 5 lines

Quoted 3 lines

Seems OK to me. Though it would be good if someone can actually test the patches. I don't know when I'll have the time to test on the Tegra 3 platform.

Well, we can at least go up to the point where it builds. From there, you can pick it up when you are available for run-time testing.

Sounds good to me too.
I confirm that I am using Buildroot (v2014.08) and that I just hand-picked the version of X.org just like Bernd did and that all X libraries built correctly. Hopefully this is a viable solution without entering the X.org server <-> X libraries dependency nightmare that Thomas mentioned previously.
I hope to find some time to test the patch once it's rolled out.

Laurent, All,

On 2015-03-09 20:25 +0100, Laurent Colloud spake thusly:

Quoted 25 lines · Yann E. MORIN

Quoted 11 lines

Thomas, All,

On 2015-03-07 14:19 +0100, Thomas Petazzoni spake thusly:

Quoted 8 lines · Yann E. MORIN

Quoted 7 lines

Given the feedback from Bernd, I'll see at adding such a version choice. Let's say we go this route:
- add a version choice for 1.14.7 (for tegra-binaries) and
1.17.1 (the current version), defaulting to 17.1;
- add hidden symbols for the driver ABI supported by each
version;
- make nvidia-tegra23 depend on the appropriate ABI symbol.

Quoted 6 lines

Quoted 3 lines

Seems OK to me. Though it would be good if someone can actually test the patches. I don't know when I'll have the time to test on the Tegra 3 platform.

Well, we can at least go up to the point where it builds. From there, you can pick it up when you are available for run-time testing.

Sounds good to me too.
I confirm that I am using Buildroot (v2014.08) and that I just hand-picked the version of X.org just like Bernd did and that all X libraries built correctly. Hopefully this is a viable solution without entering the X.org server <-> X libraries dependency nightmare that Thomas mentioned previously.
I hope to find some time to test the patch once it's rolled out.

I have a series locally that implements just that idea. It's only patches for now, I have to test them.

Hopefully, I can do that by the end of the week. At worse, I have next week off, so I will be able to work on it.

Regards,
Yann E. MORIN.

Also, as far as I understand, the two users of those drivers, Nicolas and Laurent, either no longer have the hardware (and thus do not use the drivers anymore), or are using an old version of Xorg (and presumably, not using Buildroot).

You right, I have only tested with an old version (1.14.7) of X.org so this driver won't work with the 1.17.1 version. I don't know if Nvidia will provide new driver with support of latest ABI version. Currently I have no more hardware with display to test the graphics part.

This series adds support for NVidia's binary blob, the driver to its family of GPUs, for x86 (by Yann) and Tegra2 and Tegra3 (by Nicolas).

Yann E. MORIN (5):
package/python-lxml: new host package

Yegor Yefremov (1):
package/python-lxml: add target variant

package/python-lxml: new host package
package/python-lxml: add target variant