ARM: dts: imx28-apf28dev: Add pinctrl for USB OTG ID pin

PATCH New Gwenhael Goavec-Merou 3 participants 11 messages Feb 13, 2015 – Mar 2, 2015

Subsystems (2)

Device tree bindings Arm i.MX and Layerscape

lore

Share & tools

lore

Gwenhael Goavec-Merou

author

2015-02-13 14:12 UTC #0 lore raw

PATCH 1/5 ARM: dts: imx28-apf28dev: Add pinctrl for USB OTG ID pin

Signed-off-by Gwenhael Goavec-Merou <[email protected]>

Signed-off-by Sebastien Szymanski <[email protected]>

---
 arch/arm/boot/dts/imx28-apf28dev.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

arch/arm/boot/dts/imx28-apf28dev.dts +2 -1

index 1f38a05..86e8d81 100644
@@ -143,7 +143,8 @@
 	ahb at 80080000 {
 		usb0: usb at 80080000 {
 			pinctrl-names = "default";
-			pinctrl-0 = <&usb0_otg_apf28dev>;
+			pinctrl-0 = <&usb0_otg_apf28dev
+					&usb0_id_pins_b>;
 			vbus-supply = <&reg_usb0_vbus>;
 			status = "okay";
 		};

Signature · 1 line

2.0.5

gwenhael.goavec

author

2015-02-27 07:42 UTC #1 lore raw

PATCH 1/5 ARM: dts: imx28-apf28dev: Add pinctrl for USB OTG ID pin

Ping?

Gwen

Quoted 29 lines · On Fri, 13 Feb 2015 15:12:01 +0100 Gwenhael Goavec-Merou…

Signed-off-by Gwenhael Goavec-Merou <[email protected]>

Signed-off-by Sebastien Szymanski <[email protected]>

---
 arch/arm/boot/dts/imx28-apf28dev.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

arch/arm/boot/dts/imx28-apf28dev.dts +2 -1

index 1f38a05..86e8d81 100644
@@ -143,7 +143,8 @@
 	ahb at 80080000 {
 		usb0: usb at 80080000 {
 			pinctrl-names = "default";
-			pinctrl-0 = <&usb0_otg_apf28dev>;
+			pinctrl-0 = <&usb0_otg_apf28dev
+					&usb0_id_pins_b>;
 			vbus-supply = <&reg_usb0_vbus>;
 			status = "okay";
 		};

Signature · 7 lines

2.0.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Gwenhael Goavec-Merou

author

2015-02-13 14:12 UTC #2 lore raw

PATCH 2/5 ARM: dts: imx28-apf28: fix mac0 gpio polarity

In reply to Gwenhael Goavec-Merou

Signed-off-by Gwenhael Goavec-Merou <[email protected]>

Signed-off-by Sebastien Szymanski <[email protected]>

---
 arch/arm/boot/dts/imx28-apf28.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/imx28-apf28.dts +1 -1

index 7198fe3..070e59c 100644
@@ -78,7 +78,7 @@
 			phy-mode = "rmii";
 			pinctrl-names = "default";
 			pinctrl-0 = <&mac0_pins_a>;
-			phy-reset-gpios = <&gpio4 13 0>;
+			phy-reset-gpios = <&gpio4 13 GPIO_ACTIVE_LOW>;
 			status = "okay";
 		};
 	};

Signature · 1 line

2.0.5

Gwenhael Goavec-Merou

author

2015-02-13 14:12 UTC #3 lore raw

PATCH 3/5 ARM: dts: imx28-apf28dev: fix mac1 gpio location and polarity

Signed-off-by Gwenhael Goavec-Merou <[email protected]>

Signed-off-by Sebastien Szymanski <[email protected]>

---
 arch/arm/boot/dts/imx28-apf28dev.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/imx28-apf28dev.dts +1 -1

index 86e8d81..68405c3 100644
@@ -157,7 +157,7 @@
 			phy-mode = "rmii";
 			pinctrl-names = "default";
 			pinctrl-0 = <&mac1_pins_a>;
-			phy-reset-gpios = <&gpio0 23 0>;
+			phy-reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;
 			status = "okay";
 		};
 	};

Signature · 1 line

2.0.5

Gwenhael Goavec-Merou

author

2015-02-13 14:12 UTC #4 lore raw

PATCH 4/5 ARM: dts: imx28-apf28dev: add support for can0

Signed-off-by Gwenhael Goavec-Merou <[email protected]>

Signed-off-by Sebastien Szymanski <[email protected]>

---
 arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

arch/arm/boot/dts/imx28-apf28dev.dts +15 -0

index 68405c3..a052d3e 100644
@@ -110,6 +110,13 @@
 					};
 				};
 			};
+
+			can0: can at 80032000 {
+				pinctrl-names = "default";
+				pinctrl-0 = <&can0_pins_a>;
+				xceiver-supply = <&reg_can0_vcc>;
+				status = "okay";
+			};
 		};
 
 		apbx at 80040000 {

@@ -176,6 +183,14 @@
 			gpio = <&gpio1 23 1>;
 			enable-active-high;
 		};
+
+		reg_can0_vcc: regulator at 1 {
+			compatible = "regulator-fixed";
+			reg = <1>;
+			regulator-name = "can0_vcc";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+		};
 	};
 
 	leds {

Signature · 1 line

2.0.5

Gwenhael Goavec-Merou

author

2015-02-13 14:12 UTC #5 lore raw

PATCH 5/5 ARM: dts: imx28-apf28dev: add support for auart0

Signed-off-by Gwenhael Goavec-Merou <[email protected]>

Signed-off-by Sebastien Szymanski <[email protected]>

---
 arch/arm/boot/dts/imx28-apf28dev.dts | 7 +++++++
 1 file changed, 7 insertions(+)

arch/arm/boot/dts/imx28-apf28dev.dts +7 -0

index a052d3e..81e5f75 100644
@@ -137,6 +137,13 @@
 				status = "okay";
 			};
 
+			auart0: serial at 8006a000 {
+				pinctrl-names = "default";
+				pinctrl-0 = <&auart0_pins_a>;
+				fsl,uart-has-rtscts;
+				status = "okay";
+			};
+
 			usbphy0: usbphy at 8007c000 {
 				status = "okay";
 			};

Signature · 1 line

2.0.5

Lothar Waßmann

2015-02-13 14:53 UTC #6 lore raw

PATCH 4/5 ARM: dts: imx28-apf28dev: add support for can0

In reply to Gwenhael Goavec-Merou

Hi,

Quoted 11 lines · Gwenhael Goavec-Merou

Signed-off-by Gwenhael Goavec-Merou <[email protected]>
Signed-off-by Sebastien Szymanski <[email protected]>
---
 arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm/boot/dts/imx28-apf28dev.dts +0 -0
index 68405c3..a052d3e 100644

arch/arm/boot/dts/imx28-apf28dev.dts line 115

Quoted 6 lines

arch/arm/boot/dts/imx28-apf28dev.dts +2 -0

@@ -110,6 +110,13 @@
 					};
 				};
 			};
+
+			can0: can at 80032000 {

Did you compile-test this? It should produce a build error, since the label can0 already exists in imx28.dtsi.
You should use:

|&can0 {
|				pinctrl-names = "default";
|				pinctrl-0 = <&can0_pins_a>;
|				xceiver-supply = <&reg_can0_vcc>;
|				status = "okay";
|};

arch/arm/boot/dts/imx28-apf28dev.dts line 183

Quoted 2 lines

arch/arm/boot/dts/imx28-apf28dev.dts +0 -0
@@ -176,6 +183,14 @@
 			gpio = <&gpio1 23 1>;

s/ 1/ GPIO_ACTIVE_LOW/ ?

Lothar Wa?mann

Signature · 9 lines

___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________

gwenhael.goavec

author

2015-02-13 15:31 UTC #7 lore raw

PATCH 4/5 ARM: dts: imx28-apf28dev: add support for can0

Hi,

Quoted 9 lines · On Fri, 13 Feb 2015 15:53:58 +0100 Lothar Wa?mann <[email protected]>…

Hi,
Quoted 6 lines · Gwenhael Goavec-Merou
Signed-off-by Gwenhael Goavec-Merou <[email protected]>
Signed-off-by Sebastien Szymanski <[email protected]>
---
 arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Quoted 13 lines

arch/arm/boot/dts/imx28-apf28dev.dts line 115
Quoted 11 lines
arch/arm/boot/dts/imx28-apf28dev.dts +2 -0
index 68405c3..a052d3e 100644
@@ -110,6 +110,13 @@
 					};
 				};
 			};
+
+			can0: can at 80032000 {
 
Did you compile-test this? It should produce a build error, since the label can0 already exists in imx28.dtsi.

Compile fine and without error. It's the same thing for all labels in this dts file.

Quoted 8 lines

You should use:

|&can0 {
|				pinctrl-names = "default";
|				pinctrl-0 = <&can0_pins_a>;
|				xceiver-supply = <&reg_can0_vcc>;
|				status = "okay";
|};

Quoted 4 lines

arch/arm/boot/dts/imx28-apf28dev.dts line 183
Quoted 2 lines
arch/arm/boot/dts/imx28-apf28dev.dts +0 -0
@@ -176,6 +183,14 @@
 			gpio = <&gpio1 23 1>;
s/ 1/ GPIO_ACTIVE_LOW/ ?

This change is out of the context to this patch. This change will be done in other patch.

Quoted 3 lines

Lothar Wa?mann

Gwenhael Goavec-Merou

Lothar Waßmann

2015-02-13 16:59 UTC #8 lore raw

PATCH 4/5 ARM: dts: imx28-apf28dev: add support for can0

Hi,

Quoted 27 lines · gwenhael.goavec

Hi,
Quoted 9 lines · On Fri, 13 Feb 2015 15:53:58 +0100 Lothar Wa?mann <[email protected]>…
Hi,
Quoted 6 lines · Gwenhael Goavec-Merou
Signed-off-by Gwenhael Goavec-Merou <[email protected]>
Signed-off-by Sebastien Szymanski <[email protected]>
---
 arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Quoted 13 lines
arch/arm/boot/dts/imx28-apf28dev.dts line 115
Quoted 11 lines
arch/arm/boot/dts/imx28-apf28dev.dts +2 -0
index 68405c3..a052d3e 100644
@@ -110,6 +110,13 @@
 					};
 				};
 			};
+
+			can0: can at 80032000 {
 
Did you compile-test this? It should produce a build error, since the label can0 already exists in imx28.dtsi.

Quoted 10 lines

Compile fine and without error. It's the same thing for all labels in this dts file.
Quoted 7 lines
You should use:
|&can0 {
|				pinctrl-names = "default";
|				pinctrl-0 = <&can0_pins_a>;
|				xceiver-supply = <&reg_can0_vcc>;
|				status = "okay";
|};

I also noticed now, that defining a label for the same node twice is OK with the dtc-compiler.
But you could simplify your dts files and make them more readable by referencing the existing labels (like all the other platforms do) rather than reproducing the whole tree structrure in your files.

Thus instead of:

|	apb at 80000000 {
|		apbh at 80000000 {
|			gpmi-nand at 8000c000 {
[...]
|		};
|
|		apbx at 80040000 {
|			duart: serial at 80074000 {

[...]

you would only have:

|&duart {
	[...]
|};
|
|&gpmi {
|	[...]
|};

in your dts files.
Sorting the labels alphabetically additionally helps readability.

Lothar Wa?mann

Signature · 9 lines

___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________

gwenhael.goavec

author

2015-02-16 09:59 UTC #9 lore raw

PATCH 4/5 ARM: dts: imx28-apf28dev: add support for can0

Hi,

Quoted 65 lines · On Fri, 13 Feb 2015 17:59:36 +0100 Lothar Wa?mann <[email protected]>…

Hi,
Quoted 27 lines · gwenhael.goavec
Hi,
Quoted 9 lines · On Fri, 13 Feb 2015 15:53:58 +0100 Lothar Wa?mann <[email protected]>…
Hi,
Quoted 6 lines · Gwenhael Goavec-Merou
Signed-off-by Gwenhael Goavec-Merou <[email protected]>
Signed-off-by Sebastien Szymanski <[email protected]>
---
 arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Quoted 13 lines
arch/arm/boot/dts/imx28-apf28dev.dts line 115
Quoted 11 lines
arch/arm/boot/dts/imx28-apf28dev.dts +2 -0
index 68405c3..a052d3e 100644
@@ -110,6 +110,13 @@
 					};
 				};
 			};
+
+			can0: can at 80032000 {
 
Did you compile-test this? It should produce a build error, since the label can0 already exists in imx28.dtsi.
Quoted 10 lines
Compile fine and without error. It's the same thing for all labels in this dts file.
Quoted 7 lines
You should use:
|&can0 {
|				pinctrl-names = "default";
|				pinctrl-0 = <&can0_pins_a>;
|				xceiver-supply = <&reg_can0_vcc>;
|				status = "okay";
|};
I also noticed now, that defining a label for the same node twice is OK with the dtc-compiler.
But you could simplify your dts files and make them more readable by referencing the existing labels (like all the other platforms do) rather than reproducing the whole tree structrure in your files.
Thus instead of:
|	apb at 80000000 {
|		apbh at 80000000 {
|			gpmi-nand at 8000c000 {
[...]
|		};
|
|		apbx at 80040000 {
|			duart: serial at 80074000 {
[...]
you would only have:
|&duart {
	[...]
|};
|
|&gpmi {
|	[...]
|};

Quoted 3 lines

in your dts files.
Sorting the labels alphabetically additionally helps readability.

Yes it's possible but, according to [1], this change does not seem desirable.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/255375.html

Gwenhael Goavec-Merou

Shawn Guo

Applied

2015-03-02 13:36 UTC #10 lore raw

PATCH 1/5 ARM: dts: imx28-apf28dev: Add pinctrl for USB OTG ID pin

In reply to Gwenhael Goavec-Merou

Quoted 2 lines · Gwenhael Goavec-Merou

Signed-off-by Gwenhael Goavec-Merou <[email protected]>
Signed-off-by Sebastien Szymanski <[email protected]>

Applied all 5, thanks.

Quoted 21 lines

---
 arch/arm/boot/dts/imx28-apf28dev.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

arch/arm/boot/dts/imx28-apf28dev.dts +2 -1

index 1f38a05..86e8d81 100644
@@ -143,7 +143,8 @@
 	ahb at 80080000 {
 		usb0: usb at 80080000 {
 			pinctrl-names = "default";
-			pinctrl-0 = <&usb0_otg_apf28dev>;
+			pinctrl-0 = <&usb0_otg_apf28dev
+					&usb0_id_pins_b>;
 			vbus-supply = <&reg_usb0_vbus>;
 			status = "okay";
 		};

Signature · 1 line

2.0.5