Skip to contentSkip to conversation

gcc: 4.9.2: Add patch to remove a wrong header

PATCH New Ezequiel Garcia 3 participants 4 messages Feb 11, 2015 – Feb 14, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc: 4.9.2: Add patch to remove a wrong header

This commit adds a patch to gcc removing a unistd.h header include in libgcc/config/nios2/linux-atomic.c

The file is built as part of GCC first stage (host-gcc-initial), and so the header is not accesible. Given the header is not needed it's fine to simply remove it.

Chung-Lin Tang (GCC nios2 maintainer) confirmed patch is good:
""
Thanks for noticing, this part appears to be unneeded now that Nios II uses a kernel provided user function for Linux atomic operations. I'll remove the include, and the #define's as well in upstream GCC. ""

This commit is required to build a Nios-II internal toolchain.

---
 package/gcc/4.9.2/920-libgcc-remove-unistd-header.patch | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 package/gcc/4.9.2/920-libgcc-remove-unistd-header.patch
package/gcc/4.9.2/920-libgcc-remove-unistd-header.patch new file +12 -0
new file mode 100644
index 0000000..df5372b
@@ -0,0 +1,12 @@
+Upstream status: In progress
+
+--- a/libgcc/config/nios2/linux-atomic.c
++++ b/libgcc/config/nios2/linux-atomic.c
+@@ -20,7 +20,6 @@
+ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
+ <http://www.gnu.org/licenses/>.  */
+ 
+-#include <asm/unistd.h>
+ #define EFAULT  14
+ #define EBUSY   16
+ #define ENOSYS  38
Signature · 1 line
2.2.1
#1 lore raw

PATCH 1/1 gcc: 4.9.2: Add patch to remove a wrong header

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ezequiel" == Ezequiel Garcia <[email protected]> writes:

This commit adds a patch to gcc removing a unistd.h header include in libgcc/config/nios2/linux-atomic.c

The file is built as part of GCC first stage (host-gcc-initial), and so the header is not accesible. Given the header is not needed it's fine to simply remove it.

Quoted 8 lines

Chung-Lin Tang (GCC nios2 maintainer) confirmed patch is good:
""
Thanks for noticing, this part appears to be unneeded now that Nios II uses a kernel provided user function for Linux atomic operations. I'll remove the include, and the #define's as well in upstream GCC. ""

This commit is required to build a Nios-II internal toolchain.

I'll wait with this until you post the patches to actually build an internal nios2 toolchain, ok?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 gcc: 4.9.2: Add patch to remove a wrong header

Peter, Ezequiel,

Quoted 2 lines · Peter Korsgaard

I'll wait with this until you post the patches to actually build an internal nios2 toolchain, ok?

I have consequently marked this patch as Rejected in patchwork. Ezequiel, please include it with the rest of the series adding NIOS II support to the internal toolchain backend. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 gcc: 4.9.2: Add patch to remove a wrong header

Quoted 11 lines · Thomas Petazzoni

Peter, Ezequiel,

Quoted 2 lines · Peter Korsgaard

I'll wait with this until you post the patches to actually build an internal nios2 toolchain, ok?

I have consequently marked this patch as Rejected in patchwork. Ezequiel, please include it with the rest of the series adding NIOS II support to the internal toolchain backend. Thanks!

Sure, I will.

Signature · 2 lines
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar