Skip to contentSkip to conversation

Test xfs/106 failure

DISCUSSION Jan Kara 3 participants 5 messages Feb 17, 2015 – Feb 18, 2015

lore
Share & tools
lore

Jan Kara

author
#0 lore raw

Hello,

I'm consistently getting failure in xfs/106 test because the files
created by fsstress are just completely different from what they are expected to be. It almost seems as if the random numbers generated for fsstress are different. Anyone has seen this as well?

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#1 lore raw
Quoted 6 lines · Jan Kara

Hello,

I'm consistently getting failure in xfs/106 test because the files
created by fsstress are just completely different from what they are expected to be. It almost seems as if the random numbers generated for fsstress are different. Anyone has seen this as well?

If it's not in the auto group, then it's not expected to function as a reliable regression test. There are few tests around the xfs/100 to xfs/130 that fall into this category. Some were tests that were never completed, others were simply a method of exercising the functionality and not intended to have deterministic output and hence "always fail".

given the amount of commented out functionality and comments like "# not yet working properly?" in xfs/106 leads me to beleive it falls into the former category of "unfinished".

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#2 lore raw
In reply to Jan Kara

Hi Jan,

Quoted 5 lines · Jan Kara

Hello,
I'm consistently getting failure in xfs/106 test because the files
created by fsstress are just completely different from what they are expected to be. It almost seems as if the random numbers generated for fsstress are different. Anyone has seen this as well?

That reminds me of a bug that has occurred every time when I run xfs/106. The crash happens only with CONFIG_XFS_DEBUG enabled.
When I first discovered that, I disabled CONFIG_XFS_DEBUG as a workaround. As far as I remember, it started to occur since 3.19-rc?, and the first bad commit was 14bf61ffe6ac ("quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units"). I just tested it again with linux-block.git/for-3.20/drivers. The bug is still there.

Cheers,
Dongsu

====
XFS (vdc1): Quotacheck: Done.
XFS: Assertion failed: dst->d_spc_timer != 0, file: fs/xfs/xfs_qm_syscalls.c, line: 893

------------[ cut here ]------------
kernel BUG at fs/xfs/xfs_message.c:106!
invalid opcode: 0000 [#1] SMP 
CPU: 0 PID: 4031 Comm: xfs_quota Tainted: G        W      3.19.0-rc7+ #174
RIP: 0010:[<ffffffff813a9202>]  [<ffffffff813a9202>] assfail+0x22/0x30
Call Trace:
 [<ffffffff813d4de4>] xfs_qm_scall_getquota+0x284/0x330
 [<ffffffff813dce08>] xfs_fs_get_dqblk+0x68/0x90
 [<ffffffff81292b6f>] quota_getxquota+0x6f/0x200
 [<ffffffff812931cc>] SyS_quotactl+0x4cc/0x740
 [<ffffffff817f4cf7>] ? sysret_check+0x1b/0x56
 [<ffffffff8151aa1b>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff817f4cd2>] system_call_fastpath+0x12/0x17
RIP [<ffffffff813a9202>] assfail+0x22/0x30
 RSP <ffff88007a9e7d08>
---[ end trace 308df0cc6a9ba1d0 ]---

====

Quoted 9 lines

Honza

Signature · 6 lines
Jan Kara <[email protected]>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author
#3 lore raw
Quoted 9 lines · Dongsu Park

Hi Jan,

Quoted 5 lines · Jan Kara

Hello,
I'm consistently getting failure in xfs/106 test because the files
created by fsstress are just completely different from what they are expected to be. It almost seems as if the random numbers generated for fsstress are different. Anyone has seen this as well?

Quoted 7 lines

That reminds me of a bug that has occurred every time when I run xfs/106. The crash happens only with CONFIG_XFS_DEBUG enabled.
When I first discovered that, I disabled CONFIG_XFS_DEBUG as a workaround. As far as I remember, it started to occur since 3.19-rc?, and the first bad commit was 14bf61ffe6ac ("quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units"). I just tested it again with linux-block.git/for-3.20/drivers. The bug is still there.

Yesterday, I've sent a patch which should fix this
(http://www.spinics.net/lists/stable/msg79800.html). Above commit just uncovered a long standing problem in XFS quota implementation...

Honza

Quoted 30 lines

====
XFS (vdc1): Quotacheck: Done.
XFS: Assertion failed: dst->d_spc_timer != 0, file: fs/xfs/xfs_qm_syscalls.c, line: 893

------------[ cut here ]------------
kernel BUG at fs/xfs/xfs_message.c:106!
invalid opcode: 0000 [#1] SMP 
CPU: 0 PID: 4031 Comm: xfs_quota Tainted: G        W      3.19.0-rc7+ #174
RIP: 0010:[<ffffffff813a9202>]  [<ffffffff813a9202>] assfail+0x22/0x30
Call Trace:
 [<ffffffff813d4de4>] xfs_qm_scall_getquota+0x284/0x330
 [<ffffffff813dce08>] xfs_fs_get_dqblk+0x68/0x90
 [<ffffffff81292b6f>] quota_getxquota+0x6f/0x200
 [<ffffffff812931cc>] SyS_quotactl+0x4cc/0x740
 [<ffffffff817f4cf7>] ? sysret_check+0x1b/0x56
 [<ffffffff8151aa1b>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff817f4cd2>] system_call_fastpath+0x12/0x17
RIP [<ffffffff813a9202>] assfail+0x22/0x30
 RSP <ffff88007a9e7d08>
---[ end trace 308df0cc6a9ba1d0 ]---

====

Quoted 9 lines

Honza

Signature · 6 lines
Jan Kara <[email protected]>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#4 lore raw
Quoted 11 lines · Jan Kara
Quoted 7 lines · Dongsu Park

That reminds me of a bug that has occurred every time when I run xfs/106. The crash happens only with CONFIG_XFS_DEBUG enabled.
When I first discovered that, I disabled CONFIG_XFS_DEBUG as a workaround. As far as I remember, it started to occur since 3.19-rc?, and the first bad commit was 14bf61ffe6ac ("quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units"). I just tested it again with linux-block.git/for-3.20/drivers. The bug is still there.

Yesterday, I've sent a patch which should fix this
(http://www.spinics.net/lists/stable/msg79800.html). Above commit just uncovered a long standing problem in XFS quota implementation...

Aha, great. With that patch applied, the crash is gone. :-)

Thanks,
Dongsu

Quoted 35 lines

Honza

Quoted 30 lines

====
XFS (vdc1): Quotacheck: Done.
XFS: Assertion failed: dst->d_spc_timer != 0, file: fs/xfs/xfs_qm_syscalls.c, line: 893

------------[ cut here ]------------
kernel BUG at fs/xfs/xfs_message.c:106!
invalid opcode: 0000 [#1] SMP 
CPU: 0 PID: 4031 Comm: xfs_quota Tainted: G        W      3.19.0-rc7+ #174
RIP: 0010:[<ffffffff813a9202>]  [<ffffffff813a9202>] assfail+0x22/0x30
Call Trace:
 [<ffffffff813d4de4>] xfs_qm_scall_getquota+0x284/0x330
 [<ffffffff813dce08>] xfs_fs_get_dqblk+0x68/0x90
 [<ffffffff81292b6f>] quota_getxquota+0x6f/0x200
 [<ffffffff812931cc>] SyS_quotactl+0x4cc/0x740
 [<ffffffff817f4cf7>] ? sysret_check+0x1b/0x56
 [<ffffffff8151aa1b>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff817f4cd2>] system_call_fastpath+0x12/0x17
RIP [<ffffffff813a9202>] assfail+0x22/0x30
 RSP <ffff88007a9e7d08>
---[ end trace 308df0cc6a9ba1d0 ]---

====

Quoted 9 lines

Honza

Signature · 6 lines
Jan Kara <[email protected]>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR