Staging: i2o: Remove space after the * in a pointer type variable.
PATCH v3 1/1 Staging: i2o: Remove space after the * in a pointer type variable.
This patch is to remove space after the * in a pointer type variable declaration to follow kernel coding conventions.
---
Changes in v3: Moved changelog below to "---" line. Changes in v2: Changed subject line to make it more descriptive.
drivers/staging/i2o/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/i2o/debug.c +1 -1
@@ -5,7 +5,7 @@static void i2o_report_util_cmd (u8 cmd);static void i2o_report_exec_cmd (u8 cmd); -static void i2o_report_fail_status (u8 req_status,u32 * msg); +static void i2o_report_fail_status (u8 req_status,u32 *msg);static void i2o_report_common_status (u8 req_status);static void i2o_report_common_dsc (u16 detailed_status);
Signature · 1 line
1.9.1
Hi Vatika,
Quoted 1 line · Vatika Harlalka
This patch is to remove space after the * in a pointer type variable declaration to follow kernel coding conventions.
You may have noticed that a limit of 80 characters is imposed in the kernel coding style. It would be good to follow the same in the changelog as well. So the patch looks is uniformly aligned throughout.
Quoted 15 lines
Signed-off-by Vatika Harlalka <[email protected]>---
Changes in v3: Moved changelog below to "---" line. Changes in v2: Changed subject line to make it more descriptive.
drivers/staging/i2o/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/i2o/debug.c +0
-0
drivers/staging/i2o/debug.c line 8
Quoted 5 lines
drivers/staging/i2o/debug.c +1
-1@@ -5,7 +5,7 @@static void i2o_report_util_cmd (u8 cmd);static void i2o_report_exec_cmd (u8 cmd); -static void i2o_report_fail_status (u8 req_status,u32 * msg); +static void i2o_report_fail_status (u8 req_status,u32 *msg);
I see that the definition of this function suffers from the same issue down below in the file. You may want to correct that as well and club both the changes in one patch.
drivers/staging/i2o/debug.c line 11
Quoted 3 lines
drivers/staging/i2o/debug.c +0
-0static void i2o_report_common_status (u8 req_status);static void i2o_report_common_dsc (u16 detailed_status);
Regards
Preeti U Murthy