Skip to contentSkip to conversation

x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c

PATCH Ingo Molnar 1 participant 2 messages Feb 18, 2015 1 message not in the archive PCI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 7 lines · Nicholas Krause

This changes the structure sta2x11_dma_ops stucture to use switolb_dma_supported as it's function for dma_supported hardware verus setting this value to NULL as this should be set correctly for when dma_supported function needs to be called for this hardware. Otherwise this will cause a bug that will crash a operation needing to access this function if an intended hardware operation needs to call it but the kernel has the function pointer for this structure set to NULL incorrectly.

Hm, I have asked a question for the v1 patch already:

https://lkml.org/lkml/2015/2/16/30

is there an answer to my question?

Thanks,

Ingo

#2 lore raw
Quoted 11 lines · Ingo Molnar
Quoted 7 lines · Nicholas Krause

This changes the structure sta2x11_dma_ops stucture to use switolb_dma_supported as it's function for dma_supported hardware verus setting this value to NULL as this should be set correctly for when dma_supported function needs to be called for this hardware. Otherwise this will cause a bug that will crash a operation needing to access this function if an intended hardware operation needs to call it but the kernel has the function pointer for this structure set to NULL incorrectly.

Quoted 5 lines

Hm, I have asked a question for the v1 patch already:

https://lkml.org/lkml/2015/2/16/30

is there an answer to my question?

Ok, found your reply meanwhile - somehow lkml didn't index the thread properly :-/

Thanks,

Ingo