staging: comedi: drivers: replace init_timer by setup_timer
PATCH v3 1/1 staging: comedi: drivers: replace init_timer by setup_timer
This patch replaces init_timer and 2 step initialization of function and data by setup_timer to make the code more concise.
The issue was discovered using the following coccinelle script:
@@
expression ds, e1, e2;
@@
-init_timer (&ds);
+setup_timer (&ds, e1, e2);
...
-ds.function = e1;
...
-ds.data = e2;
Acked-by Julia Lawall <[email protected]>
Signed-off-by Aya Mahfouz <[email protected]>
--- drivers/staging/comedi/drivers/comedi_test.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/comedi_test.c +2 -3
@@ -420,9 +420,8 @@ static int waveform_attach(struct comedi_device *dev,for (i =0 ; i < s->n_chan; i++) devpriv->ao_loopbacks[i] = s->maxdata /2 ; -init_timer (&devpriv->timer); - devpriv->timer.function = waveform_ai_interrupt; - devpriv->timer.data = (unsigned long )dev; +setup_timer (&devpriv->timer, waveform_ai_interrupt, + (unsigned long )dev); dev_info(dev->class_dev, "%s: %i microvolt, %li microsecond waveform attached\n",
Signature · 1 line
1.9.3
You need to say, eiter in a cover letter or in the patch below the ---, what the difference as compared to v2 is.
julia
Quoted 49 lines · Aya Mahfouz
This patch replaces
init_timerand 2 step initialization of function and data bysetup_timerto make the code more concise.The issue was discovered using the following coccinelle script:
@@
expression ds, e1, e2;
@@(quoted diff) +1
-3-init_timer (&ds); +setup_timer (&ds, e1, e2); -ds.function = e1; -ds.data = e2;Acked-by Julia Lawall <[email protected]>Signed-off-by Aya Mahfouz <[email protected]>--- drivers/staging/comedi/drivers/comedi_test.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/comedi/drivers/comedi_test.c +2
-3@@ -420,9 +420,8 @@ static int waveform_attach(struct comedi_device *dev,for (i =0 ; i < s->n_chan; i++) devpriv->ao_loopbacks[i] = s->maxdata /2 ; -init_timer (&devpriv->timer); - devpriv->timer.function = waveform_ai_interrupt; - devpriv->timer.data = (unsigned long )dev; +setup_timer (&devpriv->timer, waveform_ai_interrupt, + (unsigned long )dev); dev_info(dev->class_dev, "%s: %i microvolt, %li microsecond waveform attached\n",Signature · 8 lines
1.9.3 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150219000733.GA14360%40localhost.localdomain. For more options, visit https://groups.google.com/d/optout.