Skip to contentSkip to conversation

ARM: shmobile: r8a7790: Fix HSUSB clock to hp_clk from mp_clk

PATCH New Simon Horman 3 participants 4 messages Feb 19, 2015 – Feb 25, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: shmobile: r8a7790: Fix HSUSB clock to hp_clk from mp_clk

From: Kazuya Mizuguchi <[email protected]>

HSUSB uses hp_clk rather than mp_clk for H/W register access.

---
v2 [Simon Horman]
- Updated changelog to remove information about USB-DMAC clock which did not relate to the patch. I will follow up on weather the USB-DMAC clock should be mp_clk as the deleted portion of the changelog stated.

---
 arch/arm/boot/dts/r8a7790.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/r8a7790.dtsi +2 -1
index 24de994..113edf2 100644
@@ -1,6 +1,7 @@
 /*
  * Device Tree Source for the r8a7790 SoC
  *
+ * Copyright (C) 2015 Renesas Electronics Corporation
  * Copyright (C) 2013-2014 Renesas Solutions Corp.
  * Copyright (C) 2014 Cogent Embedded Inc.
  *
@@ -1132,7 +1133,7 @@
 		mstp7_clks: mstp7_clks at e615014c {
 			compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
-			clocks = <&mp_clk>, <&mp_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
+			clocks = <&mp_clk>, <&hp_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
 				 <&p_clk>, <&zx_clk>, <&zx_clk>, <&zx_clk>, <&zx_clk>,
 				 <&zx_clk>;
 			#clock-cells = <1>;
Signature · 1 line
2.1.4
#1 lore raw

PATCH v2 1/1 ARM: shmobile: r8a7790: Fix HSUSB clock to hp_clk from mp_clk

Hello.

Quoted 9 lines · Simon Horman

From: Kazuya Mizuguchi <[email protected]>

HSUSB uses hp_clk rather than mp_clk for H/W register access.

Quoted 4 lines

---
v2 [Simon Horman]
- Updated changelog to remove information about USB-DMAC clock which did not relate to the patch. I will follow up on weather the

s/weather/whether/.

Quoted 11 lines

USB-DMAC clock should be mp_clk as the deleted portion of the changelog stated.

---
  arch/arm/boot/dts/r8a7790.dtsi | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/r8a7790.dtsi +0 -0
index 24de994..113edf2 100644

arch/arm/boot/dts/r8a7790.dtsi line 4

Quoted 4 lines
arch/arm/boot/dts/r8a7790.dtsi +1 -0
@@ -1,6 +1,7 @@
  /*
   * Device Tree Source for the r8a7790 SoC
   *
+ * Copyright (C) 2015 Renesas Electronics Corporation

One-liner is hardly enough for the copyright claim. Greg KH even used to
say that roughly a third part of a file changed was worth it, IIRC.

arch/arm/boot/dts/r8a7790.dtsi line 1139

Quoted 12 lines
arch/arm/boot/dts/r8a7790.dtsi +1 -1
   * Copyright (C) 2013-2014 Renesas Solutions Corp.
   * Copyright (C) 2014 Cogent Embedded Inc.
   *
@@ -1132,7 +1133,7 @@
  		mstp7_clks: mstp7_clks at e615014c {
  			compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
  			reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
-			clocks = <&mp_clk>, <&mp_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
+			clocks = <&mp_clk>, <&hp_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
  				 <&p_clk>, <&zx_clk>, <&zx_clk>, <&zx_clk>, <&zx_clk>,
  				 <&zx_clk>;
  			#clock-cells = <1>;

WBR, Sergei

#2 lore raw

PATCH v2 1/1 ARM: shmobile: r8a7790: Fix HSUSB clock to hp_clk from mp_clk

Quoted 26 lines · Sergei Shtylyov

Hello.

Quoted 9 lines · Simon Horman

From: Kazuya Mizuguchi <[email protected]>

HSUSB uses hp_clk rather than mp_clk for H/W register access.

Quoted 4 lines

---
v2 [Simon Horman]
- Updated changelog to remove information about USB-DMAC clock which did not relate to the patch. I will follow up on weather the

s/weather/whether/.

Quoted 5 lines

USB-DMAC clock should be mp_clk as the deleted portion of the changelog stated.

---
 arch/arm/boot/dts/r8a7790.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 12 lines

arch/arm/boot/dts/r8a7790.dtsi line 4

Quoted 9 lines
arch/arm/boot/dts/r8a7790.dtsi +1 -0
index 24de994..113edf2 100644
@@ -1,6 +1,7 @@
 /*
  * Device Tree Source for the r8a7790 SoC
  *
+ * Copyright (C) 2015 Renesas Electronics Corporation

One-liner is hardly enough for the copyright claim. Greg KH even used to
say that roughly a third part of a file changed was worth it, IIRC.

I don't want to split hairs but I'm pretty sure the copyright claim extends to more than the one line change below.

Quoted 20 lines

arch/arm/boot/dts/r8a7790.dtsi line 1139

Quoted 12 lines
arch/arm/boot/dts/r8a7790.dtsi +1 -1
  * Copyright (C) 2013-2014 Renesas Solutions Corp.
  * Copyright (C) 2014 Cogent Embedded Inc.
  *
@@ -1132,7 +1133,7 @@
 		mstp7_clks: mstp7_clks at e615014c {
 			compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
-			clocks = <&mp_clk>, <&mp_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
+			clocks = <&mp_clk>, <&hp_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
 				 <&p_clk>, <&zx_clk>, <&zx_clk>, <&zx_clk>, <&zx_clk>,
 				 <&zx_clk>;
 			#clock-cells = <1>;

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html