Skip to contentSkip to conversation

toolchain-external: clarify external toolchain description

PATCH New Baruch Siach 2 participants 4 messages Feb 17, 2015 – Feb 20, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain-external: clarify external toolchain description

External toolchain can also have been generated by Buildroot previously, as the list that follows demonstrates. Add the word 'locally' at the right place to make the point clearer.

---
 toolchain/toolchain-external/toolchain-external.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
toolchain/toolchain-external/toolchain-external.mk +3 -3
index 5a69eb88958e..4376c8ddbf1f 100644
@@ -6,9 +6,9 @@
 
 #
 # This package implements the support for external toolchains, i.e
-# toolchains that have not been produced by Buildroot itself and that
-# Buildroot can download from the Web or that are already available on
-# the system on which Buildroot runs. So far, we have tested this
+# toolchains that have not been produced locally by Buildroot itself and
+# that Buildroot can download from the Web or that are already available
+# on the system on which Buildroot runs. So far, we have tested this
 # with:
 #
 #  * Toolchains generated by Crosstool-NG
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 toolchain-external: clarify external toolchain description

Dear Baruch Siach,

toolchain/toolchain-external/toolchain-external.mk line 9

Quoted 5 lines · Baruch Siach

# This package implements the support for external toolchains, i.e

toolchain/toolchain-external/toolchain-external.mk +1 -3
-# toolchains that have not been produced by Buildroot itself and that
-# Buildroot can download from the Web or that are already available on
-# the system on which Buildroot runs. So far, we have tested this
+# toolchains that have not been produced locally by Buildroot itself and

I am not sure adding "locally" makes the thing clearer: you can very well produce a toolchain with Buildroot "locally", and then re-use it in a later Buildroot build as an external toolchain on the same machine.

Maybe we should simply rephrase this as:

This package implements the support for external toolchains, i.e toolchains that are available pre-built, ready to use. Such toolchain me either be readily available on the Web (Linaro, Sourcery CodeBench, from processor vendors) or may be built with tools like Crosstool-NG or Buildroot itself.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 toolchain-external: clarify external toolchain description

Hi Thomas,

Quoted 11 lines · Thomas Petazzoni

toolchain/toolchain-external/toolchain-external.mk line 9

Quoted 5 lines · Baruch Siach

# This package implements the support for external toolchains, i.e

toolchain/toolchain-external/toolchain-external.mk +1 -3
-# toolchains that have not been produced by Buildroot itself and that
-# Buildroot can download from the Web or that are already available on
-# the system on which Buildroot runs. So far, we have tested this
+# toolchains that have not been produced locally by Buildroot itself and

I am not sure adding "locally" makes the thing clearer: you can very well produce a toolchain with Buildroot "locally", and then re-use it in a later Buildroot build as an external toolchain on the same machine.

Quoted 5 lines

Maybe we should simply rephrase this as:

This package implements the support for external toolchains, i.e toolchains that are available pre-built, ready to use. Such toolchain me either be readily available on the Web (Linaro, Sourcery

s/me/may/

Quoted 2 lines

CodeBench, from processor vendors) or may be built with tools like Crosstool-NG or Buildroot itself.

Looks good to me. Would you like me to send a patch?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#3 lore raw

PATCH 1/1 toolchain-external: clarify external toolchain description

Dear Baruch Siach,

Quoted 4 lines · Baruch Siach
Quoted 2 lines

CodeBench, from processor vendors) or may be built with tools like Crosstool-NG or Buildroot itself.

Looks good to me. Would you like me to send a patch?

Yes, please :)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com