sunxi: Fix sun5i mbus speed when booting old kernels
Subsystems (2)
PATCH 1/1 sunxi: Fix sun5i mbus speed when booting old kernels
Older linux-sunxi-3.4 kernels override our PLL6 setting with 300 MHz, halving the mbus frequency, so set it to 300 MHz ourselves and base the mbus divider on that.
--- arch/arm/include/asm/arch-sunxi/clock_sun4i.h | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm/include/asm/arch-sunxi/clock_sun4i.h +9 -0
@@ -144,7 +144,16 @@ struct sunxi_ccm_reg {#define PLL1_CFG_DEFAULT 0xa1005000 +#if definedCONFIG_OLD_SUNXI_KERNEL_COMPAT && definedCONFIG_MACH_SUN5I +/* +* Older linux-sunxi-3.4 kernels override our PLL6 setting with 300 MHz, +* halving the mbus frequency, so set it to 300 MHz ourselves and base the +* mbus divider on that. +*/ +#define PLL6_CFG_DEFAULT 0xa1009900 +#else #define PLL6_CFG_DEFAULT 0xa1009911 +#endif /* nand clock */ #define NAND_CLK_SRC_OSC24 0
Signature · 1 line
2.1.0
PATCH 1/1 sunxi: Fix sun5i mbus speed when booting old kernels
Quoted 5 lines · Hans de Goede
Older linux-sunxi-3.4 kernels override our PLL6 setting with 300 MHz, halving the mbus frequency, so set it to 300 MHz ourselves and base the mbus divider on that.
Signed-off-by Hans de Goede <[email protected]>
PATCH 1/1 sunxi: Fix sun5i mbus speed when booting old kernels
In reply to Hans de GoedeQuoted 20 lines · On Thu, 19 Feb 2015 14:59:16 +0100 Hans de Goede <[email protected]> wrote:
Older linux-sunxi-3.4 kernels override our PLL6 setting with 300 MHz, halving the mbus frequency, so set it to 300 MHz ourselves and base the mbus divider on that.
Signed-off-by Hans de Goede <[email protected]>--- arch/arm/include/asm/arch-sunxi/clock_sun4i.h | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm/include/asm/arch-sunxi/clock_sun4i.h +3
-0@@ -144,7 +144,16 @@ struct sunxi_ccm_reg {#define PLL1_CFG_DEFAULT 0xa1005000 +#if definedCONFIG_OLD_SUNXI_KERNEL_COMPAT && definedCONFIG_MACH_SUN5I +/* +* Older linux-sunxi-3.4 kernels override our PLL6 setting with 300 MHz,
arch/arm/include/asm/arch-sunxi/clock_sun4i.h struct sunxi_ccm_reg { · line 159
Quoted 10 lines
arch/arm/include/asm/arch-sunxi/clock_sun4i.h +6
-0+* halving the mbus frequency, so set it to 300 MHz ourselves and base the +* mbus divider on that. +*/ +#define PLL6_CFG_DEFAULT 0xa1009900 +#else #define PLL6_CFG_DEFAULT 0xa1009911 +#endif /* nand clock */ #define NAND_CLK_SRC_OSC24 0
Are there any good reasons to use 600MHz instead of 300MHz for PLL6 in the default u-boot build?
Maybe PLL6 can be just set to 300MHz for sun5i in all cases, regardless of the CONFIG_OLD_SUNXI_KERNEL_COMPAT define?
Signature · 2 lines
Best regards, Siarhei Siamashka
PATCH 1/1 sunxi: Fix sun5i mbus speed when booting old kernels
Hi,
Quoted 31 lines · Siarhei Siamashka
Quoted 28 lines · On Thu, 19 Feb 2015 14:59:16 +0100 Hans de Goede <[email protected]> wrote:
Older linux-sunxi-3.4 kernels override our PLL6 setting with 300 MHz, halving the mbus frequency, so set it to 300 MHz ourselves and base the mbus divider on that.
Signed-off-by Hans de Goede <[email protected]>--- arch/arm/include/asm/arch-sunxi/clock_sun4i.h | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm/include/asm/arch-sunxi/clock_sun4i.h +9
-0@@ -144,7 +144,16 @@ struct sunxi_ccm_reg {#define PLL1_CFG_DEFAULT 0xa1005000 +#if definedCONFIG_OLD_SUNXI_KERNEL_COMPAT && definedCONFIG_MACH_SUN5I +/* +* Older linux-sunxi-3.4 kernels override our PLL6 setting with 300 MHz, +* halving the mbus frequency, so set it to 300 MHz ourselves and base the +* mbus divider on that. +*/ +#define PLL6_CFG_DEFAULT 0xa1009900 +#else #define PLL6_CFG_DEFAULT 0xa1009911 +#endif
Quoted 8 lines
arch/arm/include/asm/arch-sunxi/clock_sun4i.h struct sunxi_ccm_reg { · line 159
Quoted 2 lines
arch/arm/include/asm/arch-sunxi/clock_sun4i.h +0
-0/* nand clock */ #define NAND_CLK_SRC_OSC24 0Are there any good reasons to use 600MHz instead of 300MHz for PLL6 in the default u-boot build?
Maybe PLL6 can be just set to 300MHz for sun5i in all cases, regardless of the
CONFIG_OLD_SUNXI_KERNEL_COMPATdefine?
Basically the reasons are the same as why you want to keep PLL5 running at a high speed, PLL6 is a potential parent PLL for all mod0 clk using peripherals, and having it higher gives us more possible clocks.
I agree that this (and the PLL5 speed) are an issue we need a better fix for then CONFIG_OLD_SUNXI_KERNEL_COMPAT if at all possible.
I'll discuss this further as a reply to your:
"[PATCH] sunxi: Machine id hack to prevent loading buggy sunxi-3.4 kernels" mail.
Regards,
Hans
PATCH 1/1 sunxi: Fix sun5i mbus speed when booting old kernels
Quoted 40 lines · On Fri, 20 Feb 2015 09:44:44 +0100 Hans de Goede <[email protected]> wrote:
Hi,
Quoted 37 lines · Siarhei Siamashka
Quoted 20 lines · On Thu, 19 Feb 2015 14:59:16 +0100 Hans de Goede <[email protected]> wrote:
Older linux-sunxi-3.4 kernels override our PLL6 setting with 300 MHz, halving the mbus frequency, so set it to 300 MHz ourselves and base the mbus divider on that.
Signed-off-by Hans de Goede <[email protected]>--- arch/arm/include/asm/arch-sunxi/clock_sun4i.h | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm/include/asm/arch-sunxi/clock_sun4i.h +3
-0@@ -144,7 +144,16 @@ struct sunxi_ccm_reg {#define PLL1_CFG_DEFAULT 0xa1005000 +#if definedCONFIG_OLD_SUNXI_KERNEL_COMPAT && definedCONFIG_MACH_SUN5I +/* +* Older linux-sunxi-3.4 kernels override our PLL6 setting with 300 MHz, arch/arm/include/asm/arch-sunxi/clock_sun4i.h struct sunxi_ccm_reg { · line 159
Quoted 10 lines
arch/arm/include/asm/arch-sunxi/clock_sun4i.h +6
-0+* halving the mbus frequency, so set it to 300 MHz ourselves and base the +* mbus divider on that. +*/ +#define PLL6_CFG_DEFAULT 0xa1009900 +#else #define PLL6_CFG_DEFAULT 0xa1009911 +#endif /* nand clock */ #define NAND_CLK_SRC_OSC24 0Are there any good reasons to use 600MHz instead of 300MHz for PLL6 in the default u-boot build?
Quoted 6 lines
Quoted 2 lines
Maybe PLL6 can be just set to 300MHz for sun5i in all cases, regardless of the
CONFIG_OLD_SUNXI_KERNEL_COMPATdefine?Basically the reasons are the same as why you want to keep PLL5 running at a high speed, PLL6 is a potential parent PLL for all mod0 clk using peripherals, and having it higher gives us more possible clocks.
Sure, I just expected a more concrete example out of curiosity.
PLL5P is a bit special, because it is tied to the DRAM clock frequency and may vary on different boards (because different boards use different DRAM clock speeds). But there is less variation possible for PLL6.
Quoted 6 lines
I agree that this (and the PLL5 speed) are an issue we need a better fix for then
CONFIG_OLD_SUNXI_KERNEL_COMPATif at all possible.I'll discuss this further as a reply to your:
"[PATCH] sunxi: Machine id hack to prevent loading buggy sunxi-3.4 kernels" mail.
Thanks.
Signature · 2 lines
Best regards, Siarhei Siamashka