Skip to contentSkip to conversation

dialog: bump to version 1.2-20150125

PATCH New Gustavo Zacarias 2 participants 3 messages Feb 21, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dialog: bump to version 1.2-20150125

And drop thread requirement, it's really not necessary. For python-dialog that was already inherent in python itself.

---
 package/dialog/Config.in        | 5 -----
 package/dialog/dialog.hash      | 2 +-
 package/dialog/dialog.mk        | 2 +-
 package/python-dialog/Config.in | 5 -----
 4 files changed, 2 insertions(+), 12 deletions(-)
package/dialog/Config.in +0 -5
index 929ab46..fc0e8fd 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_DIALOG
 	bool "dialog"
-	depends on BR2_TOOLCHAIN_HAS_THREADS # fork()
 	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_NCURSES
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
@@ -12,7 +11,3 @@ config BR2_PACKAGE_DIALOG
 	  of a script to interact with the user in a much friendlier manner.
 
 	  http://invisible-island.net/dialog/dialog.html
-
-comment "dialog needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
-	depends on BR2_USE_MMU
package/dialog/dialog.hash +1 -1
index 1ffbafb..75a7918 100644
@@ -1,2 +1,2 @@
 # Locally calculated after checking pgp signature
-sha256	d054766fba3dac828851f1c9852e5992eb824fd0a0dd26d87ee517242027bafc	dialog-1.2-20140911.tgz
+sha256	1d98ec7cc81f11f9019fa0b90f1afdaa86579cae1ce8869a6fd61deb9d4b887a	dialog-1.2-20150125.tgz
package/dialog/dialog.mk +1 -1
index 0ecbddb..f207f75 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-DIALOG_VERSION = 1.2-20140911
+DIALOG_VERSION = 1.2-20150125
 DIALOG_SOURCE = dialog-$(DIALOG_VERSION).tgz
 DIALOG_SITE = ftp://invisible-island.net/dialog
 DIALOG_CONF_OPTS = --with-ncurses --with-curses-dir=$(STAGING_DIR)/usr \
package/python-dialog/Config.in +0 -5
index 8dd3fdf..c1fdb23 100644
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_PYTHON_DIALOG
 	bool "python-dialog"
 	depends on BR2_PACKAGE_PYTHON
-	depends on BR2_TOOLCHAIN_HAS_THREADS # dialog
 	depends on BR2_USE_MMU # dialog
 	select BR2_PACKAGE_DIALOG
 	help
@@ -9,7 +8,3 @@ config BR2_PACKAGE_PYTHON_DIALOG
 	  mostly-compatible programs.
 
 	  http://pythondialog.sourceforge.net/
-
-comment "python-dialog needs a toolchain w/ threads"
-	depends on BR2_USE_MMU && BR2_PACKAGE_PYTHON
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.0.5
#1 lore raw

PATCH 1/1 dialog: bump to version 1.2-20150125

Dear Gustavo Zacarias,

Quoted 4 lines · Gustavo Zacarias

And drop thread requirement, it's really not necessary. For python-dialog that was already inherent in python itself.

Applied to next, thanks. Interestingly, it's you who added this thread dependency because dialog needs MMU. And Peter applied the patch. See:

commit 9d9d842d871b8645f70c3a90f59f8e2e09935656

Author: Gustavo Zacarias <[email protected]>
Date:   Fri Dec 28 00:59:00 2012 +0000

dialog: needs mmu

Fixes
http://autobuild.buildroot.net/results/b673ef6d6315dc5df77e000199a63f90904829d5

package/dialog/Config.in +1 -0
index 9d3462e..db5197f 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_DIALOG
        bool "dialog"
+       depends on BR2_TOOLCHAIN_HAS_THREADS # fork()
        select BR2_PACKAGE_NCURSES
        select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
        help

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 dialog: bump to version 1.2-20150125

Quoted 10 lines · Thomas Petazzoni

Dear Gustavo Zacarias,

Quoted 4 lines · Gustavo Zacarias

And drop thread requirement, it's really not necessary. For python-dialog that was already inherent in python itself.

Applied to next, thanks. Interestingly, it's you who added this thread dependency because dialog needs MMU. And Peter applied the patch. See:

Yes, i find it was odd as well and backtracked on it since tests say it's not required at all (and the TODO for dialog says "we want threads eventually" which is a clear sign heh).
Regards.