Skip to contentSkip to conversation

drm/i915/skl: Update edp 1.4 DDI translation table

PATCH In review Sonika Jindal 2 participants 4 messages Feb 21, 2015 – Feb 24, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/skl: Update edp 1.4 DDI translation table

Updating recommended DDI translation table for edp 1.4 as per bspec update

---
 drivers/gpu/drm/i915/intel_ddi.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +9 -9
index 114b729..f17cc48 100644
@@ -141,16 +141,16 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
 
 /* eDP 1.4 low vswing translation parameters */
 static const struct ddi_buf_trans skl_ddi_translations_edp[] = {
-	{ 0x00000018, 0x00000428 },
-	{ 0x00002016, 0x00000067 },
-	{ 0x00006012, 0x00000032 },
+	{ 0x00000018, 0x000000a8 },
+	{ 0x00002016, 0x000000ab },
+	{ 0x00006012, 0x000000a2 },
 	{ 0x00008010, 0x00000088 },
-	{ 0x00000018, 0x00000067 },
-	{ 0x00004014, 0x00000032 },
-	{ 0x00006012, 0x00000098 },
-	{ 0x00000018, 0x00000032 },
-	{ 0x00005013, 0x00000098 },
-	{ 0x00006012, 0x0000001e },
+	{ 0x00000018, 0x000000ab },
+	{ 0x00004014, 0x000000a2 },
+	{ 0x00006012, 0x000000a6 },
+	{ 0x00000018, 0x000000a2 },
+	{ 0x00005013, 0x0000009c },
+	{ 0x00000018, 0x00000088 },
 };
 
 
Signature · 6 lines
1.7.10.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 14 lines · Sonika Jindal

Updating recommended DDI translation table for edp 1.4 as per bspec update

---
 drivers/gpu/drm/i915/intel_ddi.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +0 -0
index 114b729..f17cc48 100644

drivers/gpu/drm/i915/intel_ddi.c static const struct ddi_buf_trans skl_ddi_translations_dp[] = { · line 143

Quoted 3 lines
drivers/gpu/drm/i915/intel_ddi.c +0 -0
@@ -141,16 +141,16 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
 
 /* eDP 1.4 low vswing translation parameters */
 static const struct ddi_buf_trans skl_ddi_translations_edp[] = {

I don't have an edp translation table at all for skl. Does this really apply on -nightly? If not please make it clear in the cover letter what your depencies are or just send everything in one patch series.

Thanks, Daniel

Quoted 29 lines
drivers/gpu/drm/i915/intel_ddi.c +9 -9
-	{ 0x00000018, 0x00000428 },
-	{ 0x00002016, 0x00000067 },
-	{ 0x00006012, 0x00000032 },
+	{ 0x00000018, 0x000000a8 },
+	{ 0x00002016, 0x000000ab },
+	{ 0x00006012, 0x000000a2 },
 	{ 0x00008010, 0x00000088 },
-	{ 0x00000018, 0x00000067 },
-	{ 0x00004014, 0x00000032 },
-	{ 0x00006012, 0x00000098 },
-	{ 0x00000018, 0x00000032 },
-	{ 0x00005013, 0x00000098 },
-	{ 0x00006012, 0x0000001e },
+	{ 0x00000018, 0x000000ab },
+	{ 0x00004014, 0x000000a2 },
+	{ 0x00006012, 0x000000a6 },
+	{ 0x00000018, 0x000000a2 },
+	{ 0x00005013, 0x0000009c },
+	{ 0x00000018, 0x00000088 },
 };
 
 
Signature · 6 lines
1.7.10.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#2 lore raw
Quoted 16 lines · Daniel Vetter
Quoted 15 lines · Sonika Jindal

Updating recommended DDI translation table for edp 1.4 as per bspec update

---
  drivers/gpu/drm/i915/intel_ddi.c |   18 +++++++++---------
  1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +0 -0
index 114b729..f17cc48 100644
@@ -141,16 +141,16 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
 
Quoted 7 lines

drivers/gpu/drm/i915/intel_ddi.c static const struct ddi_buf_trans skl_ddi_translations_dp[] = { · line 143

Quoted 2 lines
drivers/gpu/drm/i915/intel_ddi.c +0 -0
  /* eDP 1.4 low vswing translation parameters */
  static const struct ddi_buf_trans skl_ddi_translations_edp[] = {

I don't have an edp translation table at all for skl. Does this really apply on -nightly? If not please make it clear in the cover letter what your depencies are or just send everything in one patch series.

Thanks, Daniel

Hi Daniel,

Yes my bad in missing that info. This patch is dependent on "drm/i915/skl: Add support for edp1.4 low vswing" which is merged on -internal. Do I need to send out those rebased patches for -nightly?

Regards,
Sonika

Quoted 22 lines
Quoted 22 lines
drivers/gpu/drm/i915/intel_ddi.c +9 -9
-	{ 0x00000018, 0x00000428 },
-	{ 0x00002016, 0x00000067 },
-	{ 0x00006012, 0x00000032 },
+	{ 0x00000018, 0x000000a8 },
+	{ 0x00002016, 0x000000ab },
+	{ 0x00006012, 0x000000a2 },
  	{ 0x00008010, 0x00000088 },
-	{ 0x00000018, 0x00000067 },
-	{ 0x00004014, 0x00000032 },
-	{ 0x00006012, 0x00000098 },
-	{ 0x00000018, 0x00000032 },
-	{ 0x00005013, 0x00000098 },
-	{ 0x00006012, 0x0000001e },
+	{ 0x00000018, 0x000000ab },
+	{ 0x00004014, 0x000000a2 },
+	{ 0x00006012, 0x000000a6 },
+	{ 0x00000018, 0x000000a2 },
+	{ 0x00005013, 0x0000009c },
+	{ 0x00000018, 0x00000088 },
  };
 
 
Quoted 7 lines
Quoted 7 lines
Signature · 6 lines
1.7.10.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 23 lines · sonika
Quoted 21 lines · Daniel Vetter
Quoted 14 lines · Sonika Jindal

Updating recommended DDI translation table for edp 1.4 as per bspec update

---
 drivers/gpu/drm/i915/intel_ddi.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +0 -0
index 114b729..f17cc48 100644

drivers/gpu/drm/i915/intel_ddi.c static const struct ddi_buf_trans skl_ddi_translations_dp[] = { · line 142

Quoted 2 lines
drivers/gpu/drm/i915/intel_ddi.c +0 -0
@@ -141,16 +141,16 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
 /* eDP 1.4 low vswing translation parameters */
 static const struct ddi_buf_trans skl_ddi_translations_edp[] = {

I don't have an edp translation table at all for skl. Does this really apply on -nightly? If not please make it clear in the cover letter what your depencies are or just send everything in one patch series.

Quoted 7 lines
Quoted 1 line

Thanks, Daniel

Hi Daniel,

Yes my bad in missing that info. This patch is dependent on "drm/i915/skl:
Add support for edp1.4 low vswing"
which is merged on -internal. Do I need to send out those rebased patches for -nightly?

Yes, when submitting patches to the public mailing list please make sure that they apply on the public drm-intel-nightly branch. If needed include any other depencies in your series or rebase around missing bits that are still embargoed.

Since the original patch is -internal too you probably can squash this fixup into the patch with added the edp table originally.

Cheers, Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx