Skip to contentSkip to conversation

sunxi: Make CONFIG_DRAM_TPR3 apply to sun[57]i

PATCH New Adam Sampson 3 participants 3 messages Feb 23, 2015 – Feb 24, 2015 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi: Make CONFIG_DRAM_TPR3 apply to sun[57]i

The tpr3 (timing skew) parameter is used in all supported versions of the sunxi DRAM controller, but it was only enabled for sun4i in 47e3501a76894f4ba08bc61f33774bd5d39ff464.

---
 board/sunxi/dram_sun5i_auto.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/sunxi/dram_sun5i_auto.c +1 -1
index e52d54c..660b18e 100644
@@ -24,7 +24,7 @@ static struct dram_para dram_para = {
 #	include "dram_timings_sun4i.h"
 	.active_windowing = 1,
 #endif
-	.tpr3 = 0,
+	.tpr3 = CONFIG_DRAM_TPR3,
 	.tpr4 = 0,
 	.tpr5 = 0,
 	.emr1 = CONFIG_DRAM_EMR1,
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 sunxi: Make CONFIG_DRAM_TPR3 apply to sun[57]i

Quoted 14 lines · On Mon, 23 Feb 2015 20:44:10 +0000 Adam Sampson <[email protected]> wrote:

The tpr3 (timing skew) parameter is used in all supported versions of the sunxi DRAM controller, but it was only enabled for sun4i in 47e3501a76894f4ba08bc61f33774bd5d39ff464.

---
 board/sunxi/dram_sun5i_auto.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/sunxi/dram_sun5i_auto.c +0 -0
index e52d54c..660b18e 100644

board/sunxi/dram_sun5i_auto.c static struct dram_para dram_para = { · line 30

Quoted 8 lines
board/sunxi/dram_sun5i_auto.c +1 -1
@@ -24,7 +24,7 @@ static struct dram_para dram_para = {
 #	include "dram_timings_sun4i.h"
 	.active_windowing = 1,
 #endif
-	.tpr3 = 0,
+	.tpr3 = CONFIG_DRAM_TPR3,
 	.tpr4 = 0,
 	.tpr5 = 0,
 	.emr1 = CONFIG_DRAM_EMR1,

Oops. Thanks for spotting this.

Signature · 2 lines
Best regards,
Siarhei Siamashka
#2 lore raw

PATCH 1/1 sunxi: Make CONFIG_DRAM_TPR3 apply to sun[57]i

Hi,

Quoted 28 lines · Siarhei Siamashka
Quoted 14 lines · On Mon, 23 Feb 2015 20:44:10 +0000 Adam Sampson <[email protected]> wrote:

The tpr3 (timing skew) parameter is used in all supported versions of the sunxi DRAM controller, but it was only enabled for sun4i in 47e3501a76894f4ba08bc61f33774bd5d39ff464.

---
  board/sunxi/dram_sun5i_auto.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
board/sunxi/dram_sun5i_auto.c +0 -0
index e52d54c..660b18e 100644

board/sunxi/dram_sun5i_auto.c static struct dram_para dram_para = { · line 30

Quoted 8 lines
board/sunxi/dram_sun5i_auto.c +1 -1
@@ -24,7 +24,7 @@ static struct dram_para dram_para = {
  #	include "dram_timings_sun4i.h"
  	.active_windowing = 1,
  #endif
-	.tpr3 = 0,
+	.tpr3 = CONFIG_DRAM_TPR3,
  	.tpr4 = 0,
  	.tpr5 = 0,
  	.emr1 = CONFIG_DRAM_EMR1,

Oops. Thanks for spotting this.

Quoted 1 line

Thanks!

Queued up in u-boot-sunxi/next for merging, with Siarhei's ack,

Regards,

Hans