Skip to contentSkip to conversation

bq27x00_battery: register as non-wakeup power supply.

PATCH In review NeilBrown 2 participants 2 messages Feb 24, 2015 – Feb 25, 2015

lore
Share & tools
lore

NeilBrown

author
#0 lore raw

PATCH 1/1 bq27x00_battery: register as non-wakeup power supply.

power_supply status changes for the bq27x00 are only noticed via polling, not via interrupts. So they are never the source of events which should reliably wake the system from suspend.
So it is appropriate to register as a no_ws power source, just like the ACPI battery.

This removes some debugging messages which occasionally confusingly identify bq27x00 as a wakeup source.

drivers/power/bq27x00_battery.c +1 -1
index b72ba7c1bd69..93d2b7f910f1 100644
@@ -755,7 +755,7 @@ static int bq27x00_powersupply_init(struct bq27x00_device_info *di)
 	INIT_DELAYED_WORK(&di->work, bq27x00_battery_poll);
 	mutex_init(&di->lock);
 
-	ret = power_supply_register(di->dev, &di->bat);
+	ret = power_supply_register_no_ws(di->dev, &di->bat);
 	if (ret) {
 		dev_err(di->dev, "failed to register battery: %d\n", ret);
 		return ret;
#1 lore raw

Hi,

Quoted 10 lines · NeilBrown

power_supply status changes for the bq27x00 are only noticed via polling, not via interrupts. So they are never the source of events which should reliably wake the system from suspend. So it is appropriate to register as a no_ws power source, just like the ACPI battery.

This removes some debugging messages which occasionally confusingly identify bq27x00 as a wakeup source.

pulled into battery-2.6.git.

-- Sebastian