Skip to contentSkip to conversation

tegra20: tamonten: Fix the early gpio init

PATCH New Alban Bedel 2 participants 5 messages Feb 24, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tegra20: tamonten: Fix the early gpio init

To set gpio during the early init we now need to use tegra_spl_gpio_direction_output(), copied from seaboard.

---
 board/avionic-design/common/tamonten.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
board/avionic-design/common/tamonten.c +3 -1
index 9c86779..ea2425a 100644
@@ -23,8 +23,10 @@
 #ifdef CONFIG_BOARD_EARLY_INIT_F
 void gpio_early_init(void)
 {
+#ifndef CONFIG_SPL_BUILD
 	gpio_request(GPIO_PI4, NULL);
-	gpio_direction_output(GPIO_PI4, 1);
+#endif
+	tegra_spl_gpio_direction_output(GPIO_PI4, 1);
 }
 #endif
 
Signature · 1 line
2.3.0
#1 lore raw

PATCH 1/1 tegra20: tamonten: Fix the early gpio init

Quoted 2 lines · Alban Bedel

To set gpio during the early init we now need to use tegra_spl_gpio_direction_output(), copied from seaboard.

Can you explain "now" a bit more. Did some previous commit change the behaviour of the GPIO API? If so, if you could reference the commit hash and subject that'd be useful.

#2 lore raw

PATCH 1/1 tegra20: tamonten: Fix the early gpio init

Quoted 7 lines · On Tue, 24 Feb 2015 10:02:04 -0700 Stephen Warren <[email protected]> wrote:
Quoted 2 lines · Alban Bedel

To set gpio during the early init we now need to use tegra_spl_gpio_direction_output(), copied from seaboard.

Can you explain "now" a bit more. Did some previous commit change the behaviour of the GPIO API? If so, if you could reference the commit hash and subject that'd be useful.

This a repost, see [1] for the details. In short this is needed because the GPIO driver isn't available at this point. In October I have been told this will be fixed soon. Now the GPIO driver is still not fixed and all tamonten boards are still broken.

Without this fix all board peripherals are unusable on all Tamonten board, it would be really nice to have this integrated.

Alban

[1] http://lists.denx.de/pipermail/u-boot/2014-October/190464.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150224/531257b9/attachment.sig>

#3 lore raw

PATCH 1/1 tegra20: tamonten: Fix the early gpio init

Quoted 16 lines · Alban Bedel
Quoted 7 lines · On Tue, 24 Feb 2015 10:02:04 -0700 Stephen Warren <[email protected]> wrote:
Quoted 2 lines · Alban Bedel

To set gpio during the early init we now need to use tegra_spl_gpio_direction_output(), copied from seaboard.

Can you explain "now" a bit more. Did some previous commit change the behaviour of the GPIO API? If so, if you could reference the commit hash and subject that'd be useful.

This a repost, see [1] for the details. In short this is needed because the GPIO driver isn't available at this point. In October I have been told this will be fixed soon. Now the GPIO driver is still not fixed and all tamonten boards are still broken.

Quoted 6 lines

Without this fix all board peripherals are unusable on all Tamonten board, it would be really nice to have this integrated.

Alban

[1] http://lists.denx.de/pipermail/u-boot/2014-October/190464.html

OK. My point was that the commit description should describe the source of the problem so that anyone looking through git history understands the issues without having to search email lists too.

#4 lore raw

PATCH 1/1 tegra20: tamonten: Fix the early gpio init

Quoted 20 lines · On Tue, 24 Feb 2015 10:22:52 -0700 Stephen Warren <[email protected]> wrote:
Quoted 19 lines · Alban Bedel
Quoted 7 lines · On Tue, 24 Feb 2015 10:02:04 -0700 Stephen Warren <[email protected]> wrote:
Quoted 2 lines · Alban Bedel

To set gpio during the early init we now need to use tegra_spl_gpio_direction_output(), copied from seaboard.

Can you explain "now" a bit more. Did some previous commit change the behaviour of the GPIO API? If so, if you could reference the commit hash and subject that'd be useful.

This a repost, see [1] for the details. In short this is needed because the GPIO driver isn't available at this point. In October I have been told this will be fixed soon. Now the GPIO driver is still not fixed and all tamonten boards are still broken.

Without this fix all board peripherals are unusable on all Tamonten board, it would be really nice to have this integrated.

Quoted 7 lines
Quoted 3 lines

Alban

[1] http://lists.denx.de/pipermail/u-boot/2014-October/190464.html

OK. My point was that the commit description should describe the source of the problem so that anyone looking through git history understands the issues without having to search email lists too.

Right, I'll post a V2 tomorrow with a better log.

Alban
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150224/d0b7af21/attachment.sig>